Re: dlls/user32/combo.c: Fix an issue where pressing 's' in a combobox shows the dropdown isntead of finding an entry starting with 's'.

2009-12-28 Thread Dmitry Timoshkov
"David Quintana (gigaherz)" wrote: Issue was caused by VK_F4 having the same exact code as a lowercase 's'. So the code, which treated WM_CHAR and WM_KEYDOWN as the same, executed the wrong piece of code which was meant to be ONLY for WM_KEYDOWN. Thanks for spotting this bug. Anyway the fix i

Re: Building and packaging Wine Gecko

2009-12-28 Thread Austin English
On Mon, Dec 28, 2009 at 6:53 PM, Jacek Caban wrote: > On 12/29/09 1:44 AM, Ove Kaaven wrote: >> gcc 4.4.2 is already released, and >> Debian unstable is using it as the default compiler. And like I >> mentioned, they even have a mingw32 cross compiler of it. Would it then >> be a good idea to buil

Re: avifile tests

2009-12-28 Thread Julius Schwartzenberg
Hi André André Hentschel wrote: > Julius Schwartzenberg schrieb: >> What do you think of the >> general idea of the tests? > > As i cant proof correctness here, i just can say that the general idea is great. > Until Bug 14085 is fixed you can todo_wine it out. Further i think you can leave the

Re: avifile tests

2009-12-28 Thread Julius Schwartzenberg
Hi Dmitry, Thanks a lot for your feedback! I should've solved most issues you pointed me at. I have attached a new version of the patch. Dmitry Timoshkov wrote: Indentation of above structure and all others below this one look strange. 4 spaces would be quite enough. This was supposed to re

Re: Difficulty fixing a regression in reading text files with MSVCRT

2009-12-28 Thread Dan Kegel
Hi Erich, thanks for that test case. I'm overloaded at the moment, but if you file a bug, I'll try to have a look... - Dan On Mon, Dec 28, 2009 at 5:03 PM, Erich Hoover wrote: > In a surprise last-minute request it became necessary for me to get > Athena Visual Studio running under Wine again >

Difficulty fixing a regression in reading text files with MSVCRT

2009-12-28 Thread Erich Hoover
In a surprise last-minute request it became necessary for me to get Athena Visual Studio running under Wine again (http://appdb.winehq.org/objectManager.php?sClass=version&iId=15183). A couple of commits to MSVCRT (that are needed for other reasons) caused regressions in Wine's ability to run this

Re: Building and packaging Wine Gecko

2009-12-28 Thread Jacek Caban
On 12/29/09 1:44 AM, Ove Kaaven wrote: Jacek Caban skrev: I'm not sure what to do about this. Any ideas about something I can do to make it build with gcc 4.2 or 4.4? The only compiler you can use for Wine Gecko 1.0.0 is GCC 3.4.5. Current Git version uses GCC 4.4 SVN version (waiting f

Re: Building and packaging Wine Gecko

2009-12-28 Thread Ove Kaaven
Jacek Caban skrev: > It does suffer from this bug, these tests are probably not enough to > show it. Hmm. I had hoped the debian version had patched it or something, especially considering how often stdcall is going to be used by a win32 compiler... >> I'm not sure what to do about this. Any idea

Re: Guide for creating new AppInstall tests

2009-12-28 Thread Austin English
On Mon, Dec 28, 2009 at 4:13 PM, Sam S. wrote: > Hello Wine team! > > After reading the introduction to AppInstall at > http://www.winehq.org/wwn/360, I decided to try and write some > additional application tests for it. > There are at least two freely downloadable win32 apps that I run with > Wi

Re: dlls/user32/combo.c: Fix an issue where pressing 's' in a combobox shows the dropdown isntead of finding an entry starting with 's'.

2009-12-28 Thread Nikolay Sivov
On 12/28/2009 22:18, David Quintana (gigaherz) wrote: Issue was caused by VK_F4 having the same exact code as a lowercase 's'. So the code, which treated WM_CHAR and WM_KEYDOWN as the same, executed the wrong piece of code which was meant to be ONLY for WM_KEYDOWN. Patch is attached.

Re: Removing WPARAM/LPARAM Casts

2009-12-28 Thread Michael Stefaniuc
On 12/28/2009 03:06 AM, James Mckenzie wrote: I've noticed that Michael Stefuic (sp?) has removed quite a few WPARAM/LPARAM casts when calling SendMessage() and was wondering/inquiring if he was going do this to riched20/tests/editor.c since I noticed he put in a change for riched20. Michael are

Guide for creating new AppInstall tests

2009-12-28 Thread Sam S.
Hello Wine team! After reading the introduction to AppInstall at http://www.winehq.org/wwn/360, I decided to try and write some additional application tests for it. There are at least two freely downloadable win32 apps that I run with Wine, that have in the past (in my experience) been quite sensi

Re: Building and packaging Wine Gecko

2009-12-28 Thread Jacek Caban
On 12/28/09 4:51 PM, Steven Edwards wrote: On Mon, Dec 28, 2009 at 2:34 AM, Ove Kaaven wrote: OK, I've almost got a wine-gecko package built 100% from source, but there's a problem: the gcc version in Debian's mingw32, namely gcc 4.2.1-sjlj, apparently miscompiles the wine-gecko 1.0.0 sourc

Re: Building and packaging Wine Gecko

2009-12-28 Thread Jacek Caban
On 12/28/09 8:34 AM, Ove Kaaven wrote: OK, I've almost got a wine-gecko package built 100% from source, but there's a problem: the gcc version in Debian's mingw32, namely gcc 4.2.1-sjlj, apparently miscompiles the wine-gecko 1.0.0 sources, the resulting Gecko just crashes. (The mingw32 version in

Re: [PATCH 3/5] wined3d: Introduce "context_apply_state()" to setup a context for a specific usage.

2009-12-28 Thread Stefan Dösinger
Am 28.12.2009 um 11:32 schrieb Henri Verbeet: > 2009/12/28 Stefan Dösinger : >> The patch looks ok to me, but out of curiosity: Do you intend to make this >> function available to other wined3d code like context_acquire is, or is the >> main motivation of the patch to tidy up the context_acquir

Re: Remove Macintosh platform

2009-12-28 Thread Jeremy Newman
Macintosh is removed. -N Austin English wrote: Done. Sorry about that.

Re: Remove Macintosh platform

2009-12-28 Thread Austin English
Done. Sorry about that. -- -Austin On Mon, Dec 28, 2009 at 9:46 AM, Jeremy Newman wrote: > http://bugs.winehq.org/buglist.cgi?rep_platform=Macintosh > > Still need to change the value on the closed bugs as well before it can be > deleted. > > -N > > Austin English wrote: >> >> I just moved the

Re: [PATCH 1/3] wininet: Test also InternetCrackUrlW in test_crack_url.

2009-12-28 Thread Paul Vriens
On 12/27/2009 01:27 AM, Jacek Caban wrote: --- dlls/wininet/tests/url.c | 77 ++ 1 files changed, 77 insertions(+), 0 deletions(-) Hi Jacek, Looks like these tests need at least IE7 to succeed. Could you have a look? -- Cheers, Paul.

Re: Acting as advisor for wcmd-uplift project?

2009-12-28 Thread Dan Kegel
On Mon, Dec 28, 2009 at 7:18 AM, Paul Vriens wrote: > I also guess that the error messages will be different on the different OS > versions out there. Yeah, and those pesky copyright laws might prevent us from copying error messages verbatim unless it's required for interoperability. I've update

Re: Building and packaging Wine Gecko

2009-12-28 Thread Steven Edwards
On Mon, Dec 28, 2009 at 2:34 AM, Ove Kaaven wrote: > OK, I've almost got a wine-gecko package built 100% from source, but > there's a problem: the gcc version in Debian's mingw32, namely gcc > 4.2.1-sjlj, apparently miscompiles the wine-gecko 1.0.0 sources, the > resulting Gecko just crashes. (The

Re: Remove Macintosh platform

2009-12-28 Thread Jeremy Newman
http://bugs.winehq.org/buglist.cgi?rep_platform=Macintosh Still need to change the value on the closed bugs as well before it can be deleted. -N Austin English wrote: I just moved the last macintosh platforms to ppc32/x86, so can someone with the appropriate permissions remove that option.

Re: Defining missing DirectInput constants

2009-12-28 Thread Vitaliy Margolen
Javier Kohen wrote: > Is it OK to copy constant definitions from Microsoft's SDK? If not, can > somebody help me or give some pointers on how to figure them out? Yes, as long as you type it yourself and don't copy&paste. Vitaliy.

Re: Acting as advisor for wcmd-uplift project?

2009-12-28 Thread Paul Vriens
On 12/28/2009 04:07 PM, Dan Kegel wrote: On Mon, Dec 28, 2009 at 6:57 AM, Alexandre Julliard wrote: You can't test error messages since in general they won't be identical between Wine and Windows. The Wine messages should be written in our own words, unless there is an app that explicitly depen

Re: Acting as advisor for wcmd-uplift project?

2009-12-28 Thread Dan Kegel
On Mon, Dec 28, 2009 at 6:57 AM, Alexandre Julliard wrote: > You can't test error messages since in general they won't be identical > between Wine and Windows. The Wine messages should be written in our own > words, unless there is an app that explicitly depends on the exact > Windows message. I

Re: Acting as advisor for wcmd-uplift project?

2009-12-28 Thread Alexandre Julliard
Dan Kegel writes: >> Also, your tests are very risky in terms of non-English locales. I think we >> shouldn't test error messages strings. > > Can we force the locale to a particular value for the tests > with a registry key or something? It'd be pretty hard to write > tests without checking *an

Re: [PATCH 2/3] wininet: Always set lpszUrlPath in InternetCrackUrlW.

2009-12-28 Thread Alexandre Julliard
Jacek Caban writes: > --- > dlls/wininet/internet.c | 38 +- > 1 files changed, 13 insertions(+), 25 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so internet.c && touch internet.ok win

Re: [TRY 2] extrac32: Create directory tree before extraction

2009-12-28 Thread Ilya Shpigor
Hi, Why this patch don't have been commited? There are mistakes? I really want to make extrac32 better, but I don't know what to do if nobody answer me. -- Best regards, Ilya Shpigor.

Re: [PATCH 3/5] wined3d: Introduce "context_apply_state()" to setup a context for a specific usage.

2009-12-28 Thread Henri Verbeet
2009/12/28 Stefan Dösinger : > The patch looks ok to me, but out of curiosity: Do you intend to make this > function available to other wined3d code like context_acquire is, or is the > main motivation of the patch to tidy up the context_acquire() function? > I'll probably kill the "usage" argume

Re: Remove cpp_quote hackery from wined3d.idl

2009-12-28 Thread Gerald Pfeifer
On Thu, 24 Dec 2009, Henri Verbeet wrote: >> Done thusly.  We just need to move WINEMAKEFOURCC to a local header, >> the rest of the cpp_quote can go and we lose a couple of dozen warning >> messages (rightfully) issued by GCC 4.5 snapshots. > I already sent pretty much the same patch, > http://sou

Re: Remove cpp_quote hackery from wined3d.idl

2009-12-28 Thread Henri Verbeet
2009/12/28 Gerald Pfeifer : > In dlls/wined3d/directx.c we have the following where I wonder whether > you may want to add this to the enum as well? > >        case WINEMAKEFOURCC('I','N','S','T'): >            TRACE("ATI Instancing check hack\n"); >            if (gl_info->supported[ARB_VERTEX_PRO

Re: msvcrt: add some demangle features

2009-12-28 Thread Eric Pouech
André Hentschel a écrit : Eric Pouech schrieb: André Hentschel a écrit : - +if (*sym->current == 'A') sym->current++; I don't understand how this would be necessary? Are you sure it's needed ? A+ There is also the possibility "P" for "multidimensional arrays".