[rfc] initial conformance test for programs/cmd

2009-12-31 Thread Dan Kegel
How's this look? I've only tested it lightly, but it should be pretty close; with this, "make test" ought to recurse down into programs/cmd/tests and run the cmd tests, too. Shortcomings: - I don't think I need chomp() in tests/cmd.c anymore, that was a workaround - I think I can turn on echo aga

Re: va_list breakage introduced today

2009-12-31 Thread Gerald Pfeifer
On Thu, 31 Dec 2009, Reece Dunn wrote: > Have you tried this patch?: > http://www.winehq.org/pipermail/wine-patches/2009-December/083364.html > (This is in the latest git -- Yep, that works. Thanks! Gerald

valgrind bot back online

2009-12-31 Thread Dan Kegel
The valgrind bot seems to have locked up soon after I left for vacation, but it's back up. Today's results: http://kegel.com/wine/valgrind/logs/2009-12-31-09.07/ Stats: 1 Invalid free/ delete / delete[] 1 Use of uninitialised value of size 4 2 Invalid write of size 4 2 Sou

Re: va_list breakage introduced today

2009-12-31 Thread Reece Dunn
2009/12/30 Gerald Pfeifer : > I believe the following patch > >  commit 8268ed978389662c7b43212e008037cae3ce900e >  Author: Alexandre Julliard >  Date:   Mon Dec 28 22:19:31 2009 +0100 > >    kernel32: Do not include 16-bit headers in 32-bit files. > > is causing > > gmake[2]: Entering directory `

va_list breakage introduced today

2009-12-31 Thread Gerald Pfeifer
I believe the following patch commit 8268ed978389662c7b43212e008037cae3ce900e Author: Alexandre Julliard Date: Mon Dec 28 22:19:31 2009 +0100 kernel32: Do not include 16-bit headers in 32-bit files. is causing gmake[2]: Entering directory `/usr/test/Wine/dlls/kernel32' /files/pfei

Re: WineTestBot changes

2009-12-31 Thread André Hentschel
Greg Geldorp schrieb: > I've completed phase 2 of the testbot: besides (32 and 64 bit) Windows > executables you can now also submit patch files to the bot. The bot will > apply the patch files to a clean git tree, cross-compile the test and run the > test on Windows VMs. You'll also be able to

Re: [PATCH 2/2] d3d10: Parse effect shaders as anonymous shaders.

2009-12-31 Thread Henri Verbeet
2009/12/31 Rico Schüller : > struct d3d10_effect_shader_variable *s; ... > +v->data = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(struct > d3d10_effect_shader_variable)); ... > +s = v->data; I think this would be nicer: s = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeo

Re: [PATCH 1/2] d3d10: Add a function to initialize the null variables.

2009-12-31 Thread Henri Verbeet
2009/12/31 Rico Schüller : > +static struct d3d10_effect_variable null_local_buffer = {0}; > +static struct d3d10_effect_variable null_variable = {0}; > +static struct d3d10_effect_variable null_scalar_variable = {0}; > +static struct d3d10_effect_variable null_vector_variable = {0}; > +static stru

Re: Tango Icons (Almost) Ready to Go!!

2009-12-31 Thread André Hentschel
Joel Holdsworth schrieb: > > For this reason I think the best thing would be for me to tidy up my > project directory and upload it as a tarball somewhere. There's enough > source material there so that someone could come and adjust the icons - > even it's not as elegant as having it tied into the

Re: [3/4] jscript: Fix various memory and reference count leaks.

2009-12-31 Thread Jacek Caban
On 12/31/09 1:17 PM, Rob Shearman wrote: 2009/12/30 Jacek Caban: Hi Rob, Thanks for your work on jscript. Unfortunately fixing Valgrind on jscript is not going to be easy. Most of your fixes are good, except clear_global part and "jscript: Fix a circular reference caused by object and funct

Re: Tango Icons (Almost) Ready to Go!!

2009-12-31 Thread Joel Holdsworth
On Thu, 2009-12-31 at 10:20 +0100, Warren Dumortier wrote: > Thanks for all your work (is there some screenshot)? > There's no doubt that the Tango icons are good, but would it be > possible to easily make icon themes maybe, to have Oxygen icons for > example? If i understand it's hardcoded, like o

Re: Tango Icons (Almost) Ready to Go!!

2009-12-31 Thread Joel Holdsworth
On Thu, 2009-12-31 at 11:34 +0100, Alexandre Julliard wrote: > Joel Holdsworth writes: > > > My final question is about what to do with my source artwork. The > > artwork has been collected from a variety of sources. Some is SVGs, some > > gimp .xcf.bz2s, and some plain PNGs. I guess these should

Re: [PATCH] hlink/tests: Repair test to work as intended

2009-12-31 Thread Andrew Eikum
On 12/31/2009 06:42 AM, Paul Vriens wrote: On 12/29/2009 12:40 AM, Andrew Eikum wrote: Paul Vriens 'fixed' this test to ensure that two strings are not the same. Instead, the test should test that two strings _are_ the same, but I accidentally compared the wrong strings in the original version.

Re: WineTestBot changes

2009-12-31 Thread Reece Dunn
2009/12/31 Greg Geldorp : > I've completed phase 2 of the testbot: besides (32 and 64 bit) Windows > executables you can now also submit patch files to the bot. The bot will > apply the patch files to a clean git tree, cross-compile the test and run the > test on Windows VMs. You'll also be able

WineTestBot changes

2009-12-31 Thread Greg Geldorp
I've completed phase 2 of the testbot: besides (32 and 64 bit) Windows executables you can now also submit patch files to the bot. The bot will apply the patch files to a clean git tree, cross-compile the test and run the test on Windows VMs. You'll also be able to download the cross-compiled te

Re: [1/7] avifile: Initial test data and simple test for avifil32 depends

2009-12-31 Thread Paul Vriens
On 12/30/2009 03:21 AM, Julius Schwartzenberg wrote: This patch depends on Detlef Riekenberg's patch from June 2008 and expects it to have been applied: http://www.winehq.org/pipermail/wine-patches/2008-June/056310.html It was not committed due to bug 14085: http://bugs.winehq.org/show_bug.cgi?i

Re: [PATCH] hlink/tests: Repair test to work as intended

2009-12-31 Thread Paul Vriens
On 12/29/2009 12:40 AM, Andrew Eikum wrote: Paul Vriens 'fixed' this test to ensure that two strings are not the same. Instead, the test should test that two strings _are_ the same, but I accidentally compared the wrong strings in the original version. --- dlls/hlink/tests/browse_ctx.c | 19

Re: [3/4] jscript: Fix various memory and reference count leaks.

2009-12-31 Thread Rob Shearman
2009/12/30 Jacek Caban : > Hi Rob, > > Thanks for your work on jscript. Unfortunately fixing Valgrind on jscript is > not going to be easy. Most of your fixes are good, except clear_global part > and "jscript: Fix a circular reference caused by object and function objects > being able to have prope

Re: Tango Icons (Almost) Ready to Go!!

2009-12-31 Thread Alexandre Julliard
Joel Holdsworth writes: > My final question is about what to do with my source artwork. The > artwork has been collected from a variety of sources. Some is SVGs, some > gimp .xcf.bz2s, and some plain PNGs. I guess these shouldn't go into the > wine source repo, but does anyone have any bright ide

Re: [2/3] kernel32: Generate the CommonProgramFiles and ProgramFiles environment variables.

2009-12-31 Thread Alexandre Julliard
Andrew Nguyen writes: > Some experimentation showed that the registry values that are read do > control the CommonProgramFiles and ProgramFiles environment variables. Is there any reason to not define it like the other environment variables? Is there really an app that would change the CurrentV