Re: oleaut32: Return type mismatch errors in ITypeLibComp_fnBind.

2010-03-12 Thread Vincent Povirk
We may search multiple modules/types, and we shouldn't necessarily return the failure code of the last one we searched. If we ever get a type mismatch error, we should return that error, but the last result we get will most likely be "not found", or S_OK with a DESCKIND_NONE. (I'm not sure whether

Re: oleaut32: Return type mismatch errors in ITypeLibComp_fnBind.

2010-03-12 Thread Nikolay Sivov
On 3/12/2010 23:56, Vincent Povirk wrote: ITypeLibImpl *This = impl_from_ITypeComp(iface); ITypeInfoImpl *pTypeInfo; +int typemismatch=0; Do you really need this one? Looks like it's enough to move hr at top level and use it.

Documentation?

2010-03-12 Thread André Hentschel
Hi Folks, As we are getting somehow closer to Wine 1.2 i wonder how important updates on the Documentation are. Further i am confused about sending patches, should they just change the git-repo "docs" or the pages on the website or both? -- Best Regards, André Hentschel

Re: wineaudiofile.acm: Initial commit

2010-03-12 Thread Aric Stewart
Thanks! Henri Verbeet wrote: +ERR("Feed Error %c%c%c%c\n", (char) (ret>> 24), + (char) (ret>> 16), + (char) (ret>> 8), + (char) ret); debugstr_an((const char *)&ret, 4); may be ea

Re: mciavi: Prevent deadlock when closing while playing or when paused.

2010-03-12 Thread Maarten Lankhorst
Hi Joerg, On 12-03-10 16:02, joerg-cyril.hoe...@t-systems.com wrote: Hi, Maarten Lankhorst wrote: Using a winmm timer there would remove the need for that thread altogether Please explain the idea. as part of my sound rewrite I will write a new winmm driver My understan

Re: [PATCH] msvcr80: Add msvcr80.dll with forwards to msvcrt.dll

2010-03-12 Thread Paul Chitescu
On Friday 12 March 2010 04:52:53 pm Detlef Riekenberg wrote: > Installing VC2008 runtime is no longer needed > for some apps. > > [...] Which applications are you talking about? All applications I've seen that use MSVCR80 or MSVCR90 need a proper assembly install (with manifest and possibly po

Re: wineaudiofile.acm: Initial commit

2010-03-12 Thread Henri Verbeet
Not claiming to know a whole lot about OS X or audio, but these are some general things I noticed: On 12 March 2010 16:41, Aric Stewart wrote: > +/* leopad functions */ Typo. > +static tAudioFileStreamOpen pAudioFileStreamOpen = NULL; > +static tAudioFileStreamSeek pAudioFileStreamSeek = NULL; >

mciavi: Prevent deadlock when closing while playing or when paused.

2010-03-12 Thread Joerg-Cyril.Hoehle
Hi, Maarten Lankhorst wrote: >Using a winmm timer there would remove the >need for that thread altogether Please explain the idea. >as part of my sound rewrite I will write a new winmm driver My understanding is that there will be a new winmm, but all MCI* drivers operate on top of that and are n

Re: 1/3 wined3d: Extend surface_get_depth_blt_info with texture coordinate code from surface_blt_to_drawable

2010-03-12 Thread Henri Verbeet
On 11 March 2010 22:25, Roderick Colenbrander wrote: > +static void surface_get_depth_blt_info(GLenum target, RECT *rect_in, GLsizei > w, GLsizei h, struct depth_blt_info *info) "rect_in" should be const, looks ok otherwise.

Re: 1/2 wined3d: Implement IWineD3DDeviceImpl_ColorFill using ClearSurface instead of 'BltOverride'

2010-03-12 Thread Roderick Colenbrander
On Fri, Mar 12, 2010 at 11:58 AM, Stefan Dösinger wrote: > > Am 11.03.2010 um 22:34 schrieb Roderick Colenbrander: > >> Hi, >> >> This patch makes IWineD3DDeviceImpl_ColorFill use Clear instead of >> BltOverride for color filling (it falls back to software blit if this >> is not possible). This ch

Re: 1/2 wined3d: Implement IWineD3DDeviceImpl_ColorFill using ClearSurface instead of 'BltOverride'

2010-03-12 Thread Stefan Dösinger
Am 11.03.2010 um 22:34 schrieb Roderick Colenbrander: > Hi, > > This patch makes IWineD3DDeviceImpl_ColorFill use Clear instead of > BltOverride for color filling (it falls back to software blit if this > is not possible). This change makes it possible in a next patch to > have the GL Blt call I

Re: winemp3.acm on the mac

2010-03-12 Thread Marcus Meissner
On Thu, Mar 11, 2010 at 08:46:27PM -0600, Aric Stewart wrote: > Hello all, > > So I have been hacking on winemp3.acm on the mac to make use of > CoreAudio for mp3 decoding and I have just gotten it working. So now > I am faced with a questions. > > Do I setup winemp3.acm with #ifdefs to pick b

Re: usp10: Bug 17324 change default glyph returned from 0xffff to 0

2010-03-12 Thread Jeff Latimer
On 12/03/10 00:37, Hans Leidekker wrote: It doesn't apply cleanly: Sorry, there are a couple patches ahead of this in my tree. Will re-baseline before resubmitting. And it has compile warnings: I will have a look. They disd not appear in my compile. It would be better to add this te

Re: Test for ATI2n on real Windows machines

2010-03-12 Thread Stefan Dösinger
Am 11.03.2010 um 21:51 schrieb REalm: > +expected_pitch = (128 + dxt_formats[i].block_height - 1) / > dxt_formats[i].block_width > + * dxt_formats[i].block_size; > +//ok(locked_rect.Pitch == expected_pitch, "Got pitch %d, expected > pitch %d for format %s\