Re: kernel32: Add tests for lstrcmpW (try 2)

2010-04-14 Thread Dmitry Timoshkov
André Hentschel wrote: > - Design similar to ntdll/tests/error.c > - Passes all Machines on WTB > - with check for existance of function > - just the known 2 instead of 4510 > - intendation for todo_wine choosen so that it can be easy removed without > touching the tests You need to test Compar

Re: winex11: add support for 32-bit DDBs

2010-04-14 Thread Erich Hoover
I noticed a problem with the icons in Wine when alt+tabbing today. After doing a regression test it appears that commit c29cf0591976f96c3adb30c3c3b6db59f4983251 results in pixmaps that do not always display properly when alt+tabbing (see attached screenshot). Erich Hoover ehoo...@mines.edu <>

Re: oleaut32: be more explicit with locale dependent parsing of dates (try 2)

2010-04-14 Thread André Hentschel
Nikolay Sivov schrieb: > On 4/14/2010 22:51, André Hentschel wrote: >> case 0x3: /* TTT TTTDD TTTDDD */ >> - if (iDate&& dp.dwCount == 3) >> + if (dp.dwCount == 3&& !strncmp(ShortDate,"dd.MM.yy",8)) >> >> > >> case 0x1B: /* localized DDDTTT */ >> - if (!iDate) >> +

Re: [PATCH 2/2] mmdevapi: Add pulseaudio on ignore for older openal-soft's

2010-04-14 Thread Michael Stefaniuc
On 04/14/2010 09:24 PM, Maarten Lankhorst wrote: --- I cannot query the version string unless a device context is created. Since OpenAL-1.12 added support for thread local contexts I use that to determine whether pulseaudio should be ignored or not. OpenAL 1.10 and older will crash on pulseaudio.

Re: oleaut32: be more explicit with locale dependent parsing of dates (try 2)

2010-04-14 Thread Nikolay Sivov
On 4/14/2010 22:51, André Hentschel wrote: case 0x3: /* TTT TTTDD TTTDDD */ - if (iDate&& dp.dwCount == 3) + if (dp.dwCount == 3&& !strncmp(ShortDate,"dd.MM.yy",8)) case 0x1B: /* localized DDDTTT */ - if (!iDate) + if (strncmp(ShortDate,"dd.MM.yy",8))

Re: usbhub.sys: add stubbed usbhub.sys

2010-04-14 Thread Damjan Jovanovic
On Wed, Apr 14, 2010 at 8:35 PM, frechdachs69 wrote: > Am Mittwoch, 24. März 2010 19:49:46 schrieb Damjan Jovanovic: >> On Wed, Mar 24, 2010 at 8:30 PM, Alexandre Julliard > wrote: >> > Damjan Jovanovic writes: >> >> Changelog: >> >> * usbhub.sys: add stubbed usbhub.sys >> > >> > What is this go

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Jason Green
On Apr 14, 2010, at 1:48 PM, Matijn Woudt wrote: >> I think you want to test if the compiled shader works instead of the >> exact bytecode. Generating the same bytecode is probably way too hard, >> fragile to test, and most likely not worth the effort. > > I think I should go for exact bytecode a

Re: usbhub.sys: add stubbed usbhub.sys

2010-04-14 Thread frechdachs69
Am Mittwoch, 24. März 2010 19:49:46 schrieb Damjan Jovanovic: > On Wed, Mar 24, 2010 at 8:30 PM, Alexandre Julliard wrote: > > Damjan Jovanovic writes: > >> Changelog: > >> * usbhub.sys: add stubbed usbhub.sys > > > > What is this going to be useful for? > > > > -- > > Alexandre Julliard > > jul

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Stefan Dösinger
Am 14.04.2010 um 19:29 schrieb Henri Verbeet: > I think you want to test if the compiled shader works instead of the > exact bytecode. Generating the same bytecode is probably way too hard, > fragile to test, and most likely not worth the effort. Yep, comparing generated bytecode is not going to w

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Matijn Woudt
On Wed, Apr 14, 2010 at 7:30 PM, Roderick Colenbrander wrote: > On Wed, Apr 14, 2010 at 7:22 PM, Matijn Woudt wrote: >> On Wed, Apr 14, 2010 at 6:47 PM, Matteo Bruni >> wrote: dlls/wineshader doesn't exist in that tree? >>> >>> Check if you are in the correct branch (should be the "co

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Matijn Woudt
On Wed, Apr 14, 2010 at 7:29 PM, Henri Verbeet wrote: > On 14 April 2010 17:19, Matijn Woudt wrote: >> I have thought about using LLVM, but I don't like it because of: >> 1) Having another wine dependency (~40MB for me on ubuntu) >> 2) Code generated by LLVM will most likely not generated exactly

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Roderick Colenbrander
On Wed, Apr 14, 2010 at 7:22 PM, Matijn Woudt wrote: > On Wed, Apr 14, 2010 at 6:47 PM, Matteo Bruni > wrote: >>> dlls/wineshader doesn't exist in that tree? >>> >> >> Check if you are in the correct branch (should be the "compiler" >> branch in his tree). >> > > Right, my mistake. > Lastly

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Henri Verbeet
On 14 April 2010 17:19, Matijn Woudt wrote: > I have thought about using LLVM, but I don't like it because of: > 1) Having another wine dependency (~40MB for me on ubuntu) > 2) Code generated by LLVM will most likely not generated exactly the > same bytecode as native compiler does, even though th

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Matijn Woudt
On Wed, Apr 14, 2010 at 6:47 PM, Matteo Bruni wrote: >> dlls/wineshader doesn't exist in that tree? >> > > Check if you are in the correct branch (should be the "compiler" > branch in his tree). > Right, my mistake. >>> Lastly, a bit on testing the compiler. I'm not sure trying to get >>> exactl

Re: Future implementation

2010-04-14 Thread Morten Rønne
Luis Busquets wrote: Could someone please confirm the following points?: 2. Integration of DosBOX or other emulator. How this will be done? Is the plan to use them when wine detects that the programme is compiled for real mode? Does that mean that the sake of wine is to provide compatibility

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Charles Davis
On 4/14/10 10:36 AM, Reece Dunn wrote: > On 14 April 2010 16:19, Matijn Woudt wrote: >> I have thought about using LLVM, but I don't like it because of: >> 1) Having another wine dependency (~40MB for me on ubuntu) >> 2) Code generated by LLVM will most likely not generated exactly the >> same byt

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Matteo Bruni
> dlls/wineshader doesn't exist in that tree? > Check if you are in the correct branch (should be the "compiler" branch in his tree). >> Lastly, a bit on testing the compiler. I'm not sure trying to get >> exactly the same bytecode as native is a feasible objective: while for >> an assembler prog

Re: configure: when compiling with CLANG, set -std=gnu89

2010-04-14 Thread Austin English
On Wed, Apr 14, 2010 at 10:19 AM, Alexandre Julliard wrote: > Austin English writes: > >> Clang defaults to compiling in C99 mode, which breaks the compile. > > Of course the compile should be fixed instead. Not entirely trivial, since the compile is broken for gcc in c99 mode as well: http://bu

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Reece Dunn
On 14 April 2010 16:19, Matijn Woudt wrote: > I have thought about using LLVM, but I don't like it because of: > 1) Having another wine dependency (~40MB for me on ubuntu) > 2) Code generated by LLVM will most likely not generated exactly the > same bytecode as native compiler does, even though th

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Matijn Woudt
On Wed, Apr 14, 2010 at 5:59 PM, Matteo Bruni wrote: > 2010/4/14 Matijn Woudt : >> On Wed, Apr 14, 2010 at 4:27 PM, Stefan Dösinger >> wrote: >>> >>> Am 14.04.2010 um 15:44 schrieb Henri Verbeet: >>> On 14 April 2010 15:07, Stefan Dösinger wrote: >> 3) Implement the compiler in d3dcomp

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Matteo Bruni
2010/4/14 Matijn Woudt : > On Wed, Apr 14, 2010 at 4:27 PM, Stefan Dösinger > wrote: >> >> Am 14.04.2010 um 15:44 schrieb Henri Verbeet: >> >>> On 14 April 2010 15:07, Stefan Dösinger wrote: > 3) Implement the compiler in d3dcompiler_xx. I wrote a basic HLSL compiler as university proje

Re: [PATCH] urlmon/tests: CoInternetCreateSecurityManager not present on W95B

2010-04-14 Thread Jacek Caban
On 4/13/10 11:49 PM, Detlef Riekenberg wrote: --- dlls/urlmon/tests/sec_mgr.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/dlls/urlmon/tests/sec_mgr.c b/dlls/urlmon/tests/sec_mgr.c index e758115..8e39301 100644 --- a/dlls/urlmon/tests/sec_mgr.c +++

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Roderick Colenbrander
On Wed, Apr 14, 2010 at 5:19 PM, Matijn Woudt wrote: > On Wed, Apr 14, 2010 at 4:51 PM, Roderick Colenbrander > wrote: >> On Wed, Apr 14, 2010 at 4:38 PM, Matijn Woudt wrote: >>> On Wed, Apr 14, 2010 at 4:27 PM, Stefan Dösinger >>> wrote: Am 14.04.2010 um 15:44 schrieb Henri Verbeet:

Re: configure: when compiling with CLANG, set -std=gnu89

2010-04-14 Thread Alexandre Julliard
Austin English writes: > Clang defaults to compiling in C99 mode, which breaks the compile. Of course the compile should be fixed instead. -- Alexandre Julliard julli...@winehq.org

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Matijn Woudt
On Wed, Apr 14, 2010 at 4:51 PM, Roderick Colenbrander wrote: > On Wed, Apr 14, 2010 at 4:38 PM, Matijn Woudt wrote: >> On Wed, Apr 14, 2010 at 4:27 PM, Stefan Dösinger >> wrote: >>> >>> Am 14.04.2010 um 15:44 schrieb Henri Verbeet: >>> On 14 April 2010 15:07, Stefan Dösinger wrote: >

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Roderick Colenbrander
On Wed, Apr 14, 2010 at 4:38 PM, Matijn Woudt wrote: > On Wed, Apr 14, 2010 at 4:27 PM, Stefan Dösinger > wrote: >> >> Am 14.04.2010 um 15:44 schrieb Henri Verbeet: >> >>> On 14 April 2010 15:07, Stefan Dösinger wrote: > 3) Implement the compiler in d3dcompiler_xx. I wrote a basic HLSL

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Matijn Woudt
On Wed, Apr 14, 2010 at 4:27 PM, Stefan Dösinger wrote: > > Am 14.04.2010 um 15:44 schrieb Henri Verbeet: > >> On 14 April 2010 15:07, Stefan Dösinger wrote: 3) Implement the compiler in d3dcompiler_xx. >>> I wrote a basic HLSL compiler as university project in 2008, this is where >>> part

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Stefan Dösinger
Am 14.04.2010 um 15:44 schrieb Henri Verbeet: > On 14 April 2010 15:07, Stefan Dösinger wrote: >>> 3) Implement the compiler in d3dcompiler_xx. >> I wrote a basic HLSL compiler as university project in 2008, this is where >> part of the assembler code came from. Do you have the sources, do you

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Henri Verbeet
On 14 April 2010 15:07, Stefan Dösinger wrote: >> 3) Implement the compiler in d3dcompiler_xx. > I wrote a basic HLSL compiler as university project in 2008, this is where > part of the assembler code came from. Do you have the sources, do you need > them? > Quite frankly, I also believe that's

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Matijn Woudt
On Wed, Apr 14, 2010 at 3:07 PM, Stefan Dösinger wrote: > > Am 14.04.2010 um 13:08 schrieb Matijn Woudt: >> 2) Move the assembler to d3dcompiler_xx.dll and forward calls from >> d3dx9. This is needed because the assembler and compiler can share the >> same bytecode writer this way. > When Mattheo

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Stefan Dösinger
Am 14.04.2010 um 13:08 schrieb Matijn Woudt: > 2) Move the assembler to d3dcompiler_xx.dll and forward calls from > d3dx9. This is needed because the assembler and compiler can share the > same bytecode writer this way. When Mattheo implemented the assembler in the gsoc project we decided to put

Re: [PATCH 09/16] Replaced mycomputer.ico with a Tango compliant icon

2010-04-14 Thread Sven Baars
Joel Holdsworth wrote: > Hi Joel, > > I think this has been mentioned before, but the monitor icons (32-bit > and 8-bit for size 32) show a wider lower half of the monitor compared > to the upper half (I think the 32-bit size 22 as well). > I've heard feedback about the screen colour befor

Re: [PATCH 09/16] Replaced mycomputer.ico with a Tango compliant icon

2010-04-14 Thread Paul Vriens
On 04/14/2010 02:04 PM, Joel Holdsworth wrote: > Hi Joel, > > I think this has been mentioned before, but the monitor icons (32-bit > and 8-bit for size 32) show a wider lower half of the monitor compared > to the upper half (I think the 32-bit size 22 as well). > I've heard feedback ab

Re: [PATCH 09/16] Replaced mycomputer.ico with a Tango compliant icon

2010-04-14 Thread Joel Holdsworth
> Hi Joel, > > I think this has been mentioned before, but the monitor icons (32-bit > and 8-bit for size 32) show a wider lower half of the monitor compared > to the upper half (I think the 32-bit size 22 as well). >   I've heard feedback about the screen colour before, which I've resolved. Nev

Re: [PATCH 09/16] Replaced mycomputer.ico with a Tango compliant icon

2010-04-14 Thread Paul Vriens
On 04/14/2010 01:41 PM, Paul Vriens wrote: On 04/13/2010 10:59 PM, Joel Holdsworth wrote: Signed-off-by: Joel Holdsworth --- dlls/shell32/mycomputer.ico | Bin 15086 -> 25214 bytes dlls/shell32/mycomputer.svg | 2400 ++- 2 files changed, 1477 insertions(+),

Re: [PATCH 09/16] Replaced mycomputer.ico with a Tango compliant icon

2010-04-14 Thread Paul Vriens
On 04/13/2010 10:59 PM, Joel Holdsworth wrote: Signed-off-by: Joel Holdsworth --- dlls/shell32/mycomputer.ico | Bin 15086 -> 25214 bytes dlls/shell32/mycomputer.svg | 2400 ++- 2 files changed, 1477 insertions(+), 923 deletions(-) Hi Joel, I

Re: HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Henri Verbeet
On 14 April 2010 13:08, Matijn Woudt wrote: > Hi, > > I'm about to implement the HLSL compiler, but I want to make sure I'm > taking the right direction. > For the compiler: > preprocessor(wpp)->hlslparser/compiler(lex/bison)->bytecode > writer(same as for the shader assembler). > Now the question

HLSL Compiler and d3dcompiler_xx.dll

2010-04-14 Thread Matijn Woudt
Hi, I'm about to implement the HLSL compiler, but I want to make sure I'm taking the right direction. For the compiler: preprocessor(wpp)->hlslparser/compiler(lex/bison)->bytecode writer(same as for the shader assembler). Now the question is where to implement the compiler. It can be called from a

Re: [PATCH 5/5] winex11.drv: Allow OpenGL on minimized windows.

2010-04-14 Thread Henri Verbeet
On 14 April 2010 11:08, Florian Köberle wrote: > You have worked on quite a few bugs I have voted for. Would be buying > Crossover Games (again) the correct way to support your work? > In principle, yes. Though in all fairness it should also be noted that Wine is the work of many people, not all o

Re: [PATCH 3/5] wined3d: Disable strict draw ordering by default.

2010-04-14 Thread Henri Verbeet
On 14 April 2010 11:52, Stefan Dösinger wrote: > Am 13.04.2010 um 23:51 schrieb Henri Verbeet: >> I'm not sure I see how that's going to make things better. > Well, mostly to have the sync conditions and the way we sync in a single > place. That'll make it easier to use more suited GL methods to

Re: [PATCH 3/5] wined3d: Disable strict draw ordering by default.

2010-04-14 Thread Stefan Dösinger
Am 13.04.2010 um 23:51 schrieb Henri Verbeet: > On 13 April 2010 23:13, Stefan Dösinger wrote: >> Am 13.04.2010 um 20:46 schrieb Henri Verbeet: >>> +if (wined3d_settings.strict_draw_ordering) wglFlush(); /* Flush to >>> ensure ordering across contexts. */ >> I'd prefer to have this in an (i

Re: [PATCH 5/5] winex11.drv: Allow OpenGL on minimized windows.

2010-04-14 Thread Florian Köberle
Hello Henri, your patch fixes bug 12611: http://bugs.winehq.org/show_bug.cgi?id=12611 Thanks for your great work! You have worked on quite a few bugs I have voted for. Would be buying Crossover Games (again) the correct way to support your work? Best regards, Florian

Re: Future implementation

2010-04-14 Thread Michael Stefaniuc
Damjan Jovanovic wrote: > On Wed, Apr 14, 2010 at 6:35 AM, Luis Busquets > wrote: >> Could someone please confirm the following points?: >> > >> 2. Integration of DosBOX or other emulator. How this will be done? Is the >> plan to use them when wine detects that the programme is compiled for real

Re: Future implementation

2010-04-14 Thread Damjan Jovanovic
On Wed, Apr 14, 2010 at 6:35 AM, Luis Busquets wrote: > Could someone please confirm the following points?: > > 2. Integration of DosBOX or other emulator. How this will be done? Is the > plan to use them when wine detects that the programme is compiled for real > mode? Does that mean that the sa

Re: Future implementation

2010-04-14 Thread Austin English
On Wed, Apr 14, 2010 at 1:52 AM, John Klehm wrote: > On Wed, Apr 14, 2010 at 1:46 AM, Tom Wickline wrote: >> >> Wine also runs on BSD and OpenSolaris, so if OSS was removed it would kill >> sound support on these platforms. >> > > Doesn't openal support bsd and solaris too? > http://connect.creat