Re: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile [try 3]

2010-04-24 Thread Nikolay Sivov
On 4/24/2010 12:53, Ilya Basin wrote: 1) removes the block of code that splits lpFile into filename and parameters and removes ''s from filename . Even without this block ShellExecute not fails with quoted lpFile. 2) removes 2 corresponding todo_wine's from tests. The real application affected

Re: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile [try 3]

2010-04-24 Thread Paul Vriens
On 04/24/2010 10:53 AM, Ilya Basin wrote: 1) removes the block of code that splits lpFile into filename and parameters and removes ''s from filename . Even without this block ShellExecute not fails with quoted lpFile. 2) removes 2 corresponding todo_wine's from tests. The real application

Re[2]: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile [try 3]

2010-04-24 Thread Ilya Basin
PV Hi Ilya, PV In your last email on wine-devel about this subject you mentioned adding PV some extra tests. There was at least some communication with you and the PV author of that piece you are now removing. The reason for that piece was PV shown in a code-snippet he gave and adding tests

Re: Minor dlls/dbghelp/dwarf.c simplification

2010-04-24 Thread Eric Pouech
Gerald Pfeifer a écrit : ChangeLog: Remove two variables which are not really used in dwarf2_parse_line_numbers. diff --git a/dlls/dbghelp/dwarf.c b/dlls/dbghelp/dwarf.c index 4be0f6a..69d7357 100644 --- a/dlls/dbghelp/dwarf.c +++ b/dlls/dbghelp/dwarf.c @@ -1920,7 +1920,7 @@ static BOOL

Re: Minor dlls/localspl/tests/localmon.c simplificiation

2010-04-24 Thread Nikolay Sivov
On 4/23/2010 16:50, Gerald Pfeifer wrote: In addition to just building this patch as is, I also gave it a spin changing the if (0) to if (1) to ensure this still builds (it should, of course, and it does, but...) Gerald ChangeLog: Remove variable res which is not really used from

Re: [1/2] gdiplus: Add test for GdipCreateBitmapFromGdiDib.

2010-04-24 Thread Greg Geldorp
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1718 Your paranoid

Re: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile [try 3]

2010-04-24 Thread Greg Geldorp
From: Ilya Basin basini...@gmail.com Then postponing till my next slack period, the more so I got another e-mail: === W7PROX64 (32 bit shlexec) === No test failures found === W7PROX64 (64 bit shlexec) === shell32: shlexec.c:1609: Test failed: ShellExecuteEx(null,

Re: Tasklist/Tasklets (Was: Re: Remove NoAppDBEntry keyword?)

2010-04-24 Thread Vitaliy Margolen
On 04/19/2010 02:57 PM, Michael Stefaniuc wrote: On 04/10/2010 03:01 AM, Austin English wrote: I've removed the keywords bugbuster, noappdbentry, tasklet, and tasklist from all bugs. Could someone with the appropriate bugzilla permissions please delete the keywords themselves? The Tasklets

Top wine-using country: Russia?

2010-04-24 Thread Dan Kegel
It might be interesting to know which countries use Wine the most. I have no idea how to measure that, but the top three countries in http://www.google.com/trends?q=winetricks,+playonlinux are Russia, Czech, and Ukraine!

Re: Top wine-using country: Russia?

2010-04-24 Thread Gert van den Berg
On Sat, Apr 24, 2010 at 22:50, Dan Kegel d...@kegel.com wrote: It might be interesting to know which countries use Wine the most. I have no idea how to measure that, but the top three countries in http://www.google.com/trends?q=winetricks,+playonlinux are Russia, Czech, and Ukraine! Some

Re: Top wine-using country: Russia?

2010-04-24 Thread Remco
On Sat, Apr 24, 2010 at 23:35, Gert van den Berg wine-de...@mohag.net wrote: On Sat, Apr 24, 2010 at 22:50, Dan Kegel d...@kegel.com wrote: It might be interesting to know which countries use Wine the most. I have no idea how to measure that, but the top three countries in

Re: shell32: Fix tests to apply to Vista+

2010-04-24 Thread Nikolay Sivov
On 4/23/2010 20:46, Paul Vriens wrote: On 04/23/2010 06:30 PM, André Hentschel wrote: Juan Lang schrieb: My point of view is that its not an error on windows, with this patch it passes in windows and gets a todo_wine, which it actually is (like you say). Any test that allows all

new winetricks 20100424: new verbs directmusic, dsoundbug9612, mono26, strictdrawordering, quartz, videomemorysize

2010-04-24 Thread Dan Kegel
Another month, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes: Austin English: - add a strictdrawordering enabled/disabled option, use it for Dragon Age in wisotool

new wisotool 20100424: new verbs 3dmark2000, 3dmark2001, 3dmark03, 3dmark05, 3dmark06, baldursgate2, gta_vc, pcmark04, pcmark05, unigine_heaven

2010-04-24 Thread Dan Kegel
wisotool is a handy winetricks-like script for automatically installing games from .iso files copied from your own dvds (or, if the game is freely downloadable, it will download it). Just like winetricks, it is intended to make testing Wine easier, but might be useful for people who simply want