Re: [PATCH 4/5] d3d9/tests: Allow D3DFMT_A2R10G10B10 as supported adapter mode.

2010-05-03 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1890 Your paranoid android.

Re: [1/2] dlls/crypt32: implement PFXImportCertStore()

2010-05-03 Thread Philippe Casgrain
[Finally have a little bit of downtime, can turn my attention back to this...] On 2010-03-25, at 2:34 PM, Juan Lang wrote: >> I don't have any password-protected certificates to test with, so I can't >> add such a test (it was not required for our implementation). > > You can if you create one

Re: Why reserve space below 2G without preloader? wrt. patch 1aa749d & bug 22033

2010-05-03 Thread Alexandre Julliard
"Johann \"Myrkraverk\" Oskarsson" writes: > Hi all, > > Out of sheer curiousity, why is it important to reserve space below 2G > when there is no preloader? > > Patch 1aa749d, is > > libwine: Reserve some low memory space even without a preloader. > > has the comment: > > /* if we don't have

Re: Why reserve space below 2G without preloader? wrt. patch 1aa749d & bug 22033

2010-05-03 Thread Edward Savage
On Tue, May 4, 2010 at 3:10 AM, Johann "Myrkraverk" Oskarsson wrote: > > Out of sheer curiousity, why is it important to reserve space below 2G > when there is no preloader? > Have to keep the Llamas some where...

Why reserve space below 2G without preloader? wrt. patch 1aa749d & bug 22033

2010-05-03 Thread Johann "Myrkraverk" Oskarsson
Hi all, Out of sheer curiousity, why is it important to reserve space below 2G when there is no preloader? Patch 1aa749d, is libwine: Reserve some low memory space even without a preloader. has the comment: /* if we don't have a preloader, try to reserve some space below 2Gb */ and is the

Re: [2/5] rundll32: Fail if a rundll32 window cannot be created.

2010-05-03 Thread Alexandre Julliard
Andrew Nguyen writes: > --- > programs/rundll32/rundll32.c | 16 +--- > 1 files changed, 13 insertions(+), 3 deletions(-) This will prevent initializing the prefix without an X display. Why do you need this? -- Alexandre Julliard julli...@winehq.org

Re: Valgrind's wine_cp_wcstombs warnings

2010-05-03 Thread Dan Kegel
Hi Joerg, did you try the --track-origins option? That can sometimes give more detail (see e.g. the traces in this old message): On Thu, Jul 31, 2008 at 10:14 AM, Dan Kegel wrote: > Hi Colin, > your change > http://source.winehq.org/git/wine.git/?a=commitdiff;h=c2c1a55f1c08f35ae02b811d1141acd6ec

Valgrind's wine_cp_wcstombs warnings

2010-05-03 Thread Joerg-Cyril.Hoehle
Hi, running the MCI tests with Valgrind generates a lot of output like follows ==13170== Use of uninitialised value of size 4 ==13170==at 0x4035369: wine_cp_wcstombs (wctomb.c:147) ...[every line from 148 to 161] ==13170== Use of uninitialised value of size 4 ==13170==at 0x403550A: wine_c

Re: ddraw: Fix missing D3D misc caps

2010-05-03 Thread Stefan Dösinger
Am 02.05.2010 um 22:07 schrieb Ričardas Barkauskas: > Fixes missing D3D misc caps needed by Independence War 2: Edge Of Chaos (bug > 7012) The patch seems ok

Re: [ddraw] Fix discrepancy in alpha mask for WINED3DFMT_B2G3R3A8_UNORM.

2010-05-03 Thread Stefan Dösinger
Am 02.05.2010 um 08:26 schrieb Vincent Pelletier: > > PixelFormat_DD2WineD3D returns WINED3DFMT_B2G3R3A8_UNORM when alpha mask > is 0xFF00, which is consistent with constant name (A8). The patch looks ok to me.

Re: mshtml/tests: Fix return value of ActiveScript_SetScriptState.

2010-05-03 Thread Jacek Caban
Hi Gerald, On 5/2/10 9:16 PM, Gerald Pfeifer wrote: IActiveScriptSite_OnStateChange is described to return S_OK upon success, so instead of ignoring its return value and unconditionally returning S_OK it strikes me that we should return its result instead. In this case returning S_OK is fi

Re: [Wine] Potential bug in RtlRegisterWait()

2010-05-03 Thread Joakim Tjernlund
Charles Davis wrote on 2010/05/03 01:18:25: > > On 5/2/10 3:02 PM, Joakim Tjernlund wrote: > > > > Noticed that RtlRegisterWait() will approve a zero timeout > > value(Milliseconds == 0) > > > > This makes ies4linux spin the CPU 100% when visiting a > > https page. The below crude patch fixes it:

Re: gdi32/tests: Remove two variables which are not really used from test_clipping.

2010-05-03 Thread Gerald Pfeifer
On Mon, 3 May 2010, Nikolay Sivov wrote: > Bitmap are useless after this change. Darn, I may have sent the wrong version of the patch. Let me look into this tonight or tomorrow. You have sharp eyes, Nikolay! :-) Gerald

Re: gdi32/tests: Remove two variables which are not really used from test_clipping.

2010-05-03 Thread Nikolay Sivov
On 5/3/2010 03:48, Gerald Pfeifer wrote: --- dlls/gdi32/tests/bitmap.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/dlls/gdi32/tests/bitmap.c b/dlls/gdi32/tests/bitmap.c index 882d548..b570a8a 100644 --- a/dlls/gdi32/tests/bitmap.c +++ b/dlls/gdi32/tests/bitmap.c

Re: [PATCH] Fix Unicode escape string occurring when calling GetClipboardData(CF_TEXT).

2010-05-03 Thread Dmitry Timoshkov
Sin-ta Hsiea wrote: > Here's a patch that fetch UTF8 string, and convert to local codepage. > +count = WideCharToMultiByte(CP_OEMCP, 0, lpwstr, -1, NULL, 0, > NULL, NULL); > +hText = GlobalAlloc(GMEM_MOVEABLE | GMEM_DDESHARE, count); > + > +if (hText) > +