Re: gdi32: use usp10 to optionally generate glyphs for bidi strings

2010-05-13 Thread Dmitry Timoshkov
Aric Stewart wrote: > allows us to be able to make use of the mirroring code and eventually > the shaping code when it is in place. This should be done the other way around. gdi32 should not depend on a high level dll (that creates circular dependencies), gdi32 in Windows doesn't use usp10 eith

Re: [1/3] user32: Convert data in WM_DDE_EXECUTE to unicode when expected.

2010-05-13 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2058 Your paranoid android.

Re: [3/3] user32: Convert data in WM_DDE_EXECUTE to ansi when expected.

2010-05-13 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2059 Your paranoid android.

Re: comctl32/tests: Remove variable res which is not really used from test_monthcal_size.

2010-05-13 Thread Gerald Pfeifer
On Thu, 6 May 2010, Nikolay Sivov wrote: >> -res = SendMessage(hwnd, MCM_GETMINREQRECT, 0, (LPARAM)&r1); >> +SendMessage(hwnd, MCM_GETMINREQRECT, 0, (LPARAM)&r1); > Actually it won't hurt to test for it here. Okay. I am currently testing a patch that does exactly that in both cases. Than

Re: advpack: Only do_ocx_reg (and thus DllRegisterServer) from RegisterOCX when 'N' is passed as a flag. Clarify documentation.

2010-05-13 Thread Gerald Pfeifer
On Tue, 11 May 2010, James Hawkins wrote: > I'm very hesitant about this. MSDN has no documentation about > RegisterOCX, so I'm not sure how you're justifying this change. It's > been a long time since I worked on this, so I don't remember much, but > I do remember testing this method and documen

Re: [Fwd: Re: winemp3.acm: Fixes the Mac-specific code]

2010-05-13 Thread Kristofer Henriksson
I think the reason why your change works is that it seems the AudioConverter doesn't care if it has invalid data at the beginning of its stream. There will be however a little creeping error in computation of frame lengths over time, which is that there may or may not be one extra byte of padding o

Re: Release plans

2010-05-13 Thread Francois Gouget
On Wed, 12 May 2010, Alexandre Julliard wrote: > Scott Ritchie writes: > > > On 05/09/2010 05:00 PM, Alexandre Julliard wrote: > >> We definitely need a release changelog, yes. > > > > It seems to me what we really want is more than a changelog but a proper > > release announcement. I want a jo

Re: More benchmarks of 3d performance comparing windows and linux

2010-05-13 Thread Rico Schüller
Am 13.05.2010 14:52, schrieb Dan Kegel: 2010/5/13 Rico Schüller: I just tried 'winetricks glsl-disable' on heaven2_d3d9. It sped it up about 8% (to 16.0 fps), but added some fun problems (e.g. scenes 7, 10, and 12 have a black sky). Sceenes 7, 10 and 12 are totally black here on wi

Re: [PATCH 5/5] server: get rid of sock_try_event

2010-05-13 Thread Mike Kaplinskiy
On Thu, May 13, 2010 at 6:28 AM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> We *might* need to ignore POLLERR messages for UDP sockets, as the >> condition is actually temporary and sock_try_event was hiding this. > > It doesn't work here: > > ../../../tools/runtest -q -P wine -M ws

Re: [Fwd: Re: winemp3.acm: Fixes the Mac-specific code]

2010-05-13 Thread Aric Stewart
There is a bug in the code i just posted, It should clearly be adsi->pwfxSrc->nSamplesPerSec not Dst. Still works great, probibly because my tests had the same nSamplesPerSec for both Src and Dst. -aric Aric Stewart wrote: Hi, I will admit that my understanding of both ACM drivers as we

Re: [Fwd: Re: winemp3.acm: Fixes the Mac-specific code]

2010-05-13 Thread Aric Stewart
Hi, I will admit that my understanding of both ACM drivers as well as the os x audio libraries are not perfect and mostly come from work on this code itself. So i will fully admit it is most likely full of areas needing improvement. Kristofer Henriksson wrote: Aric, I may have been opera

Re: urlmon: CreateUri should return E_INVALIDARG for NULL args.

2010-05-13 Thread Thomas Mullaly
On Thu, May 13, 2010 at 3:41 AM, Paul Vriens wrote: > > I don't think these comments are needed as the same is shown in the tests > below (I was actually triggered by the wrong spelling of 'receives' btw). > Whoops. I always manage to misspell receive somehow... I'll submit a new patch here short

Re: More benchmarks of 3d performance comparing windows and linux

2010-05-13 Thread Dan Kegel
2010/5/13 Rico Schüller : >> I just tried 'winetricks glsl-disable' on heaven2_d3d9.  It sped it up >> about 8% (to 16.0 fps), but added some fun problems (e.g. scenes >> 7, 10, and 12 have a black sky). > > Sceenes 7, 10 and 12 are totally black here on wine on opengl. But the linux > native clien

Re: winemp3.acm: Fixes the Mac-specific code

2010-05-13 Thread Aric Stewart
Hi, It is good to see someone working on this code. But your patch makes it so that all the mp3 sound clips in the game that I was coding for stop working. trace:mpeg3:mp3_leopard_horse ndst 147456 0x2eab348 <- 19901 0x2ea657c trace:mpeg3:mp3_leopard_horse First 16 bytes to input: "\x00\

Re: More benchmarks of 3d performance comparing windows and linux

2010-05-13 Thread Rico Schüller
Am 10.05.2010 02:46, schrieb Dan Kegel: On Sun, May 9, 2010 at 4:14 PM, Dan Kegel wrote: in general, Wine's D3D version achieves only half to three-quarters the performance of Vista's. I just tried 'winetricks glsl-disable' on heaven2_d3d9. It sped it up about 8% (to 16.0 fps), but

Re: [PATCH 5/5] server: get rid of sock_try_event

2010-05-13 Thread Alexandre Julliard
Mike Kaplinskiy writes: > We *might* need to ignore POLLERR messages for UDP sockets, as the > condition is actually temporary and sock_try_event was hiding this. It doesn't work here: ../../../tools/runtest -q -P wine -M ws2_32.dll -T ../../.. -p ws2_32_test.exe.so sock.c && touch sock.ok soc

Re: [PATCH 0/2] Unaligned mmap() on Mac OS X

2010-05-13 Thread Alexandre Julliard
Charles Davis writes: > On 5/12/10 5:37 PM, Ken Thomases wrote: >> What problems does this cause? > It makes Wine use more memory than it needs to. In theory, but in practice it's not worth the trouble. We used to do this on Linux but it has been removed. It's definitely not worth breaking libwi

Re: urlmon: CreateUri should return E_INVALIDARG for NULL args.

2010-05-13 Thread Paul Vriens
On 05/13/2010 04:49 AM, Thomas Mullaly wrote: @@ -75,6 +77,22 @@ static void test_CreateUri_InvalidFlags(void) { } } +/* + * CreateUri returns E_INVALIDARG if the IUri it recieves is NULL. + * CreateUri returns E_INVALIDARG if the uri string is NULL and sets the IUri to NULL. + */ I d

Re: [kernel32] Return the correct processor arch and type in wow64 mode

2010-05-13 Thread Paul Vriens
On 05/13/2010 01:54 AM, (Marvin) wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/Job