Re: [PATCH] atl: Do not fail on Wine64

2010-06-13 Thread Maarten Lankhorst
Hi Marcus, 2010/6/13 Marcus Meissner : > Hi, > > The size is 248 on Wine64 ... (expected 240), so we miss > perhaps a pointer or some alignment. > > Its not fully clear what. > > It at least does not crash when ignoring the size change. Seems wrong to me, does it allow size 240 on 64-bits, or does

Re: [PATCH 4/6] shdocvw: Silence QueryService traces in non-interactive runs.

2010-06-13 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2620 Your paranoid android.

Re: msxml3: Avoid SysStringLen() testing for an empty string in ::createNode()

2010-06-13 Thread Reece Dunn
On 13 June 2010 20:46, Nikolay Sivov wrote: > On 6/13/2010 22:55,  (Marvin) wrote: >> >> Hi, >> >> While running your changed tests on Windows, I think I found new failures. >> Being a bot and all I'm not very good at pattern recognition, so I might >> be >> wrong, but could you please double-chec

Re: Inviting users to look for regressions in wine-1.2rc3?

2010-06-13 Thread Dan Kegel
Nikolay Sivov wrote: > ... it would > be nice to have valgrind tests logs as you did some months ago. > I think it's possible to catch something new that is easy to fix for 1.2. You're right. I'll try to find them time to fire that up again.

Re: msxml3: Avoid SysStringLen() testing for an empty string in ::createNode()

2010-06-13 Thread Nikolay Sivov
On 6/13/2010 22:55, (Marvin) wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDeta

Re: msxml3: Avoid SysStringLen() testing for an empty string in ::createNode()

2010-06-13 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2617 Your paranoid android.

Re: [1/4] Riched20:Moved-code-to-update-wrap-position-to-ME_WrapTextParagraph

2010-06-13 Thread James McKenzie
Austin English wrote: On Sun, Jun 13, 2010 at 1:02 PM, James McKenzie wrote: This is patch 1/4 to implement EM_FORMATRANGE. This patch does not change any of the code but moves code from ME_WrapMarkedParagraphs to ME_WrapTextParagraph. The bug report #6254, which this is a solution to is m

Re: [1/4] Riched20:Moved-code-to-update-wrap-position-to-ME_WrapTextParagraph

2010-06-13 Thread Austin English
On Sun, Jun 13, 2010 at 1:02 PM, James McKenzie wrote: > This is patch 1/4 to implement EM_FORMATRANGE.  This patch does not change > any of the code but moves code from ME_WrapMarkedParagraphs to > ME_WrapTextParagraph. > > The bug report #6254, which this is a solution to is marked as needed for

Re: msi: Print more information on error

2010-06-13 Thread Alexandre Julliard
André Hentschel writes: > i had that case with > err:msi:ACTION_CallDllFunction GetProcAddress for function > L"findApplications" in dll L"C:\\users\\dawncrow\\Temp\\msi94eb.tmp" failed > so you see that just the function is not info enough. I don't see that. The name of the temp file is not me

Re: Inviting users to look for regressions in wine-1.2rc3?

2010-06-13 Thread Nikolay Sivov
On 6/13/2010 18:53, Dan Kegel wrote: How close are we to release? Not closely related to a beta testing, but for quality it is - it would be nice to have valgrind tests logs as you did some months ago. I think it's possible to catch something new that is easy to fix for 1.2.

Re: Inviting users to look for regressions in wine-1.2rc3?

2010-06-13 Thread Dan Kegel
On Sun, Jun 13, 2010 at 10:00 AM, James McKenzie wrote: >> How close are we to release?  Maybe it'd be worth >> it to publicise the upcoming wine release by >> flogging rc3 in various news sites and getting more people to >> look for regressions. > > +1. OK, I've posted something to linuxtoday an

Updating the 1.2 release announcement text

2010-06-13 Thread Dan Kegel
http://wiki.winehq.org/Wine1.2Announcement could use some work if anyone has time...

Re: Inviting users to look for regressions in wine-1.2rc3?

2010-06-13 Thread James McKenzie
Edward Savage wrote: On Mon, Jun 14, 2010 at 12:53 AM, Dan Kegel wrote: How close are we to release? Maybe it'd be worth it to publicise the upcoming wine release by flogging rc3 in various news sites and getting more people to look for regressions. If it's still a couple of weeks o

Re: Release plans

2010-06-13 Thread James McKenzie
Michael Stefaniuc wrote: On 06/13/2010 10:39 AM, wy...@volny.cz wrote: Hi, another week and Sunday gone so time for simple numbers... 340 regressions<-- release announcement 356 regressions<-- release announcement + 1week 339 regressions<-- release announcement + 2weeks(rc1) 322 regressions<--

Re: Two enhancement requests for winetricks

2010-06-13 Thread James McKenzie
Jan Hoogenraad wrote: Attached a simple script which at least removes those files that were installed by another application (possibly winetricks) and are now provided by wine. On my computer, it removed the following files (of which I am unsure of its origins). 17680 1998-08-06 12:43 psapi

Re: Inviting users to look for regressions in wine-1.2rc3?

2010-06-13 Thread James McKenzie
Dan Kegel wrote: How close are we to release? Maybe it'd be worth it to publicise the upcoming wine release by flogging rc3 in various news sites and getting more people to look for regressions. +1. I'm getting a fresh git and fixing/running and then submitting the EM_FORMATRANGE patches to

Re: Inviting users to look for regressions in wine-1.2rc3?

2010-06-13 Thread Edward Savage
On Mon, Jun 14, 2010 at 12:53 AM, Dan Kegel wrote: > How close are we to release?  Maybe it'd be worth > it to publicise the upcoming wine release by > flogging rc3 in various news sites and getting more people to > look for regressions. > If it's still a couple of weeks off I could write up a re

Inviting users to look for regressions in wine-1.2rc3?

2010-06-13 Thread Dan Kegel
How close are we to release? Maybe it'd be worth it to publicise the upcoming wine release by flogging rc3 in various news sites and getting more people to look for regressions. The thread about Wylda's statistics reminded me about http://wiki.winehq.org/PlatinumRegressionHunt We mentioned that i

re: Anotated 'make test' log

2010-06-13 Thread Dan Kegel
What problem are you trying to solve? I gather you're just plowing through the output of 'make test', looking at each bit of noise, and trying to figure out a way to improve the tests? While that's a noble quest, and I'd like to encourage people to improve the tests, it might be more productive to

Anotated 'make test' log

2010-06-13 Thread Max TenEyck Woodbury
I'm trying to get a start on helping with wine development. I'm still in the process of reading the developer's guide, and I think I am making progress on that. As a test of my understanding, I started to annotate the output of 'make -k test'. I'd like your opinion on the usefulness of this. A

Re: Two enhancement requests for winetricks

2010-06-13 Thread Jan Hoogenraad
Attached a simple script which at least removes those files that were installed by another application (possibly winetricks) and are now provided by wine. On my computer, it removed the following files (of which I am unsure of its origins). 17680 1998-08-06 12:43 psapi.dll 131072 1999-01-15

Re: Release plans

2010-06-13 Thread Michael Stefaniuc
On 06/13/2010 10:39 AM, wy...@volny.cz wrote: Hi, another week and Sunday gone so time for simple numbers... 340 regressions<-- release announcement 356 regressions<-- release announcement + 1week 339 regressions<-- release announcement + 2weeks(rc1) 322 regressions<-- release announcement + 3w

Re: Release plans

2010-06-13 Thread wylda
Hi, another week and Sunday gone so time for simple numbers... 340 regressions <-- release announcement 356 regressions <-- release announcement + 1week 339 regressions <-- release announcement + 2weeks(rc1) 322 regressions <-- release announcement + 3weeks(rc2) 325 regressions <-- release announ