re: dlls/user.exec16/user.c: Use FIXME_ONCE for quieter reports

2010-07-18 Thread Dan Kegel
James wrote: This whole line of thought was rejected, at least once. Yes, but see his later patchset. I think he's now just trying to provide a uniform abstraction for the existing ad-hoc single-shot FIXMEs without adding any new ones, following Henri's advice in

Re: kernel32: add a test for CreateFileA()

2010-07-18 Thread Nikolay Sivov
On 7/18/2010 10:17, Austin English wrote: Passed all the vm's on wtb. Hi, Austin. This looks strange: + +hFile = CreateFileA(c:\\*.*, GENERIC_READ,FILE_SHARE_READ,NULL,OPEN_EXISTING,FILE_ATTRIBUTE_NORMAL,NULL ); +ok(GetLastError() == ERROR_INVALID_NAME || broken(GetLastError() ==

Re: kernel32: Enhance EndUpdateResource

2010-07-18 Thread Andrey Turkin
On Sunday 18 July 2010 00:26:36 Henri Verbeet wrote: On 17 July 2010 09:06, Andrey Turkin andrey.tur...@gmail.com wrote: +if (nt-OptionalHeader.FileAlignment = 0) I can't comment much on the changes themselves, but FileAlignment is unsigned, so can't be 0. Original function has this

Re: [1/2] imagehlp: Add tests for ImageGetDigestStream

2010-07-18 Thread Andrey Turkin
On Sunday 18 July 2010 00:26:50 Henri Verbeet wrote: On 17 July 2010 09:07, Andrey Turkin andrey.tur...@gmail.com wrote: +#ifdef NONAMELESSUNION +# define U(x) (x).u +#else +# define U(x) (x) +#endif I think this is already done in wine/test.h? Right. Some other tests define

Re: [PATCH 1/5 try2] jscript: Fixed sort_cmp for non-string arguments.

2010-07-18 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3449 Your paranoid

Re: [4/5] gameux/tests: Add creating test for IGameExplorer

2010-07-18 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3456 Your paranoid

Re: shell32: Implement Set/GetCurrentViewMode in the default shellview. (try 2)

2010-07-18 Thread David Hedberg
On Sun, Jul 18, 2010 at 3:10 PM, Marvin test...@testbot.winehq.org wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be

Re: shell32: Implement Set/GetCurrentViewMode in the default shellview. (try 2)

2010-07-18 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3459 Your paranoid

Re: [4/5] gameux/tests: Add creating test for IGameExplorer

2010-07-18 Thread Nikolay Sivov
On 7/18/2010 15:59, Mariusz Pluciński wrote: +/* interface available up from Vista */ +hr = CoCreateInstance(CLSID_GameExplorer, NULL, CLSCTX_INPROC_SERVER,IID_IGameExplorer, (LPVOID*)ge); +ok(ge hr == S_OK, IGameExplorer creating failed (result false)\n); +if(ge) +{ +

Re: Anotated 'make test' log

2010-07-18 Thread Max TenEyck Woodbury
On 07/17/2010 10:27 AM, Detlef Riekenberg wrote: Hi Max Welcome to Wine. Your Patch [Add '_ONCE' variants of DPRINTF, FIXME, WARN.] ( http://source.winehq.org/patches/data/63503 ) has a typo near the end: #define ERR_ONCE WINE_ERR_ONCEE Thank you! Fixed and resubmitted.

Re: kernel32: add a test for CreateFileA()

2010-07-18 Thread James McKenzie
Austin English wrote: Passed all the vm's on wtb. +hFile = CreateFileA(c:\\*.*, GENERIC_READ,FILE_SHARE_READ,NULL,OPEN_EXISTING,FILE_ATTRIBUTE_NORMAL,NULL ); +ok(GetLastError() == ERROR_INVALID_NAME ||

Re:

2010-07-18 Thread GOUJON Alexandre
On 07/18/2010 04:17 PM, Tom Wickline wrote: You forgot to attach the patches :) and a subjust is nice as well. Tom On Sun, Jul 18, 2010 at 6:16 PM, Alexandre Goujon ale.gou...@gmail.com mailto:ale.gou...@gmail.com wrote: Here is another big path; should fix bug #18071. These tests

Re: mmio: Ensure FOURCC string conversions are null-terminated.

2010-07-18 Thread Eric Pouech
the explanations for the bug fix look really strange all the printf use %4.4s form, which will limit output to only 4 chars, whatever the string is terminated or not so the crash doesn't come from here looking quickly at the patch, several remark arise - in the second third modification to the

Re:

2010-07-18 Thread Octavian Voicu
On Sun, Jul 18, 2010 at 6:43 PM, GOUJON Alexandre ale.gou...@gmail.com wrote: What I want is to add a comment to some patch before the ... for instance. Any idea how to do that ? Just do `git format-patch' with proper parameters and this will result in a series of files, one for each patch

Re: dlls/user.exec16/user.c: Use FIXME_ONCE for quieter reports

2010-07-18 Thread James McKenzie
Dan Kegel wrote: James wrote: This whole line of thought was rejected, at least once. Yes, but see his later patchset. I think he's now just trying to provide a uniform abstraction for the existing ad-hoc single-shot FIXMEs without adding any new ones, following Henri's advice in

D3DXCreateTeapot and reverse engineering?

2010-07-18 Thread Misha Koshelev
Dear All: I just wanted to double check before I do anything with D3DXCreateTeapot. I have several options for implementing this: Option A One, the slightly harder option, involves the original dataset: http://www.sjbaker.org/teapot/teaset.tgz Option B Another, much simpler

Re: D3DXCreateTeapot and reverse engineering?

2010-07-18 Thread Roderick Colenbrander
On Sun, Jul 18, 2010 at 11:05 AM, Misha Koshelev misha...@gmail.com wrote: Dear All: I just wanted to double check before I do anything with D3DXCreateTeapot. I have several options for implementing this: Option A One, the slightly harder option, involves the original dataset:

Re: D3DXCreateTeapot and reverse engineering?

2010-07-18 Thread David Gerard
On 18 July 2010 21:56, Roderick Colenbrander thunderbir...@gmail.com wrote: Others have mentioned before that the only 'reverse' engineering method we allow is black box reverse engineering. Technically this is black box, but I would say that you can't use the output because of copyright

re: D3DXCreateTeapot and reverse engineering?

2010-07-18 Thread Dan Kegel
IMHO, our criterion is we only need to implement what apps really need, and for the moment, that app probably could live with a stub for D3DXCreateTeapot. When we run into a complaint about our lousy teapot, we can create a better one. So relax, just do a stub, and move on to more important

Re: D3DXCreateTeapot and reverse engineering?

2010-07-18 Thread Reece Dunn
On 18 July 2010 22:37, Dan Kegel d...@kegel.com wrote: IMHO, our criterion is we only need to implement what apps really need, and for the moment, that app probably could live with a stub for D3DXCreateTeapot.   When we run into a complaint about our lousy teapot, we can create a better one.  

re: D3DXCreateTeapot and reverse engineering?

2010-07-18 Thread Misha Koshelev
On Sun, 2010-07-18 at 14:37 -0700, Dan Kegel wrote: IMHO, our criterion is we only need to implement what apps really need, and for the moment, that app probably could live with a stub for D3DXCreateTeapot. When we run into a complaint about our lousy teapot, we can create a better one. So

Re: D3DXCreateTeapot and reverse engineering?

2010-07-18 Thread Roderick Colenbrander
On Sun, Jul 18, 2010 at 11:58 PM, Misha Koshelev misha...@gmail.com wrote: On Sun, 2010-07-18 at 14:37 -0700, Dan Kegel wrote: IMHO, our criterion is we only need to implement what apps really need, and for the moment, that app probably could live with a stub for D3DXCreateTeapot.   When we

Re: D3DXCreateTeapot and reverse engineering?

2010-07-18 Thread Misha Koshelev
I believe the GLMap2f functions are actually creating further vertex data... I could be wrong though. Thx Misha On Jul 18, 2010 5:46 PM, Roderick Colenbrander thunderbir...@gmail.com wrote: On Sun, Jul 18, 2010 at 11:58 PM, Misha Koshelev misha...@gmail.com wrote: On Sun, 2010-07-18 at... How

Re: D3DXCreateTeapot and reverse engineering?

2010-07-18 Thread Jeff Zaroyko
On Mon, Jul 19, 2010 at 10:48 AM, Misha Koshelev misha...@gmail.com wrote: I believe the GLMap2f functions are actually creating further vertex data... I could be wrong though. Thx Misha I don't know if this is entirely necessary for your purpose, but OpenGL has a feedback buffer which can be

Re: D3DXCreateTeapot and reverse engineering?

2010-07-18 Thread Misha Koshelev
Thank you. I will take a look at this tomorrow morning. On Jul 18, 2010 8:05 PM, Jeff Zaroyko jeffzaro...@gmail.com wrote: On Mon, Jul 19, 2010 at 10:48 AM, Misha Koshelev misha...@gmail.com wrote: I believe the GLMap2f... I don't know if this is entirely necessary for your purpose, but OpenGL

Re: kernel32: add a test for CreateFileA()

2010-07-18 Thread Austin English
On Sun, Jul 18, 2010 at 9:39 AM, James McKenzie jjmckenzi...@earthlink.net wrote: Austin English wrote: Passed all the vm's on wtb.   +    hFile = CreateFileA(c:\\*.*,

Re: kernel32: add a test for CreateFileA()

2010-07-18 Thread Austin English
On Sun, Jul 18, 2010 at 1:24 AM, Nikolay Sivov nsi...@codeweavers.com wrote:  On 7/18/2010 10:17, Austin English wrote: Passed all the vm's on wtb. Hi, Austin. This looks strange: + +    hFile = CreateFileA(c:\\*.*,

Re: kernel32: add a test for CreateFileA()

2010-07-18 Thread Dmitry Timoshkov
Austin English austinengl...@gmail.com wrote: +SetLastError(0xdeadbeef); +hFile = CreateFileA(c:\\*.*, GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL); +ok(GetLastError() == ERROR_INVALID_NAME || +broken(GetLastError() ==