Re: GetVolumeInformationA: please test this on MS-Windows

2010-08-03 Thread Jeff Zaroyko
On Mon, Aug 2, 2010 at 9:43 PM, joerg-cyril.hoe...@t-systems.com wrote: Jeff Zaroyko wrote: Would you mind supplying a new binary? Testbot did it for us: job #4154 https://testbot.winehq.org/JobDetails.pl?Key=4154 Regards,  Jörg Höhle This new #4154 binary doesn't have any failures when

Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

2010-08-03 Thread Michael Stefaniuc
Jeff Cook wrote: What compiler are you running? It works fine for me and I don't see any errors or warnings. You are passing the compiler the wrong flags: -Wdeclaration-after-statement is set by default in Wine. On Mon, Aug 2, 2010 at 6:05 AM, Alexandre Julliard julli...@winehq.org wrote:

Re: [PATCH 2/5] explorerframe/nstc: Create the treeview on initialization. (try 2)

2010-08-03 Thread Alexandre Julliard
David Hedberg david.hedb...@gmail.com writes: +static LRESULT resize_namespacetree(NSTC2Impl *This) +{ +RECT rc; +TRACE(%p\n, This); + +GetClientRect(This-hwnd_main, rc); +SetWindowPos(This-hwnd_tv, HWND_TOP, rc.left, rc.top, + rc.right, rc.bottom,

Re: regedit: Added Hebrew translation

2010-08-03 Thread Alexandre Julliard
Yaron Shahrabani sh.ya...@gmail.com writes: Hope everything is cool this time :) +IDD_EXPORT_TEMPLATE DIALOG 50, 50, 278, 54 +STYLE DS_3DLOOK | DS_CONTROL | WS_CHILD | WS_VISIBLE | WS_CLIPSIBLINGS | +WS_BORDER +WS_EX_LAYOUTRTL +FONT 8, MS Shell Dlg That's not valid syntax. Please try

Re: [PATCH 5/6] winealsa.drv: Don't open the same card on every loop. (resend)

2010-08-03 Thread Alexandre Julliard
Jeff Cook j...@deserettechnology.com writes: @@ -753,7 +753,7 @@ static int ALSA_ScanDevices(int directhw, char *pcmname = NULL; snd_pcm_t *pcm; -sprintf(defaultpcmname, default); +sprintf(defaultpcmname, default:%d, card); We used to do

Re: [5/5] wined3d: Fix NaN and Inf generation in msvc

2010-08-03 Thread Stefan Dösinger
Am 03.08.2010 um 02:47 schrieb Vitaly Budovski: The INFINITY macro is part of C99, but for NaN, why not use something like sqrt(-1) ? We don't use C99 features in Wine, some compilers don't support them. sqrt(-1) may or may not work, but it will be essentially the same as 0.0 / 0.0. Compilers

Re: [PATCH 2/5] gameux: Add stub of IGameStatisticsMgr implementation (try 2)

2010-08-03 Thread Nikolay Sivov
On 8/3/2010 13:58, Mariusz Pluciński wrote: --- dlls/gameux/Makefile.in |1 + dlls/gameux/factory.c|5 ++ dlls/gameux/gamestatistics.c | 153 ++ dlls/gameux/gameux_private.h |1 + dlls/gameux/regsvr.c |9 +++ 5

Re: wiki slightly broken still?

2010-08-03 Thread Alexandru Băluț
On Thu, Jul 29, 2010 at 18:01, Dimi Paun d...@lattica.com wrote: Now that this issue is fixed, we can look again at the spam problem. It was suggested that we use a 'TextChas' for non logged in users:    http://moinmo.in/HelpOnSpam But it seems it's not too easy to come up with decent

Re: [PATCH 2/5] gameux: Add stub of IGameStatisticsMgr implementation (try 2)

2010-08-03 Thread Mariusz Pluciński
W dniu 03.08.2010 13:28, Nikolay Sivov pisze: On 8/3/2010 13:58, Mariusz Pluciński wrote: --- dlls/gameux/Makefile.in | 1 + dlls/gameux/factory.c | 5 ++ dlls/gameux/gamestatistics.c | 153 ++ dlls/gameux/gameux_private.h | 1 + dlls/gameux/regsvr.c | 9 +++

Re: [PATCH 4/6] winealsa.drv: Append hw address to handle to prevent name collision. (resend)

2010-08-03 Thread Vitaliy Margolen
On 08/02/2010 05:49 PM, Jeff Cook wrote: --- dlls/winealsa.drv/waveinit.c | 9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) +sprintf(description, %s %d:%d, snd_pcm_info_get_name(infop), snd_pcm_info_get_card(infop), Please use snprintf to prevent possible buffer overflow.

Re: [PATCH 6/6] winealsa.drv: Open default device only once per card and don't discard non-defaults. (resend)

2010-08-03 Thread Vitaliy Margolen
On 08/02/2010 05:50 PM, Jeff Cook wrote: - + You adding trailing spaces here. +} else { +default_used = 1; } Please follow files' format - curly braces go on separate line. Also you don't need braces for one line else. Vitaliy.

Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 3)

2010-08-03 Thread Vitaliy Margolen
On 08/02/2010 05:48 PM, Jeff Cook wrote: Moved check to conform with C90. +if (mastelem) { +/* Master control */ ... +} else { Please follow file's format. Vitaliy

Re: wiki slightly broken still?

2010-08-03 Thread Dimi Paun
On Tue, 2010-08-03 at 14:30 +0200, Alexandru Băluț wrote: How difficult would it be to use ReCaptcha? http://www.google.com/recaptcha Hm, don't know. We could hack our version to support recaptcha, but I'm not familiar with the code base, and I don't have the time right now. But I can take

Re: wiki slightly broken still?

2010-08-03 Thread David Gerard
[to list as well] On 3 August 2010 15:07, Dimi Paun d...@lattica.com wrote: On Tue, 2010-08-03 at 14:30 +0200, Alexandru Băluț wrote: How difficult would it be to use ReCaptcha? http://www.google.com/recaptcha Hm, don't know. We could hack our version to support recaptcha, but I'm not

Re: [PATCH 3/6] winealsa.drv: Always scan devices, even if a default device exists. (resend)

2010-08-03 Thread Vitaliy Margolen
On 08/02/2010 05:49 PM, Jeff Cook wrote: --- dlls/winealsa.drv/waveinit.c | 6 +- 1 files changed, 5 insertions(+), 1 deletions(-) -int scan_devices = (fixedpcmdev == -1); +/* we always want to scan_devices; otherwise, if a default is set and the +appropriate registry keys are

Re: [PATCH 2/4] include/shlobj.h: SHILCreateFromPath takes both CSTR and WSTR

2010-08-03 Thread Alexandre Julliard
Andrew Eikum aei...@codeweavers.com writes: This is different from the latest PSDK, but Wine's SHILCreateFromPath accepts both types, so we shouldn't make compiler warnings about it. If there are warnings with the Windows headers there should be warnings with the Wine ones too. -- Alexandre

Should we expect Liberation fonts to be installed?

2010-08-03 Thread Scott Ritchie
I was looking through our fairly large collection of open font bugs and realized that things might be a lot simpler if we took some opinionated positions and just declared certain fonts to be dependencies and expected all packagers to provide them. This is similar to bundling our own Tahoma,

Re: Should we expect Liberation fonts to be installed?

2010-08-03 Thread David Gerard
On 3 August 2010 21:57, Scott Ritchie sc...@open-vote.org wrote: This bug, for instance, prevents Photoshop from working unless there is an Arial font installed: http://bugs.winehq.org/show_bug.cgi?id=9623 Wine doesn't seem to respect system-level fontconfig aliases, so even though Liberation

Re: regedit: Added Hebrew translation

2010-08-03 Thread Yaron Shahrabani
How can I compile a single RC file? Yaron Shahrabani Hebrew translator On Tue, Aug 3, 2010 at 12:39 PM, Alexandre Julliard julli...@winehq.orgwrote: Yaron Shahrabani sh.ya...@gmail.com writes: Hope everything is cool this time :) +IDD_EXPORT_TEMPLATE DIALOG 50, 50, 278, 54 +STYLE

Re: Should we expect Liberation fonts to be installed?

2010-08-03 Thread Scott Ritchie
On 08/03/2010 03:09 PM, David Gerard wrote: On 3 August 2010 21:57, Scott Ritchie sc...@open-vote.org wrote: This bug, for instance, prevents Photoshop from working unless there is an Arial font installed: http://bugs.winehq.org/show_bug.cgi?id=9623 Wine doesn't seem to respect system-level

Re: regedit: Added Hebrew translation

2010-08-03 Thread Charles Davis
On 8/3/10 4:58 AM, Yaron Shahrabani wrote: How can I compile a single RC file? After configuring Wine, go to the directory containing the RC file and type in a Terminal: make basename.res where basename is the part of the filename before the '.rc' extension. So if you wanted to compile only

Re: [PATCH 01/10] ddraw/tests: New CreateSurface for DDSCAPS_BACKBUFFER tests. (try 3)

2010-08-03 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4245 Your paranoid

Re: [PATCH 02/10] ddraw/tests: New attachment/flipping tests for back buffers. (try 3)

2010-08-03 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4246 Your paranoid

Re: [PATCH] kernel32/tests: Try harder to crash in the debugger test.

2010-08-03 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4248 Your paranoid

Re: [PATCH 03/10] ddraw/tests: Add test for NULL/bad size of surface caps in CreateSurface. (try 3)

2010-08-03 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4250 Your paranoid

Re: [PATCH 04/10] ddraw/tests: New visual back buffer flipping tests. (try 3)

2010-08-03 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4251 Your paranoid

Re: tools/winebuild: add missing separators

2010-08-03 Thread Andrew Nguyen
On Tue, Aug 3, 2010 at 9:57 PM, Austin English austinengl...@gmail.com wrote: -- -Austin The colons aren't decorative separators, but rather determine which short arguments expect a parameter as per the requirements of getopt/getopt_long. With your patch applied: $

Re: [PATCH 07/10] ddraw: Allow creating back buffer for DirectX 1 interfaces. (try 3)

2010-08-03 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4260 Your paranoid

Re: [PATCH 08/10] ddraw: Allow attaching backbuffers and primaries. (try 3)

2010-08-03 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4261 Your paranoid

Re: [PATCH 09/10] ddraw: Add checking of SURFACEDESC type into CreateSurface methods. (try 3)

2010-08-03 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4262 Your paranoid