Re: Should we expect Liberation fonts to be installed?

2010-08-16 Thread Austin English
On Mon, Aug 9, 2010 at 10:59 PM, Brian Vincent wrote: > Along those lines, the hard drive space is cheap on this one.  Seems > like Wine packagers could just include the fonts and install them > locally in c:\windows\fonts. The Liberation fonts are GPL licensed, Wine is LGPL. -- -Austin

RE: Wine users with a CD-ROM drive, please test

2010-08-16 Thread Ge van Geldorp
> From: Joerg Hoehle > > There's no mention of win95/98 in the attachment so I assume these > were not included, or was that because there was no error? Right, they were not included. I ran into some problems trying to attach the .iso to those VMs and gave up. Win9x should die :-). Ge.

Re: [PATCH 2/3] winex11.drv: set global key state

2010-08-16 Thread Rafał Miłecki
Hi Alexandre, W dniu 11 września 2009 13:22 użytkownik Alexandre Julliard napisał: > Rafał Miłecki writes: > >> @@ -1250,6 +1250,21 @@ void X11DRV_send_keyboard_input( WORD wVk, WORD >> wScan, DWORD event_flags, DWORD >>              key_state_table[wVkStripped] = key_state_table[wVkL] | >> ke

Re: [2/2] gdiplus: Implement multi-frame image loading.

2010-08-16 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4486 Your paranoid android.

Re: shdocvw: Remove useless menu separator

2010-08-16 Thread Frédéric Delanoy
On Mon, Aug 16, 2010 at 23:28, Octavian Voicu wrote: > Not sure if it's useless. I thing it's intended to separate the static > part of the menu (Add to favorites) from the dynamically generated > list of favorite items that follows (which isn't implemented yet). In that case, shouldn't the menu

Re: shdocvw: Remove useless menu separator

2010-08-16 Thread Octavian Voicu
Not sure if it's useless. I thing it's intended to separate the static part of the menu (Add to favorites) from the dynamically generated list of favorite items that follows (which isn't implemented yet). Octavian

Re: [4/6] ipconfig: Partially implement basic adapter information output.

2010-08-16 Thread Andrew Nguyen
On 08/16/2010 01:24 PM, Juan Lang wrote: Hi Andrew, +static const WCHAR ethernetW[] = {'E','t','h','e','r','n','e','t',0}; +static const WCHAR unknownW[] = {'U','n','k','n','o','w','n',0}; shouldn't these be resources instead? --Juan Hmm, I suppose they probably should be. I was being "

Re: [PATCH 1/5] d3d10: Fix d3dcommon.h inclusion.

2010-08-16 Thread James Mckenzie
Henri Verbeet wrote: >Sent: Aug 16, 2010 11:06 AM >To: Rico Schüller >Cc: wine-devel@winehq.org >Subject: Re: [PATCH 1/5] d3d10: Fix d3dcommon.h inclusion. > >2010/8/16 Rico Schüller : >> Yes, this replaces the earlier patch series. I thought this was clear from >> the discussion for try 2. >> >A

Re: [4/6] ipconfig: Partially implement basic adapter information output.

2010-08-16 Thread Juan Lang
Hi Andrew, +static const WCHAR ethernetW[] = {'E','t','h','e','r','n','e','t',0}; +static const WCHAR unknownW[] = {'U','n','k','n','o','w','n',0}; shouldn't these be resources instead? --Juan

WineAPI structure plans

2010-08-16 Thread Max TenEyck Woodbury
I think I have a usable structure for the pages on the WineAPI wiki which I am about to lay before you, but first a discussion of the project name... I understand that some people do not particularly approve of the name I have given this project. It is on Sourceforge and a short relevant na

Re: [PATCH 1/5] d3d10: Fix d3dcommon.h inclusion.

2010-08-16 Thread Henri Verbeet
2010/8/16 Rico Schüller : > Yes, this replaces the earlier patch series. I thought this was clear from > the discussion for try 2. > At the very least it's obvious that the other series isn't going to happen. Whether this series replaces it or is independent doesn't matter a whole lot at that point

Re: [PATCH 1/5] d3d10: Fix d3dcommon.h inclusion.

2010-08-16 Thread James Mckenzie
Rico Schüller wrote: >Sent: Aug 16, 2010 10:21 AM >To: wine-devel@winehq.org >Subject: Re: [PATCH 1/5] d3d10: Fix d3dcommon.h inclusion. > >Am 15.08.2010 18:26, schrieb James McKenzie: >> Rico Schüller wrote: >>> Hi, >>> >>> this patch series implements the ID3DBlob interface. This time the >>> i

Re: [PATCH 1/5] d3d10: Fix d3dcommon.h inclusion.

2010-08-16 Thread Rico Schüller
Am 15.08.2010 18:26, schrieb James McKenzie: Rico Schüller wrote: Hi, this patch series implements the ID3DBlob interface. This time the interface is implemented in the d3dcompiler_43.dll. The function D3D10CreateBlob from d3d10 is forwarded to the D3DCreateBlob function in the d3dcompiler_43

Wine users with a CD-ROM drive, please test

2010-08-16 Thread Joerg-Cyril.Hoehle
Hi, Greg Geldorp wrote: >I ran mcicda_test from TestBot job 4436 on the TestBot VMs, with a >data .iso connected as CD-ROM. Thank you very much for your excellent support. It's good to have such tests executed on a broad range of OS prior to submission. There's no mention of win95/98 in the attac

Re: [3/3] wined3d: Remove isInDraw hack from context_setup_target.

2010-08-16 Thread Stefan Dösinger
Am 16.08.2010 um 13:58 schrieb Henri Verbeet: > On 16 August 2010 13:25, Matteo Bruni wrote: >> It is conceptually wrong and actually broken too (as the comment there >> said). Just remove the hack now and properly fix any regression >> that may come up later by explicitely acquiring the right c

Re: [3/3] wined3d: Remove isInDraw hack from context_setup_target.

2010-08-16 Thread Henri Verbeet
On 16 August 2010 13:25, Matteo Bruni wrote: > It is conceptually wrong and actually broken too (as the comment there > said). Just remove the hack now and properly fix any regression > that may come up later by explicitely acquiring the right context where > needed (so, in surface_internal_preloa

Re: [1/3] wined3d: Call set_render_offscreen at the end of context_setup_target.

2010-08-16 Thread Henri Verbeet
I'm ok with this, but for future reference, if the change isn't entirely obvious a small comment is usually appropriate.

Re: [PATCH 2/2] jscript: Throw TypeError in in_eval.

2010-08-16 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4470 Your paranoid android.

Re: urlmon: Return failures from progress callback

2010-08-16 Thread Jacek Caban
Hi Juan, On 8/4/10 11:44 PM, Juan Lang wrote: Partial fix for bug 21032. --Juan if(!This->callback) -return; +return E_POINTER; This doesn't seem right. It's fine to call URLDownloadToFile without callback AFAIR. Thanks, Jacek

Re: [PATCH 1/2] jscript: Throw TypeError in instanceof_expression_eval.

2010-08-16 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4469 Your paranoid android.

Re: Some statistics about the 1.0->1.2 development cycle

2010-08-16 Thread Francois Gouget
On Sun, 15 Aug 2010, Marcus Meissner wrote: [...] > Similar for me ... "mar...@jet.franken.de" is my private account and means > private work. > > (The meiss...@suse.de account is however for work I have done on SUSE time.) Same split here: fgou...@codeweavers.com patches were for work and fgou

Re: [PATCH 1/1] d3dx9: Add tests for FVF <-> declaration conversion.

2010-08-16 Thread Henri Verbeet
This is for the most part just a copy of the corresponding d3d9 test, so I guess it should work, but it also contains most of the flaws from that test, like e.g. returning E_FAIL from a function returning int. There's probably room for improvement in the test setup itself as well.

kernel32/tests: GetVolumeInformationA X: succeeds iff drive's default dir is root. (try 2)

2010-08-16 Thread Joerg-Cyril.Hoehle
Hi, Greg Geldorp wrote: >I ... ran the test, >In short: everything passes. This is excellent news. Hopefully somebody will jump in and write code for kernel32/volume.c that satisfies the tests and get fame for fixing bug #23355 and help #20887. I'm nominating the bugfix for 1.2.1 Regards, Jörg H