Re: [PATCH 4/6] winealsa.drv: Append hw address to handle to prevent name collision. (resend)

On Tue, Aug 3, 2010 at 7:49 AM, Vitaliy Margolen wrote: >> +    memcpy(ww->ds_desc.szDesc, description, >> +            min( (sizeof(ww->ds_desc.szDesc) - 1), strlen(description)) >> ); > > This does not guarantee that ww->ds_desc.szDesc will be \0 terminated. > > Vitaliy. > What do you want me to

Re: [PATCH 5/6] winealsa.drv: Don't open the same card on every loop. (resend)

On Tue, Aug 3, 2010 at 3:57 AM, Alexandre Julliard wrote: > Jeff Cook writes: > >> @@ -753,7 +753,7 @@ static int ALSA_ScanDevices(int directhw, >>              char *pcmname = NULL; >>              snd_pcm_t *pcm; >> >> -            sprintf(defaultpcmname, "default"); >> +            sprintf(def

HEAP corruption again?

Hi, i wonder what is wine trying to tell me by "just discovered" message: warn:heap:HEAP_ValidateInUseArena Heap 0x11: invalid in-use arena magic 0055 for 0x118c10 Is that some kind of corruption or harmless? I found out, that ARENA_INUSE_MAGIC should be 0x455355. Then ARENA_INUSE_FIL

Re: Help with 6120d7cc145, causing bugs

Wylda reported success with the attached patch on bug 23902. Does it seem OK to everyone else? In this case, the extra channel needed for capture is not added when a micelem is found, because micelem should only be found when there is no other suitable playback or capture controls (i.e. "Mic" eleme

Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

On Tue, Aug 17, 2010 at 3:00 AM, sudemon wrote: > On 03.08.2010 04:36, Jeff Cook wrote: >> >> What compiler are you running? It works fine for me and I don't see >> any errors or warnings. > > I also don't see any errors or warnings. > > Аfter 6120d7cc14522983fbc38026ab4fcb6e4a68cdf0 commit - my g

Re: msvcrt:string Avoid size_t in ok()

Alexandre Goujon wrote: --- dlls/msvcrt/tests/string.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/msvcrt/tests/string.c b/dlls/msvcrt/tests/string.c index 94c2fa3..3c143d1 100644 --- a/dlls/msvcrt/tests/string.c +++ b/dlls/msvcrt/tests/string.c @@ -1

Re: msvcrt:string Avoid size_t in ok()

Not to be pedantic, but "did not return" is what you meant. J. Leclanche On Sat, Aug 28, 2010 at 2:38 PM, Alexandre Goujon wrote: > --- >  dlls/msvcrt/tests/string.c |   12 ++-- >  1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/dlls/msvcrt/tests/string.c b/dlls/msvcr

Re: d3d9 equivalent of D3DXFVFFromDeclarator?

On Fri, Aug 27, 2010 at 10:53 PM, Henri Verbeet wrote: > On 28 August 2010 02:44, Misha Koshelev wrote: >> I am looking again at d3d9, but feel like I am running in circles a >> little bit trying to chase down where convFVF and convertedDecls is >> coming from. >> >> If you have any hints/advice,

Re: winebuild on sparc, RFC

Austin English writes: > The first blocks running wine, the second blocks building it. For the > second, however, I found an old patch: > http://www.mail-archive.com/wine-devel@winehq.org/msg23307.html > > and rediffed it to current wine. With it, wine mostly compiles (mshtml > gets a 'Bus error'

winebuild on sparc, RFC

Howdy, Out of curiosity, I've been testing compiling Wine on Sparc. I've sent a few patches to fix a few problems that have crept up over the years. There are two big bugs left though: http://bugs.winehq.org/show_bug.cgi?id=24050 and http://bugs.winehq.org/show_bug.cgi?id=24142 The first blocks r

Re: dbghelp: Remove unused functions?

Le 28/08/2010 15:13, Andrew Talbot a écrit : Hi, Static functions pe_get_sect() and pe_get_sect_size() in dbghelp/pe_module.c are not called. May I remove them or does anyone have plans for them? Thanks, Andy. you can remove them. they have been superseeded by the ones in image_priva

dbghelp: Remove unused functions?

Hi, Static functions pe_get_sect() and pe_get_sect_size() in dbghelp/pe_module.c are not called. May I remove them or does anyone have plans for them? Thanks, Andy.