Re: Must copy static const D3DVERTEXELEMENT9 into dynamically alllocated D3DVERTEXELEMENT9 * before pointer passed correctly in Wine?

2010-09-07 Thread Nicolas Le Cam
2010/9/7 misha680 misha...@gmail.com Sorry for reposting - apparently my original nabble link did not work :( --- Dear All: Sorry to bother... I am working on a D3DXCreateMesh/ID3DXMesh patch, and I encountered a very strange error. Specifically, it seems that when passing a

Re: oleaut32: Handle TKIND_COCLASS subtype for VT_PTR/VT_USERDEFINED.

2010-09-07 Thread Jan Ohlsen
On Mon, Sep 6, 2010 at 6:18 PM, Vincent Povirk madewokh...@gmail.comwrote: + // Use IID of the coclass' default interface Don't use C++ comments. On Mon, Sep 6, 2010 at 10:31 AM, Jan Ohlsen jan.t.ohl...@gmail.com wrote: --- dlls/oleaut32/tmarshal.c |

Re: Must copy static const D3DVERTEXELEMENT9 into dynamically alllocated D3DVERTEXELEMENT9 * before pointer passed correctly in Wine?

2010-09-07 Thread Henri Verbeet
Take a good look at the function's prototype.

Re: [PATCH 2/5] winex11.drv: Complain a bit about missing s3tc support.

2010-09-07 Thread Alexandre Julliard
Henri Verbeet hverb...@codeweavers.com writes: Note that personally I don't think it's appropriate for winediag to abuse the __WINE_DBCL_ERR debug class for diagnostic messages. Nothing says that winediag messages have to be ERR. If it's not an important failure that all users have to see, it

Re: oleaut32: Handle TKIND_COCLASS subtype for VT_PTR/VT_USERDEFINED.

2010-09-07 Thread Dmitry Timoshkov
Jan Ohlsen jan.t.ohl...@gmail.com wrote: + case TKIND_COCLASS: { + ITypeInfo *pSubTypeInfo = NULL; + TYPEATTR*tattr2 = NULL; + GUID*iid = (tattr-guid); Once you set tab size to 8 in your editor, or better will not use tabs at all, you

Re: [PATCH 2/6] gameux: initial implementation of IGameExplorer::AddGame

2010-09-07 Thread Mariusz Pluciński
W dniu 03.09.2010 13:01, Nikolay Sivov pisze: On 9/3/2010 13:25, Mariusz Pluciński wrote: --- dlls/gameux/Makefile.in | 2 +- dlls/gameux/gameexplorer.c | 254 +- dlls/gameux/gameux_private.h | 63 ++ dlls/gameux/tests/gameexplorer.c | 18 ++-- 4 files

Re: [PATCH 2/5] winex11.drv: Complain a bit about missing s3tc support.

2010-09-07 Thread Henri Verbeet
On 7 September 2010 11:23, Alexandre Julliard julli...@winehq.org wrote: Nothing says that winediag messages have to be ERR. If it's not an important failure that all users have to see, it can be a WARN or a TRACE. The hypothetical diagnostic GUI tool can then display those differently.

Macro names instead of numbers in logs

2010-09-07 Thread Florian Köberle
Hello when running a program using wine it's possible to log +message to get informed about all the messages which get sent. This debug channel displays the macro names like WM_NOTIFY instead of numbers. The most other debug channels and the regression tests however display numbers. Functions

Re: Console issues in recent git

2010-09-07 Thread Alexandre Julliard
Eric Pouech eric.pou...@orange.fr writes: among the potential fixes: S1: no longer do the console attribute management in server, but only in kernel32, and only for the livespan of the process creating the bare console. this means that the console will not be accessible to the children of

Re: [PATCH 2/5] winex11.drv: Complain a bit about missing s3tc support.

2010-09-07 Thread Alexandre Julliard
Henri Verbeet hverb...@gmail.com writes: On 7 September 2010 11:23, Alexandre Julliard julli...@winehq.org wrote: Nothing says that winediag messages have to be ERR. If it's not an important failure that all users have to see, it can be a WARN or a TRACE. The hypothetical diagnostic GUI tool

Re: Macro names instead of numbers in logs

2010-09-07 Thread Mariusz Pluciński
W dniu 07.09.2010 12:09, Florian Köberle pisze: Hello when running a program using wine it's possible to log +message to get informed about all the messages which get sent. This debug channel displays the macro names like WM_NOTIFY instead of numbers. The most other debug channels and the

Using the eventlog API for Wine errors

2010-09-07 Thread Paul Vriens
Hi, I was just reading the emails about the winediag stuff and more particularly AJ's remark about the 'hypothetical GUI'. Would it make sense to really start fleshing out the eventlog API so we can/could log errors (or whatever) in that way? The GUI (or commandline app) could then 'easily'

Typo in : wined3d: Translate before scaling for rhw as well in transform_projection().

2010-09-07 Thread Joris Huizer
While skimming through recently committed patches, I noticed this piece: +/* Window Coord 0 is the middle of the first pixel, so translate by 1/2 pixels */ +glTranslatef(63.0f / 128.0f, 63.0f / 128.0f, 0.0f); +checkGLcall(glTranslatef(63.0f / 128.0f, -63.0f / 128.0f,

Re: Typo in : wined3d: Translate before scaling for rhw as well in transform_projection().

2010-09-07 Thread Henri Verbeet
On 7 September 2010 13:21, Joris Huizer joris_hui...@yahoo.com wrote: In the checkGLcall you changed the sign of the second parameter, but you didn't do this in the glTranslatef call. This seemed a bit strange (and I don't know which one would be right). The checkGLcall is wrong, though it

Re: [PATCH 3/6] gameux: add support of loading Application Id into registry

2010-09-07 Thread Mariusz Pluciński
W dniu 03.09.2010 13:13, Nikolay Sivov pisze: On 9/3/2010 13:25, Mariusz Pluciński wrote: + hr = IXMLDOMDocument_get_documentElement(lpXMLDocument,lpXMLRootElement); + if(hr == S_FALSE) + hr = E_FAIL; hr != S_OK works. I want this function to return E_FAIL in the case there's no root element,

Re: kernel32: forward GetThreadUILanguage() to GetUserDefaultUILanguage() (try 2)

2010-09-07 Thread Alexandre Julliard
Austin English austinengl...@gmail.com writes: @@ -658,6 +658,7 @@ @ stdcall GetTimeFormatA(long long ptr str ptr long) @ stdcall GetTimeFormatW(long long ptr wstr ptr long) @ stdcall GetTimeZoneInformation(ptr) +@ stdcall GetThreadUILanguage() GetUserDefaultUILanguage You can't do that,

Re: [PATCH 2/6] gameux: initial implementation of IGameExplorer::AddGame

2010-09-07 Thread Mariusz Pluciński
W dniu 07.09.2010 11:52, Mariusz Pluciński pisze: W dniu 03.09.2010 13:01, Nikolay Sivov pisze: On 9/3/2010 13:25, Mariusz Pluciński wrote: + WCHAR sInstanceId[40]; + WCHAR sRegistryPath[8192]; Where does this come from? Sizes I mean. I did a mistake. sInstanceId needs only 39 characters to

Re: Must copy static const D3DVERTEXELEMENT9 into dynamically alllocated D3DVERTEXELEMENT9 * before pointer passed correctly in Wine?

2010-09-07 Thread misha680
My apologies if my first patch was unclear. Here is a slightly modified git diff http://wine.1045685.n5.nabble.com/file/n2806011/patch patch along with the relevant make test output http://wine.1045685.n5.nabble.com/file/n2806011/maketestoutput maketestoutput The relevant part of the make

Re: Must copy static const D3DVERTEXELEMENT9 into dynamically alllocated D3DVERTEXELEMENT9 * before pointer passed correctly in Wine?

2010-09-07 Thread Henri Verbeet
On 7 September 2010 14:43, misha680 misha...@gmail.com wrote: LPD3DVERTEXELEMENT9 is a D3DVERTEXELEMENT9 *, http://msdn.microsoft.com/en-us/library/bb172630%28VS.85%29.aspx so LPD3DVERTEXELEMENT9 * is a D3DVERTEXELEMENT9 **, and to get at the Well yes, but why do you think that makes sense as

Re: msi/tests: Fix compilation on systems that don't support nameless unions or structs.

2010-09-07 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5078 Your paranoid

Re: ntdll: Don't cancel loading on IMAGE_FILE_RELOCS_STRIPPED

2010-09-07 Thread Marcus Meissner
On Tue, Sep 07, 2010 at 04:37:49PM +0200, André Hentschel wrote: give the file a try when it only links to ordinals instead of just stopping execution here. --- dlls/ntdll/virtual.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/dlls/ntdll/virtual.c

Re: ntdll: Don't cancel loading on IMAGE_FILE_RELOCS_STRIPPED

2010-09-07 Thread André Hentschel
Am 07.09.2010 17:27, schrieb Marcus Meissner: On Tue, Sep 07, 2010 at 04:37:49PM +0200, André Hentschel wrote: give the file a try when it only links to ordinals instead of just stopping execution here. --- dlls/ntdll/virtual.c |4 1 files changed, 0 insertions(+), 4 deletions(-)

Re: Console issues in recent git

2010-09-07 Thread PleegWat
On 09/06/2010 10:00 PM, Eric Pouech wrote: Actually, there's another issue with the same symptoms: 1- program A is launched from shell 2- program A starts another program B (for example winedbg when a fault occurs) 3- at this point, both A B can read/write to the console 4- program A exits. As

Re: Must copy static const D3DVERTEXELEMENT9 into dynamically alllocated D3DVERTEXELEMENT9 * before pointer passed correctly in Wine?

2010-09-07 Thread Misha Koshelev
On Tue, 2010-09-07 at 15:56 +0200, Henri Verbeet wrote: On 7 September 2010 14:43, misha680 misha...@gmail.com wrote: LPD3DVERTEXELEMENT9 is a D3DVERTEXELEMENT9 *, http://msdn.microsoft.com/en-us/library/bb172630%28VS.85%29.aspx so LPD3DVERTEXELEMENT9 * is a D3DVERTEXELEMENT9 **, and to

Re: ntdll: Don't cancel loading on IMAGE_FILE_RELOCS_STRIPPED

2010-09-07 Thread Paul Chitescu
On Tuesday 07 September 2010 06:47:12 pm André Hentschel wrote: Am 07.09.2010 17:27, schrieb Marcus Meissner: On Tue, Sep 07, 2010 at 04:37:49PM +0200, André Hentschel wrote: give the file a try when it only links to ordinals instead of just stopping execution here. ---

Re: Wine Introduction Page

2010-09-07 Thread Ken Thomases
On Sep 4, 2010, at 2:20 PM, James McKenzie wrote: I know it is in git. I don't want to give out bogus information, that's why the question. I don't have an Intel system here with MacOSX 10.4 installed anymore, all of mine are at 10.6.4 Same thing with XCode. I know that the 2.x is at

Re: Wine Introduction Page

2010-09-07 Thread James Mckenzie
Ken Thomases k...@codeweavers.com wrote: Sent: Sep 7, 2010 9:17 AM To: James McKenzie jjmckenzi...@earthlink.net Cc: wine-devel@winehq.org wine-devel@winehq.org Subject: Re: Wine Introduction Page On Sep 4, 2010, at 2:20 PM, James McKenzie wrote: I know it is in git. I don't want to give out

Re: ntdll: Don't cancel loading on IMAGE_FILE_RELOCS_STRIPPED

2010-09-07 Thread Greg Geldorp
From: Paul Chitescu pa...@voip.null.ro In a typical Win32 environment the executables don't have relocations since they load at a fixed address. Old (Visual C 4.x and older) executables had relocations so they could run on Win32s. Not all that relevant to the patch, but... Newer executables

specfiles containing 'str' instead of 'wstr' for some W-functions

2010-09-07 Thread Paul Vriens
Hi, I see some specfiles that contain 'str' instead of the correct 'wstr'. Is it worth sending a patch to fix these? If so, only one? -- Cheers, Paul.

Re: [PATCH] Fill a SECBUFFER_MISSING buffer if the message is not complete

2010-09-07 Thread Juan Lang
Hi Mikko, +// This is a bit weird, but windows does it too You can't use C++-style comments in Wine. You do the same in your tests patch, too. --Juan

Re: [PATCH] Fill a SECBUFFER_MISSING buffer if the message is not complete

2010-09-07 Thread Austin English
On Tue, Sep 7, 2010 at 10:44 AM, Mikko Rasa t...@tdb.fi wrote: ---  dlls/secur32/schannel.c |    9 +  1 files changed, 9 insertions(+), 0 deletions(-) Howdy Mikko, diff --git a/dlls/secur32/schannel.c b/dlls/secur32/schannel.c index 78757ac..192f9cb 100644 ---

Re: Ongoing Debian package maintenance.

2010-09-07 Thread Lei Zhang
On Sat, Sep 4, 2010 at 1:09 PM, Ben Klein shackl...@gmail.com wrote: On 25 August 2010 11:31, Lei Zhang thes...@google.com wrote: On Tue, Aug 24, 2010 at 3:06 PM, Ben Klein shackl...@gmail.com wrote: On 24 August 2010 04:34, Lei Zhang thes...@google.com wrote: On Fri, Aug 20, 2010 at 4:00 PM,

Re: [PATCH] Fill a SECBUFFER_MISSING buffer if the message is not complete

2010-09-07 Thread Hans Leidekker
Hi Mikko, diff --git a/dlls/secur32/schannel.c b/dlls/secur32/schannel.c index 78757ac..192f9cb 100644 --- a/dlls/secur32/schannel.c +++ b/dlls/secur32/schannel.c @@ -1244,6 +1244,15 @@ static SECURITY_STATUS SEC_ENTRY schan_DecryptMessage(PCtxtHandle context_handle

Re: [PATCH] Add some more schannel tests

2010-09-07 Thread Hans Leidekker
@@ -116,6 +128,10 @@ static void InitFunctionPtrs(void) if(!secdll) secdll = LoadLibraryA(security.dll); advapi32dll = GetModuleHandleA(advapi32.dll); +wsockdll = LoadLibraryA(ws2_32.dll); + +if(!wsockdll) + printf(Couldn't open ws2_32.dll\n); Why

Re: Ongoing Debian package maintenance.

2010-09-07 Thread Octavian Voicu
On Tue, Sep 7, 2010 at 9:42 PM, Lei Zhang thes...@google.com wrote: It would be helpful if you provide the content of your debian/ directory. I wrote my own debian/control file and what not and built a wine-gecko-1.1.0 .deb over the weekend. I haven't finished working on the main Wine

Re: [PATCH] Fill a SECBUFFER_MISSING buffer if the message is not complete

2010-09-07 Thread Mikko Rasa
On 07.09.2010 22:37, Hans Leidekker wrote: Hi Mikko, diff --git a/dlls/secur32/schannel.c b/dlls/secur32/schannel.c index 78757ac..192f9cb 100644 --- a/dlls/secur32/schannel.c +++ b/dlls/secur32/schannel.c @@ -1244,6 +1244,15 @@ static SECURITY_STATUS SEC_ENTRY

Re: [PATCH] Fill a SECBUFFER_MISSING buffer if the message is not complete

2010-09-07 Thread Mikko Rasa
On 07.09.2010 21:29, Juan Lang wrote: Hi Mikko, +// This is a bit weird, but windows does it too You can't use C++-style comments in Wine. You do the same in your tests patch, too. Sorry, my bad. I'll fix them up. -- Mikko

Re: [PATCH] Add some more schannel tests

2010-09-07 Thread Mikko Rasa
On 07.09.2010 22:37, Hans Leidekker wrote: @@ -116,6 +128,10 @@ static void InitFunctionPtrs(void) if(!secdll) secdll = LoadLibraryA(security.dll); advapi32dll = GetModuleHandleA(advapi32.dll); +wsockdll = LoadLibraryA(ws2_32.dll); + +if(!wsockdll) +

Re: kernel32/tests: typo fixes

2010-09-07 Thread Nicolas Le Cam
2010/9/7 Austin English austinengl...@gmail.com I initially noticed the wrong hemisphere label, but then the capitalization was bugging me :-) -- -Austin Hi Austin, @@ -449,18 +449,18 @@ static void test_TzSpecificLocalTimeToSystemTime(void) tzW.DaylightBias=-60;

Re: [PATCH] Add some more schannel tests

2010-09-07 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5092 Your paranoid

Re: [PATCH] Add some more schannel tests

2010-09-07 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5095 Your paranoid

Re: [PATCH 5/5] Add some more schannel tests

2010-09-07 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5096 Your paranoid

mshtml: Correct test for unknown dispID

2010-09-07 Thread Alistair Leslie-Hughes
Changelog: mshtml: Correct test for unknown dispID Best Regards Alistair Leslie-Hughes From 1d422d3162a048f354671301e9a58e41d7641d94 Mon Sep 17 00:00:00 2001 From: Alistair Leslie-Hughes leslie_alist...@hotmail.com Date: Wed, 8 Sep 2010 14:39:53 +1000 Subject: [PATCH] Correct test for