Re: ddraw: Add checking of SURFACEDESC type/nullness into CreateSurface methods.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5285 Your paranoid android.

Re: [4/4] msxml3/tests: Store test data as a table for ::nodeTypedValue() tests

On 9/17/2010 04:58, (Marvin) wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDet

Re: secur32: Handle extra data in schan_InitializeSecurityContextW.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5281 Your paranoid android.

Re: [4/4] msxml3/tests: Store test data as a table for ::nodeTypedValue() tests

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5279 Your paranoid android.

Re: [1/2]user32: remove unnecessary code (try 2)

Am 16.09.2010 20:56, schrieb Alexandre Julliard: > André Hentschel writes: > >> that code is in an else-case of an other "if (!(uFlags & DFCS_TRANSPARENT))" > > No it's not. > You are right, damn indentation issues :/ -- Best Regards, André Hentschel

Re: [1/2]user32: remove unnecessary code (try 2)

André Hentschel writes: > that code is in an else-case of an other "if (!(uFlags & DFCS_TRANSPARENT))" No it's not. -- Alexandre Julliard julli...@winehq.org

Re: [1/2]user32: remove superfluous code

Hi André, > that code is in an else-case of an other "if (!(uFlags & DFCS_TRANSPARENT))" In that case, can't you remove the ternary operation in this line? UITOOLS95_DrawRectEdge(dc, r, edge, (uFlags & DFCS_FLAT) | ((uFlags & DFCS_TRANSPARENT) ? 0 : BF_MIDDLE) | BF_RECT | BF_SOFT); -

Re: [PATCH] ole32: check for interface NULL which happens with e.g. Abiword

Marcus Meissner wrote: > + unk = NULL; >hr = IDropTarget_QueryInterface(pDropTarget, &IID_IUnknown, (void**)&unk); >if(FAILED(hr)) >{ >IStream_Release(stream); >return hr; >} > + if (!unk) { > + WARN("hr was %d, but unk is NULL.\n", hr); > + IStream_Rel

Re: User-settable limit on desktop window size?

writes: > Is there something to have Wine consistently lie about the real size, > i.e. report no resolution above 1024x768? > I'm asking because I can remember some apps whose "centered" logos > or requesters appear almost outside the virtual desktop window, > towards the lower right, as if their

Re: d3dx9_36: Implement D3DXCreateMesh and initial ID3DXMesh methods. (try 3)

On 16 September 2010 14:40, Misha Koshelev wrote: > So, just to clarify to make sure my understanding is complete, what you > are saying is for DrawSubset(), we will need to create an FVF declarator > from a non-FVF declarator, correct? > No, what I'm saying is that I strongly suspect that in orde

Re: d3dx9_36: Implement D3DXCreateMesh and initial ID3DXMesh methods. (try 3)

On Thu, 2010-09-16 at 10:25 +0200, Henri Verbeet wrote: > On 16 September 2010 02:23, misha680 wrote: > > Could you possible clarify your statement > > "though I wonder if implementing DrawSubset() isn't going to require > > creating a > > vertex declaration anyway." > > > > My understanding from

Re: Add Intel GM45 detection

You also have some trailing spaces.

User-settable limit on desktop window size?

Hi, Alexandre Julliard wrote in another thread: >The destop window is supposed to be the size of the whole screen. Is there something to have Wine consistently lie about the real size, i.e. report no resolution above 1024x768? I'm asking because I can remember some apps whose "centered" logos or

Re: [PATCH 2/2] winmm: Auto-open MCI core commands only.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5258 Your paranoid android.

Re: d3dx9_36: Implement D3DXCreateMesh and initial ID3DXMesh methods. (try 3)

On 16 September 2010 02:23, misha680 wrote: > Could you possible clarify your statement > "though I wonder if implementing DrawSubset() isn't going to require > creating a > vertex declaration anyway." > > My understanding from > http://msdn.microsoft.com/en-us/library/bb205736%28v=VS.85%29.aspx >