Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd +tests (try 2)

2010-09-28 Thread Dmitry Timoshkov
Louis Lenders xerox_xerox2...@yahoo.co.uk wrote: +SetLastError(0xdadadada); +retval = UpdateWindow(NULL); +ok( !retval, Expected 0, got %d\n, retval); +ok( GetLastError() == ERROR_INVALID_WINDOW_HANDLE || broken(GetLastError() == 0xdadadada) /* win9x */, Expected

Line Length (Was: Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd +tests (try 2))

2010-09-28 Thread Michael Stefaniuc
Dmitry Timoshkov wrote: Louis Lenders xerox_xerox2...@yahoo.co.uk wrote: +SetLastError(0xdadadada); +retval = UpdateWindow(NULL); +ok( !retval, Expected 0, got %d\n, retval); +ok( GetLastError() == ERROR_INVALID_WINDOW_HANDLE || broken(GetLastError() == 0xdadadada) /*

Re: Line Length (Was: Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd +tests (try 2))

2010-09-28 Thread Wolfram Sang
It's better to use a commonly accepted 0xdeadbeef as an invalid last error value, and limit the line length somewhere at 80. A line length of 80 is kinda outdated, I have talked to Alexandre and he considers 100 a better value. I would have preferred 120 to hold for a while. +1 \o/

Re: [1/7] msvcrt: Initialize the environ global variables on DLL load.

2010-09-28 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5546 Your paranoid

Re: [2/2] msxml3/httprequest: Implement IXMLHttpRequest::setRequestHeader() (try3)

2010-09-28 Thread Alexandre Julliard
Nikolay Sivov nsi...@codeweavers.com writes: try3: fixed some test failures Should still be applied over [1/2] patch, let me know if I should resend both. Yes please, otherwise testbot won't be able to figure out the sequence. -- Alexandre Julliard julli...@winehq.org

winscard.dll

2010-09-28 Thread viny
Hi all, Is anyone working on winscard.dll ? If not, may I propose patches ? I would like to have a working winscard.dll in wine. -- Vincent

Re: [PATCH 2/6] msxml3: ignore whitespace nodes

2010-09-28 Thread Nikolay Sivov
On 9/28/2010 05:37, Adam Martinson wrote: From 1f8661342ae63290f212429e382b5776e07b9ebc Mon Sep 17 00:00:00 2001 From: Adam Martinsonamartin...@codeweavers.com Date: Mon, 27 Sep 2010 19:29:04 -0500 Subject: [PATCH 2/6] msxml3: ignore whitespace nodes --- dlls/msxml3/msxml_private.h | 15

Re: winscard.dll

2010-09-28 Thread Tom Wickline
Hello Vincent, I don't believe anyone is working on winscard.dll at this time. You are more then welcome to work on it or any other part of Wine. A couple years back their was a discussion about winscard.dll so you might want to search through the wine-dev mailing list. Maybe those old

Re: [1/2] msxml3/httprequest: Store passed data for IXMLHttpRequest::open()

2010-09-28 Thread Jacek Caban
Hi Nikolay, On 9/28/10 1:30 PM, Nikolay Sivov wrote: Resent for series completeness. +hr = VariantChangeType(str,user, 0, VT_BSTR); +if (hr == S_OK) +{ +This-user = SysAllocString(V_BSTR(str)); +VariantClear(str); +} You already own the reference to string

Re: [2/2] msxml3/httprequest: Implement IXMLHttpRequest::setRequestHeader() (still try3)

2010-09-28 Thread Jacek Caban
Hi Nikolay, +entry = heap_alloc(sizeof(*entry)); +if (!entry) return E_OUTOFMEMORY; + +/* new header */ +list_add_head(This-reqheaders,entry-entry); + +return S_OK; It seems like filling the new header's name and value is missing here. Jacek

Re: winscard.dll

2010-09-28 Thread Jerome Leclanche
The referenced discussion, in case anyone's curious: http://www.winehq.org/pipermail/wine-devel/2008-August/068462.html J. Leclanche On Tue, Sep 28, 2010 at 12:43 PM, Tom Wickline twickl...@gmail.com wrote: Hello Vincent, I don't believe anyone is working on winscard.dll at this time. You

Re: winscard.dll

2010-09-28 Thread Tom Wickline
Thanks, I was to lazy to search for it. :) Tom On Tue, Sep 28, 2010 at 7:56 PM, Jerome Leclanche adys...@gmail.com wrote: The referenced discussion, in case anyone's curious: http://www.winehq.org/pipermail/wine-devel/2008-August/068462.html J. Leclanche

Re: [2/3] comctl32/tab: Fix DRAWITEMSTRUCT filling when large enough extra item data is used (try2)

2010-09-28 Thread Alexandre Julliard
Nikolay Sivov nsi...@codeweavers.com writes: Fix DRAWITEMSTRUCT filling when large enough extra item data is used I'd like to see a test with smaller sizes too. -- Alexandre Julliard julli...@winehq.org

Re: [2/3] comctl32/tab: Fix DRAWITEMSTRUCT filling when large enough extra item data is used (try2)

2010-09-28 Thread Nikolay Sivov
On 9/28/2010 16:10, Alexandre Julliard wrote: Nikolay Sivovnsi...@codeweavers.com writes: Fix DRAWITEMSTRUCT filling when large enough extra item data is used I'd like to see a test with smaller sizes too. Ok.

Re: ws2_32/tests: Send zero byte to any connected IrDA device (resend)

2010-09-28 Thread Alexandre Julliard
Wolfgang Schwotzer wolfgang.schwot...@gmx.net writes: Test for bug #19397. Test only executed, if remote IrDA device is present. Otherwise test is skipped. (Proposal from Mike Kaplinskiy) I'm not sure this is very useful. It's unlikely to be run on any of the test boxes, and AFAICS this is a

Re: winscard.dll

2010-09-28 Thread viny
Yes I started with this referenced discussion. Here is a first patch. With it, Winscard can identify your smartcard reader. Is it good enough to be sent to wine-patch ? Here (http://www.linuxunderground.be/compteco/winscard_test.zip) a Windows test program that identifies your smartcard

Re: ws2_32(3/3): Implement WSAIoctl for SIO_ROUTING_INTERFACE_QUERY

2010-09-28 Thread Alexandre Julliard
Juan Lang juan.l...@gmail.com writes: This one may cause test failures on systems that don't have a route to the loopback address. As far as I can tell, Windows systems always have such a route, whereas on *ix it isn't guaranteed. I'm not sure how to handle that, as broken() isn't allowed

mshtml and friends

2010-09-28 Thread Reece Dunn
Hi, The current state of support for the Internet Explorer components in Wine is good, but there are applications that don't work with it because they are dependent on more of the functionality provided by Internet Explorer via the WebBrowser control. I have had a scan through some of the mshtml

Re: winscard.dll

2010-09-28 Thread Vitaliy Margolen
On 09/28/2010 06:46 AM, viny wrote: Yes I started with this referenced discussion. Here is a first patch. With it, Winscard can identify your smartcard reader. +g_pcscliteHandle = wine_dlopen(libpcsclite.so, RTLD_LAZY | RTLD_GLOBAL, error, sizeof(error)); You need to use configure

Re: [PATCH 2/6] d3dcompiler: Implement D3DGetBlobPart().(try 2)

2010-09-28 Thread Henri Verbeet
2010/9/27 Rico Schüller kgbric...@web.de: --- Wouldn't it be nicer if the count parameter to dxbc_init() was more of a hint? I.e., allow the sections array to grow if needed. For parse_dxbc() this works fine, because you know the number of sections in advance, but as you must have noticed, for

Re: [PATCH 2/6] d3dcompiler: Implement D3DGetBlobPart().(try 2)

2010-09-28 Thread Henri Verbeet
2010/9/27 Rico Schüller kgbric...@web.de: !strcmp(unrecognized, debug_d3dcompiler_d3d_blob_part(part)) Oh, and please don't do that, I think it's very fragile.

Re: mshtml and friends

2010-09-28 Thread Jacek Caban
Hi Reece, On 9/28/10 2:59 PM, Reece Dunn wrote: Hi, The current state of support for the Internet Explorer components in Wine is good, but there are applications that don't work with it because they are dependent on more of the functionality provided by Internet Explorer via the WebBrowser

Re: widl: Explicitly declare default function's calling convention to avoid win64 problems.

2010-09-28 Thread Jacek Caban
On 9/28/10 2:09 PM, Alexandre Julliard wrote: Jacek Cabanja...@codeweavers.com writes: @@ -369,7 +369,7 @@ static void write_type_v(FILE *h, type_t *t, int is_field, int declonly, const c if (type_get_type_detect_alias(pt) == TYPE_FUNCTION) { int i; const char

Re: [PATCH 3/3] winex11: Add support for animated cursors in X11 driver.

2010-09-28 Thread Alexandre Julliard
Erich Hoover ehoo...@mines.edu writes: @@ -508,35 +517,90 @@ static Cursor create_xcursor_cursor( HDC hdc, ICONINFO *icon, int width, int hei info-bmiHeader.biYPelsPerMeter = 0; info-bmiHeader.biClrUsed = 0; info-bmiHeader.biClrImportant = 0; -GetDIBits( hdc,

Re: [PATCH 1/4] gameux: initial implementation of loading game statistics

2010-09-28 Thread Alexandre Julliard
Mariusz Pluciński vsha...@gmail.com writes: +static BOOL GAMEUX_isFileExists(LPCWSTR sFile) +{ +HANDLE hFile; + +hFile = CreateFileW(sFile, GENERIC_READ, 0, +NULL, OPEN_EXISTING, 0, NULL); + +if(hFile == INVALID_HANDLE_VALUE) +return FALSE; + +

Re: [1/7] msvcrt: Initialize the environ global variables on DLL load.

2010-09-28 Thread Alexandre Julliard
Andrew Nguyen angu...@codeweavers.com writes: +ok( environ != NULL, Expected the environ global variable to be initialized on startup\n ); +ok( _wenviron != NULL, Expected the _wenviron global variable to be initialized on startup\n ); This won't test what you want, importing

Re: mshtml and friends

2010-09-28 Thread Reece Dunn
On 28 September 2010 15:14, Jacek Caban ja...@codeweavers.com wrote:  Hi Reece, On 9/28/10 2:59 PM, Reece Dunn wrote: Hi, The current state of support for the Internet Explorer components in Wine is good, but there are applications that don't work with it because they are dependent on

Re: [PATCH 2/6] msxml3: ignore whitespace nodes

2010-09-28 Thread Adam Martinson
On 09/28/2010 06:27 AM, Nikolay Sivov wrote: On 9/28/2010 05:37, Adam Martinson wrote: From 1f8661342ae63290f212429e382b5776e07b9ebc Mon Sep 17 00:00:00 2001 From: Adam Martinsonamartin...@codeweavers.com Date: Mon, 27 Sep 2010 19:29:04 -0500 Subject: [PATCH 2/6] msxml3: ignore whitespace

Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd +tests (try3)

2010-09-28 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5575 Your paranoid

Re: comctl32/tab: Fix DRAWITEMSTRUCT filling when extra item data of a custom size is used (try2)

2010-09-28 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5580 Your paranoid

Re: ws2_32: Add default case for family in debugstr_wsaioctl.

2010-09-28 Thread Juan Lang
Hi Gerald, This mimicks what we already do a few lines above for buf_type. It's also unneeded: switch(ioctl 0x1800) There are only 4 possible combinations of ioctl 0x1800. Three are covered in this switch statement, and the fourth is eliminated due to the outer switch

Re: winscard.dll

2010-09-28 Thread James McKenzie
On 9/28/10 1:49 AM, viny wrote: Hi all, Is anyone working on winscard.dll ? If not, may I propose patches ? You might want to visit the Developer FAQ on the Wine Wiki at http://wiki.winehq.org/DeveloperFaq and then read through all of the Submitting Patches portion as well. Good luck on

Re: winscard.dll

2010-09-28 Thread Mounir IDRASSI
viny vincent.hardy.be at gmail.com writes: Yes I started with this referenced discussion. Here is a first patch. With it, Winscard can identify your smartcard reader. Is it good enough to be sent to wine-patch ? Hi Vincent, I'm the original author of the Winscard patch sent in 2007 and