Re: kernel32/process: Implement GetLogicalProcessorInformation (rewrite - try 3)

2010-10-05 Thread Rudolf Mayerhofer
Have you checked that it doesn't just return a SYSTEM_LOGICAL_PROCESSOR_INFORMATION ? It seems to be the right format for the name anyway. I'd play with the size argument or try using NtQuerySystemInformationEx (some new thing in win7). You could just find a case that passes and implement it

Re: [PATCH 1/6] urlmon: Report error on synchronous bindings that don't have a cache file and are not read in callback.

2010-10-05 Thread Alexandre Julliard
Jacek Caban ja...@codeweavers.com writes: --- dlls/urlmon/binding.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) This breaks the gameux tests: ../../../tools/runtest -q -P wine -M gameux.dll -T ../../.. -p gameux_test.exe.so gameexplorer.c touch

Re: [PATCH 1/6] urlmon: Report error on synchronous bindings that don't have a cache file and are not read in callback.

2010-10-05 Thread Nikolay Sivov
On 10/5/2010 14:09, Alexandre Julliard wrote: Jacek Cabanja...@codeweavers.com writes: --- dlls/urlmon/binding.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) This breaks the gameux tests: ../../../tools/runtest -q -P wine -M gameux.dll -T ../../.. -p

Re: [1/2] user32: fix FindWindowEx behavior if window name is an empty charachter

2010-10-05 Thread Ricardo Filipe
2010/10/5 Louis Lenders xerox_xerox2...@yahoo.co.uk: It would be better to avoid duplicate GetWindowTextW() calls. I thought a long time how to fix this, but i couldn't find another way than this one, because we need to find out whether or not the window title is empty, and afaik we can only

Re: ImmReleaseContext() function implementation

2010-10-05 Thread Aric Stewart
I do not believe this is correct. You would be destroying the context every time it is released and that is clearly not what we want to be doing ass ImmGetContext and ImmReleaseContext as a pair are called over and over again in a typical application. -aric On 10/4/10 1:25 PM, Mikhail

Re: winex11: Add support for animated cursors in X11 driver (try 5).

2010-10-05 Thread Alexandre Julliard
Erich Hoover ehoo...@mines.edu writes: +imgs[nFrames++] = image; +if (!(imgstmp = HeapReAlloc( GetProcessHeap(), 0, imgs, nFrames*sizeof(XcursorImage*) ))) goto cleanup; +imgs = imgstmp; This is still broken. -- Alexandre Julliard julli...@winehq.org

Re: [1/2] user32: fix FindWindowEx behavior if window name is an empty charachter

2010-10-05 Thread Dmitry Timoshkov
Louis Lenders xerox_xerox2...@yahoo.co.uk wrote: It would be better to avoid duplicate GetWindowTextW() calls. I thought a long time how to fix this, but i couldn't find another way than this one, because we need to find out whether or not the window title is empty, and afaik we can only do

Re: [2/3] kernel32/process: Implement GetLogicalProcessorInformation using NtQuerySystemInformation

2010-10-05 Thread Vitaliy Margolen
On 10/05/2010 04:46 AM, Rudolf Mayerhofer wrote: --- dlls/kernel32/process.c | 21 ++--- 1 files changed, 18 insertions(+), 3 deletions(-) Please exchange patches 2 and 3. And everywhere in your patches, please stick to _THE SAME_ formatting as the rest of the file you

Re: msi: Put the uninstall key for 32-bit packages under Wow6432Node on 64-bit.

2010-10-05 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5824 Your paranoid

Re: msi: Put the uninstall key for 32-bit packages under Wow6432Node on 64-bit.

2010-10-05 Thread Hans Leidekker
On Tue, 2010-10-05 at 16:59 +0200, test...@testbot.winehq.org wrote: While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at

winmm/tests: Don't test the non-default Midi devices if the 'PreferredOnly' Windows setting is set.

2010-10-05 Thread Joerg-Cyril.Hoehle
Hi, a few month ago when the discussion about PreferredOnly registry setting came up, I queried Google and found that many more users use this setting than one may believe - i.e. it is not exotic. Therefore, I don't think it's that great an idea to reduce the number of devices that the tests

Re: [PATCH] shlwapi: Handle URL_WININET_COMPATIBLITY flag in UrlCanonicalize

2010-10-05 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5828 Your paranoid

Re: user32/tests: Test FindWindowEx for empty window title (try 2)

2010-10-05 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5829 Your paranoid

Re: (6th try) winhlp32: Added Hebrew translation

2010-10-05 Thread Paul Vriens
Hi Yaron, I'm see this one is still not applied. Maybe because there are still some small issues? See below. On 10/03/2010 11:12 PM, Yaron Shahrabani wrote: +LANGUAGE LANG_HEBREW, SUBLANG_DEFAULT This line should go, it's redundant (it's already stated at the beginning). This line was

Re: crypt32/tests(1/10): Add more tests of verifying the base policy, including flags to ignore certain errors

2010-10-05 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5867 Your paranoid

Re: crypt32/tests(5/10): Test the base and SSL policies against a certificate with an invalid critical extension

2010-10-05 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5870 Your paranoid

Re: crypt32/tests(4/10): Test invalid critical extension in intermediate cert

2010-10-05 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5869 Your paranoid

Re: crypt32(2/10): Improve error checking for the base policy

2010-10-05 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5868 Your paranoid