Re: [PATCH] mscms: patch for problem with displaying images with enabled color management in system and some apps

2010-10-18 Thread Hans Leidekker
Hi Tomasz, Please use a more specific subject such as mscms: Handle bitmap formats BM_xRGBQUADS and BM_xBGRQUADS in TranslateBitmapBits.

Re: cmd: Add a space at the end of the first echo'ed batch line [try4]

2010-10-18 Thread Alexandre Julliard
Alexandre Goujon ale.gou...@gmail.com writes: I was looking for a forbidden char in batch files but just I found accentuated chars whereas I wanted a single (not wide) char. Finally, I found it in the ASCII table. The \x1a character name is SUBSTITUTE and is exactly what we need. It means

Re: [PATCH 3/3] winspool: Use UNICODE for CUPS printer names [fixes bug 6437]

2010-10-18 Thread Alexandre Julliard
Detlef Riekenberg wine@web.de writes: or do we have to remove all related const from the strings? Yes. -- Alexandre Julliard julli...@winehq.org

Re: [4/4] msxml3: Partially implement ::setAttributeNode()

2010-10-18 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6265 Your paranoid

Re: [1/4] msxml3: Get rid of ::get_dataType() forward to IXMLDOMNode interface

2010-10-18 Thread Jacek Caban
Hi Nikolay, On 10/18/10 11:26 AM, Nikolay Sivov wrote: Get rid of ::get_dataType() forward to IXMLDOMNode interface switch ( This-node-type ) { case XML_ELEMENT_NODE: On of points of such patches is to get rid of such switches. In this case it seems like introducing new

Re: [1/4] msxml3: Get rid of ::get_dataType() forward to IXMLDOMNode interface

2010-10-18 Thread Nikolay Sivov
On 10/18/2010 15:53, Jacek Caban wrote: Hi Nikolay, On 10/18/10 11:26 AM, Nikolay Sivov wrote: Get rid of ::get_dataType() forward to IXMLDOMNode interface switch ( This-node-type ) { case XML_ELEMENT_NODE: On of points of such patches is to get rid of such switches. In

Re: [1/4] msxml3: Get rid of ::get_dataType() forward to IXMLDOMNode interface

2010-10-18 Thread Jacek Caban
On 10/18/10 1:57 PM, Nikolay Sivov wrote: On 10/18/2010 15:53, Jacek Caban wrote: Hi Nikolay, On 10/18/10 11:26 AM, Nikolay Sivov wrote: Get rid of ::get_dataType() forward to IXMLDOMNode interface switch ( This-node-type ) { case XML_ELEMENT_NODE: On of points of such

Re: [1/4] msxml3: Get rid of ::get_dataType() forward to IXMLDOMNode interface

2010-10-18 Thread Nikolay Sivov
On 10/18/2010 16:03, Jacek Caban wrote: On 10/18/10 1:57 PM, Nikolay Sivov wrote: On 10/18/2010 15:53, Jacek Caban wrote: Hi Nikolay, On 10/18/10 11:26 AM, Nikolay Sivov wrote: Get rid of ::get_dataType() forward to IXMLDOMNode interface switch ( This-node-type ) {

Re: [1/4]winegstreamer: add wine gstreamer parser filter

2010-10-18 Thread Damjan Jovanovic
On Mon, Oct 18, 2010 at 3:26 PM, Aric Stewart a...@codeweavers.com wrote: ---  dlls/winegstreamer/regsvr.c           |  951 +++ Please consider IRegistrar or inf file based registration instead, regsvr.c is the worst way to support DLL registration, especially if you have to

About: [PATCH 2/2] ntdll: Check for case-insensitive volumes.

2010-10-18 Thread Joris Huizer
Hello, In the proposed patch [PATCH 2/2] ntdll: Check for case-insensitive volumes., I found this piece: +/* Add a new entry */ +for (i = 0; i sizeof(fs_cache)/sizeof(fs_cache[0]); i++) +if (fs_cache[i].dev == 0) +{ +/* This entry is empty, use it */ +

About: msxml3: Partially implement ::setAttributeNode()

2010-10-18 Thread Joris Huizer
Hello, In proposed patch msxml3: Partially implement ::setAttributeNode() I think I found a little possible memory leak: +name = xmlChar_from_wchar(nameW); +value = xmlChar_from_wchar(V_BSTR(valueW)); + +if (!name || !value) +{ +SysFreeString(nameW); +

Re: About: msxml3: Partially implement ::setAttributeNode()

2010-10-18 Thread Nikolay Sivov
On 10/18/2010 18:21, Joris Huizer wrote: Hello, In proposed patch msxml3: Partially implement ::setAttributeNode() I think I found a little possible memory leak: +name = xmlChar_from_wchar(nameW); +value = xmlChar_from_wchar(V_BSTR(valueW)); + +if (!name || !value) +{ +

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes.

2010-10-18 Thread Alexandre Julliard
Charles Davis cda...@mymail.mines.edu writes: @@ -1828,13 +2054,24 @@ static NTSTATUS find_file_in_dir( char *unix_name, int pos, const WCHAR *name, i if (ret = 0 !used_default) { unix_name[pos + ret] = 0; -if (!stat( unix_name, st )) +/* when checking

Re: About: [PATCH 2/2] ntdll: Check for case-insensitive volumes.

2010-10-18 Thread Charles Davis
On 10/18/10 8:10 AM, Joris Huizer wrote: Hello, In the proposed patch [PATCH 2/2] ntdll: Check for case-insensitive volumes., I found this piece: +/* Add a new entry */ +for (i = 0; i sizeof(fs_cache)/sizeof(fs_cache[0]); i++) +if (fs_cache[i].dev == 0) +{ +

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes.

2010-10-18 Thread Charles Davis
On 10/18/10 8:28 AM, Alexandre Julliard wrote: Charles Davis cda...@mymail.mines.edu writes: @@ -1828,13 +2054,24 @@ static NTSTATUS find_file_in_dir( char *unix_name, int pos, const WCHAR *name, i if (ret = 0 !used_default) { unix_name[pos + ret] = 0; -if

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes.

2010-10-18 Thread Alexandre Julliard
Charles Davis cda...@mymail.mines.edu writes: When I wrote that, I was thinking, If we do the stat() on a case-insensitive file system, it will succeed even if the filename has the wrong case. We don't want that when we're checking case, so we may as well read the dirents to see if the file

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes.

2010-10-18 Thread Charles Davis
On 10/18/10 10:57 AM, Alexandre Julliard wrote: Charles Davis cda...@mymail.mines.edu writes: When I wrote that, I was thinking, If we do the stat() on a case-insensitive file system, it will succeed even if the filename has the wrong case. We don't want that when we're checking case, so we

Re: [PATCH 1/8] jscript: Added VBArray stub

2010-10-18 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6279 Your paranoid

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes.

2010-10-18 Thread Alexandre Julliard
Charles Davis cda...@mymail.mines.edu writes: Only if the file system doesn't preserve case. Most modern case-insensitive file systems (FAT, NTFS, HFS) preserve case. CIOPFS preserves case if it's allowed to write xattrs to the underlying FS. This is why I even had the case-preserving

Re: [PATCH 4/8] jscript: Added VBArray.ubound() implementation

2010-10-18 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6282 Your paranoid

Re: [PATCH 1/2] urlmon: Added IInternetProtocolEx support to BindProtocol.

2010-10-18 Thread Alexandre Julliard
Jacek Caban ja...@codeweavers.com writes: --- dlls/urlmon/bindprot.c | 343 +-- 1 files changed, 212 insertions(+), 131 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M gameux.dll -T ../../.. -p gameux_test.exe.so

Re: [PATCH 3/8] jscrpt: Added VBScript.lbound() implementation

2010-10-18 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6281 Your paranoid

Re: [PATCH 2/8] jscript: Implement VBArray constructor

2010-10-18 Thread Jacek Caban
Hi Piotr, +(tmp = new VBArray(createArray())).f = Object.prototype.toString; +ok(tmp.f() === [object Object], tmp.f() = + tmp.f()); We have Function.call implemented now, you can use String.prototype.toString.call(new VBArray ...). +case DISPATCH_METHOD: +if(arg_cnt(dp)1 ||

Re: [PATCH 5/8] jscript: Added VBArray.dimensions() implementation

2010-10-18 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6283 Your paranoid

Re: windowscodecs: Fix *_CopyPixels functions to properly handle a NULL rectangle

2010-10-18 Thread Krzysztof Nowicki
W dniu 17.10.2010 18:49, Vitaliy Margolen pisze: On 10/17/2010 01:59 AM, Krzysztof Nowicki wrote: Doing a memcpy to a local rectangle seems a morenatural way to do it Not really. Doing RECT = RECT is the natural way to do it. Don't use memcpy to copy one structure to another structure of the

Re: [PATCH 1/2] urlmon: Added IInternetProtocolEx support to BindProtocol.

2010-10-18 Thread Jacek Caban
On 10/18/10 8:15 PM, Alexandre Julliard wrote: Jacek Cabanja...@codeweavers.com writes: --- dlls/urlmon/bindprot.c | 343 +-- 1 files changed, 212 insertions(+), 131 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M

Reflection interfaces

2010-10-18 Thread Rico Schüller
Hi, I've a question concerning d3dcompiler, d3d10 and d3dx10 dlls in combination with the shader reflection interfaces. It seems there are 4 different known interfaces: IID_ID3D10ShaderReflection - d3d10.dll (D3D10ReflectShader()) IID_ID3D10ShaderReflection1 - d3dx10_xx.dll

Re: [PATCH 7/8] jscript: Added VBArray.toArray() implementation

2010-10-18 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6285 Your paranoid

Re: windowscodecs: Fix *_CopyPixels functions to properly handle a NULL rectangle

2010-10-18 Thread David Laight
On Mon, Oct 18, 2010 at 08:51:49PM +0200, Krzysztof Nowicki wrote: W dniu 17.10.2010 18:49, Vitaliy Margolen pisze: On 10/17/2010 01:59 AM, Krzysztof Nowicki wrote: Doing a memcpy to a local rectangle seems a morenatural way to do it Not really. Doing RECT = RECT is the natural way to do it.

Re: Translation of the AppDB

2010-10-18 Thread Austin English
On Sun, Oct 17, 2010 at 3:59 AM, Yaron Shahrabani sh.ya...@gmail.com wrote: Is there any way to localize the AppDB? The Israeli community assumes that having a Hebrew system will make more users report issues. It seems unlikely. There are many different languages used by wine's users, and

Apps for Wine on ARM

2010-10-18 Thread Detlef Riekenberg
Here is a free compiler to create apps on ARM: http://www.smorgasbordet.com/pellesc/ (Untested, how this app works in Wine) -- By by ... Detlef

Fwd: Invitation: Apply to be a Mentoring Organization for GCI

2010-10-18 Thread Austin English
I hadn't see any talk about this, so passing this along from Google: -- -Austin -- Forwarded message -- From: Carol Smith car...@google.com Date: Mon, Oct 18, 2010 at 8:10 AM Subject: Invitation: Apply to be a Mentoring Organization for GCI To: Google Summer of Code Mentors List

Re: [PATCH 8/8] jscript: Added VBArray handling to to_object()

2010-10-18 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6286 Your paranoid

Re: [PATCH 6/8] jscript: Added VBArray.getItem() implementation

2010-10-18 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6284 Your paranoid

Re: ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO.

2010-10-18 Thread Mike Kaplinskiy
On Sun, Oct 17, 2010 at 5:51 PM, Erich Hoover ehoo...@mines.edu wrote: On Sat, Oct 16, 2010 at 1:41 PM, Mike Kaplinskiy mike.kaplins...@gmail.com wrote: On Thu, Oct 14, 2010 at 10:08 PM, Erich Hoover ehoo...@mines.edu wrote: ...     DWORD                               flags;     unsigned int

Re: windowscodecs: Fix *_CopyPixels functions to properly handle a NULL rectangle

2010-10-18 Thread Vitaliy Margolen
On 10/18/2010 12:51 PM, Krzysztof Nowicki wrote: Where I come from copying structures directly is considered bad practice and it's safer to use memcpy. We had problems before with broken compilers that would try to do some black magic in such cases. Then don't use broken compilers. GCC handles

Surprise surprise, Tmax Window OS was a complete hoax

2010-10-18 Thread Scott Ritchie
About a year or so ago a Korean company called Tmax was claiming to have developed a new operating system that was 100% fully Windows compatible. They also claimed to have their own office suite, web browser, and more, all developed with their own special Korean engineering to keep the license