Re: shell32/tests: Fix IShellFolderView test failure under Windows 7.

2010-11-08 Thread Austin Lund
On 8 November 2010 17:32, Reece Dunn mscl...@googlemail.com wrote: On 8 November 2010 04:45, Austin Lund austin.l...@gmail.com wrote: On 8 November 2010 11:49, James McKenzie jjmckenzi...@earthlink.net wrote:  Thus a second test case needs to be developed that is only for Windows7 and the

'winetricks dotnet35' starting to work

2010-11-08 Thread Dan Kegel
In svn ( http://winezeug.googlecode.com/svn/trunk/winetricks ), I've added Louis' workaround from http://bugs.winehq.org/show_bug.cgi?id=22551#c5 to winetricks dotnet35. This let the game Bloodline Champions at least show its splash screen. Perhaps it will be useful for other apps, too. With

Re: [PATCH] comctl32/tests: Change expect_band_content test into a macro to ensure line numbers are reported correctly on test failure.

2010-11-08 Thread Nikolay Sivov
On 11/8/2010 13:29, Austin Lund wrote: --- dlls/comctl32/tests/rebar.c | 69 -- 1 files changed, 33 insertions(+), 36 deletions(-) It's better to use ok_() for that, and a one line macro to pass a line number.

Re: [PATCH 4/4] mshtml: Moved tid declaration to separated file.

2010-11-08 Thread Alexandre Julliard
Jacek Caban ja...@codeweavers.com writes: Doing define/include tricks isn't perfect solution, but the current state is even worse. --- dlls/mshtml/dispex.c | 93 ++--- dlls/mshtml/mshtml_private.h | 94 ++---

Re: Where in the code does wine read fonts?

2010-11-08 Thread Maarten Lankhorst
Hi Per, On 04-11-10 14:38, Per Olesen wrote: Hi! I am trying to figure out how wine reads fonts on startup but am having a little trouble. I checked out the source and found a lot of good stuff in winex11.drv/xfont.c, but I am not sure this is actually the code, that gets executed when my

Re: [PATCH] wined3d: correctly guess_card_vendor() for gallium r600 drivers

2010-11-08 Thread Henri Verbeet
On 8 November 2010 05:52, Brian Paterni bpate...@gmail.com wrote: Indeed, I was wondering about that... Also, I realized after submitting my previous email that checking for X.Org in gl_vendor_string is probably unnecessary as well, so I removed that portion from the following: Couple of

Re: [PATCH 1/4] mshtml: Don't free string that will be cleared by SafeArrayDestroy.

2010-11-08 Thread Michael Stefaniuc
Hello Jacek, Jacek Caban wrote: --- dlls/mshtml/tests/dom.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) in that case str becomes unused and can be removed like in the attached patch. bye michael diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index

Re: [PATCH 4/8] d3dcompiler: Add initial reflection parsing.

2010-11-08 Thread Henri Verbeet
2010/11/7 Rico Schüller kgbric...@web.de: +hr = d3dcompiler_parse_reflection(data, data_size, riid, object); +if (FAILED(hr)) +{ +WARN(Failed to parse shader reflection\n); +IUnknown_Release((IUnknown *)object); +return hr; +} You might as well create

Re: [PATCH 1/8] d3dcompiler: Add ID3D11ShaderReflectionType stub interface.

2010-11-08 Thread Henri Verbeet
2010/11/7 Rico Schüller kgbric...@web.de: ---  dlls/d3dcompiler_43/d3dcompiler_private.h |    7 ++  dlls/d3dcompiler_43/reflection.c          |  106 +  2 files changed, 113 insertions(+), 0 deletions(-) You're adding dead code. Also, I expect there to be no reason

Re: [PATCH 3/5] ddraw: Setup the device window in SetCooperativeLevel().

2010-11-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6885 Your paranoid

Re: [PATCH 4/4] mshtml: Moved tid declaration to separated file.

2010-11-08 Thread Jacek Caban
On 11/8/10 11:34 AM, Alexandre Julliard wrote: Jacek Cabanja...@codeweavers.com writes: Doing define/include tricks isn't perfect solution, but the current state is even worse. --- dlls/mshtml/dispex.c | 93 ++--- dlls/mshtml/mshtml_private.h |

Re: [PATCH 1/4] mshtml: Don't free string that will be cleared by SafeArrayDestroy.

2010-11-08 Thread Jacek Caban
Hi Michael, On 11/8/10 12:04 PM, Michael Stefaniuc wrote: Hello Jacek, Jacek Caban wrote: --- dlls/mshtml/tests/dom.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) in that case str becomes unused and can be removed like in the attached patch. Good catch, thanks. I've resent

Re: [PATCH] comctl32/tests: Change expect_band_content test into a macro to ensure line numbers are reported correctly on test failure.

2010-11-08 Thread Alexandre Julliard
Austin Lund austin.l...@gmail.com writes: +#define expect_band_content(hRebar, uBand, fStylep, clrForep, clrBackp, \ + lpTextp, iImagep, hwndChildp, cxMinChildp, cyMinChildp, cxp, hbmBackp, \ + wIDp, cyChildp, cyMaxChildp, cyIntegralp, cxIdealp, lParamp, cxHeaderp, cxHeader_brokenp) \ +{ \

Re: 'winetricks dotnet35' starting to work

2010-11-08 Thread Edward Savage
On 08/11/2010, at 21:08, Dan Kegel d...@kegel.com wrote: In svn ( http://winezeug.googlecode.com/svn/trunk/winetricks ), I've added Louis' workaround from http://bugs.winehq.org/show_bug.cgi?id=22551#c5 to winetricks dotnet35. This let the game Bloodline Champions at least show its splash

Re:

2010-11-08 Thread Scott Ritchie
On 11/07/2010 02:06 PM, Greg Geldorp wrote: From: Eric Pouech how come I got two different test results for the same patch ? moreover one is perfectly ok, while the other shows strange results any idea ? Yeah, that's a bit weird. The only thing I can think of is some kind of timing issue,

Re: winegcc: Add Macho-o lib detection support

2010-11-08 Thread Charles Davis
On 11/8/10 10:52 AM, André Hentschel wrote: @@ -321,7 +321,8 @@ static int check_platform( struct options *opts, const char *file ) unsigned char header[16]; if (read( fd, header, sizeof(header) ) == sizeof(header)) { -/* FIXME: only ELF is supported,

Re: winegcc: Add Macho-o lib detection support

2010-11-08 Thread André Hentschel
Am 08.11.2010 19:27, schrieb Charles Davis: On 11/8/10 10:52 AM, André Hentschel wrote: @@ -321,7 +321,8 @@ static int check_platform( struct options *opts, const char *file ) unsigned char header[16]; if (read( fd, header, sizeof(header) ) == sizeof(header)) { -

wine cannot handle fc-cache (64bit) but fc-cache32 is okay

2010-11-08 Thread Per Olesen
Hi Is it as-it-should-be, that wine only handles 32bit fc-cache? Is it known, that executing the 64bit version /usr/sbin/fc-cache will make the font-cache fail for wine, hence making wine *very* slow to startup? Rebuilding the cache with fc-cache32 makes wine start quickly again. It seems that

Re:

2010-11-08 Thread Eric Pouech
Le 07/11/2010 23:06, Greg Geldorp a écrit : From: Eric Pouech how come I got two different test results for the same patch ? moreover one is perfectly ok, while the other shows strange results any idea ? Yeah, that's a bit weird. The only thing I can think of is some kind of timing issue, but

Re: [PATCH 10/14] [Msvcrt*]: implemented _vc(w)printf

2010-11-08 Thread David Laight
On Wed, Nov 03, 2010 at 10:53:55AM +0100, Alexandre Julliard wrote: Eric Pouech eric.pou...@orange.fr writes: +int CDECL _vcprintf(const char* format, __ms_va_list xvalist) { char buf[2048], *mem = buf; int written, resize = sizeof(buf), retval; - __ms_va_list valist; +