Re: [PATCH] [Msvcrt]: now using macro for parameters validation itoa_s (and updated the tests as well)

2010-11-09 Thread Eric Pouech
to sum up the recent discrepencies between msvcrt and msvcrN0 Dlls: - msvcrt doesn't raise exception on _s functions while msvcrN0 does - (likely) in _s functions returning an errno_t value, msvcrt does set errno to the returned value, while msvcrN0 doesn't change the errno value (tested on

Re: [PATCH 10/14] [Msvcrt*]: implemented _vc(w)printf

2010-11-09 Thread Eric Pouech
va_copy only exists in C99 wine requires C89 only A+ 2010/11/8 David Laight da...@l8s.co.uk On Wed, Nov 03, 2010 at 10:53:55AM +0100, Alexandre Julliard wrote: Eric Pouech eric.pou...@orange.fr writes: +int CDECL _vcprintf(const char* format, __ms_va_list xvalist) { char

Re: (try 2)[PATCH 1/4] d3dcompiler: Add initial reflection parsing.

2010-11-09 Thread Henri Verbeet
2010/11/8 Rico Schüller kgbric...@web.de: -object-vtbl = d3dcompiler_shader_reflection_vtbl; -object-refcount = 1; +hr = d3dcompiler_shader_reflection_init(object, data, data_size, riid); +if (FAILED(hr)) +{ +WARN(Failed to initialize shader reflection\n); +

Re: gdi32: Remove broken check for WinXP.

2010-11-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6910 Your paranoid

Re: (try 2)[PATCH 1/4] d3dcompiler: Add initial reflection parsing.

2010-11-09 Thread Rico Schüller
Am 09.11.2010 12:01, schrieb Henri Verbeet: 2010/11/8 Rico Schüllerkgbric...@web.de: -object-vtbl =d3dcompiler_shader_reflection_vtbl; -object-refcount = 1; +hr = d3dcompiler_shader_reflection_init(object, data, data_size, riid); +if (FAILED(hr)) +{ +WARN(Failed

Re: (try 2)[PATCH 1/4] d3dcompiler: Add initial reflection parsing.

2010-11-09 Thread Henri Verbeet
2010/11/9 Rico Schüller kgbric...@web.de: I made the assumption, because setting the vtbl is the first thing d3dcompiler_shader_reflection_init() does. It is, but you're not supposed to care. Abstractions aren't very useful if you have to care about the details of their internals. Well, a heap

AUTHORS list and the C locale on Mac OS X

2010-11-09 Thread Charles Davis
Hi, There may be a problem with the way the authors.c file is generated on a Mac with GNU sed installed. On Mac OS X, the C locale's default encoding is MacRoman, not UTF-8. This has some pretty surprising consequences. For example, since the AUTHORS file contains UTF-8 multibyte sequences that

Re: AUTHORS list and the C locale on Mac OS X

2010-11-09 Thread James Mckenzie
Charles Davis cda...@mymail.mines.edu wrote: Hi, There may be a problem with the way the authors.c file is generated on a Mac with GNU sed installed. On Mac OS X, the C locale's default encoding is MacRoman, not UTF-8. This has some pretty surprising consequences. For example, since the AUTHORS

Re: AUTHORS list and the C locale on Mac OS X

2010-11-09 Thread Charles Davis
On 11/9/10 12:13 PM, James Mckenzie wrote: No, it is not a bug in GNU sed. The authors.c file needs to have the erroneous characters for the language used by MacOSX changed to be acceptable? That ain't gonna fly. I think we should explicitly use a UTF-8 locale (like en_US.UTF-8 or some such)

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (try 6

2010-11-09 Thread Charles Davis
What's wrong now? Chip

Re: (try 2)[PATCH 1/4] d3dcompiler: Add initial reflection parsing.

2010-11-09 Thread Rico Schüller
Am 09.11.2010 18:39, schrieb Henri Verbeet: 2010/11/9 Rico Schüllerkgbric...@web.de: I made the assumption, because setting the vtbl is the first thing d3dcompiler_shader_reflection_init() does. It is, but you're not supposed to care. Abstractions aren't very useful if you have to

Re: AUTHORS list and the C locale on Mac OS X

2010-11-09 Thread James Mckenzie
Charles Davis cda...@mymail.mines.edu wrote: On 11/9/10 12:13 PM, James Mckenzie wrote: No, it is not a bug in GNU sed. The authors.c file needs to have the erroneous characters for the language used by MacOSX changed to be acceptable? That ain't gonna fly. I think we should explicitly use a

Re: msvcrt: Fixed (_w)fopen_s always fails.

2010-11-09 Thread Austin English
On Tue, Nov 9, 2010 at 9:38 PM, Eryk Wieliczko ewde...@gmail.com wrote: (_w)fopen_s were always failing due to regression introduced in commit 00f07046c0be658d97c47f69e1b4c518bc06b3a2 ---  dlls/msvcrt/file.c |    4 ++--  1 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: AUTHORS list and the C locale on Mac OS X

2010-11-09 Thread Charles Davis
On 11/9/10 1:58 PM, James Mckenzie wrote: Charles Davis cda...@mymail.mines.edu wrote: On 11/9/10 12:13 PM, James Mckenzie wrote: No, it is not a bug in GNU sed. The authors.c file needs to have the erroneous characters for the language used by MacOSX changed to be acceptable? That ain't

Re: AUTHORS list and the C locale on Mac OS X

2010-11-09 Thread Reece Dunn
On 9 November 2010 22:13, Charles Davis cda...@mymail.mines.edu wrote: On 11/9/10 1:58 PM, James Mckenzie wrote: Charles Davis cda...@mymail.mines.edu wrote: On 11/9/10 12:13 PM, James Mckenzie wrote: No, it is not a bug in GNU sed.  The authors.c file needs to have the erroneous characters

Re: krnl386.exe: Mention dosemu

2010-11-09 Thread Charles Davis
On 11/9/10 4:20 PM, André Hentschel wrote: @@ -643,7 +643,7 @@ static DWORD WINAPI MZ_DOSVM( LPVOID lpExtra ) if (GetLastError() == ERROR_NOT_SUPPORTED) MESSAGE( wine: Cannot start DOS application %s\n - because vm86 mode is not supported on this

Re: msvcrt: Fixed (_w)fopen_s with test. (try 2)

2010-11-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6922 Your paranoid

GetSystemPaletteEntries() patch

2010-11-09 Thread Eric Durbin
What was wrong with the patch sent in this post? http://article.gmane.org/gmane.comp.emulators.wine.devel/54403%29

Re: AUTHORS list and the C locale on Mac OS X

2010-11-09 Thread James McKenzie
On 11/9/10 3:29 PM, Reece Dunn wrote: On 9 November 2010 22:13, Charles Daviscda...@mymail.mines.edu wrote: On 11/9/10 1:58 PM, James Mckenzie wrote: Charles Daviscda...@mymail.mines.edu wrote: On 11/9/10 12:13 PM, James Mckenzie wrote: No, it is not a bug in GNU sed. The authors.c file

Re: AUTHORS list and the C locale on Mac OS X

2010-11-09 Thread Charles Davis
On 11/9/10 7:58 PM, James McKenzie wrote: On 11/9/10 3:29 PM, Reece Dunn wrote: On 9 November 2010 22:13, Charles Daviscda...@mymail.mines.edu wrote: On 11/9/10 1:58 PM, James Mckenzie wrote: Charles Daviscda...@mymail.mines.edu wrote: On 11/9/10 12:13 PM, James Mckenzie wrote: No, it is

Re: AUTHORS list and the C locale on Mac OS X

2010-11-09 Thread James McKenzie
On 11/9/10 8:02 PM, Charles Davis wrote: On 11/9/10 7:58 PM, James McKenzie wrote: On 11/9/10 3:29 PM, Reece Dunn wrote: On 9 November 2010 22:13, Charles Daviscda...@mymail.mines.edu wrote: On 11/9/10 1:58 PM, James Mckenzie wrote: Charles Daviscda...@mymail.mines.edu wrote: On 11/9/10

Re: msvcrt: Fixed (_w)fopen_s with test. (try 2)

2010-11-09 Thread Dmitry Timoshkov
Eryk Wieliczko ewde...@gmail.com wrote: +if (!p_fopen_s) +{ +win_skip(Skipping fopen_s test\n); +return; +} +else +{ +/* testing fopen_s */ +ret = p_fopen_s(file, name, w); +ok(ret == 0, fopen_s failed with %d\n, ret); +