Re: ntdll/cdrom : implement CDROM_Verify to work on Mac Os

2010-12-30 Thread Ken Thomases
Hi Loïc, On Dec 30, 2010, at 4:20 AM, maury loïc wrote: it's my first patch, and it implement the CDROM_Verify() to work on Mac Os. I think most people are going to need more explanation for why this is a legitimate way to implement this function on Mac OS X. :) Cheers, Ken

[PATCH] JanitorialProjects/ReplaceMalloc: remove malloc and free from dlls folder

2010-12-30 Thread Yegor Yefremov
Hello, it's my first contribution to wine, so I wanted to start with some simple task. After fixing the files mentioned in the attached patch, following files in dlls folder still contain malloc/free calls: dlls/ntdll/server.c:if (!(tmp_dir = malloc( p + 1 - config_dir )))

Re: [PATCH] JanitorialProjects/ReplaceMalloc: remove malloc and free from dlls folder

2010-12-30 Thread James McKenzie
On 12/30/10 5:02 AM, Yegor Yefremov wrote: Hello, it's my first contribution to wine, so I wanted to start with some simple task. After fixing the files mentioned in the attached patch, following files in dlls folder still contain malloc/free calls: dlls/ntdll/server.c:if

Re: 64-bit Notepad2 crashes

2010-12-30 Thread Susan Cragin
ELF 7f3aa090b000-7f3aa0c3d000 Export libwine.so.1 if you've compiled wine yourself, it's strange that libwine.so doesn't contain any dwarf information maybe you're loading another instance of libwine? A+ -- Eric Pouech I did a search of the file system. Under

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac Os

2010-12-30 Thread maury loïc
Hello Ken and the Wine community, For what i understood, The function CDROM_Verify(), verify if the media is present on the device, and Wine try to open the device(in Mac Os case), before call the CDROM_Verify(). But Mac Os manage the device differently from the other Os. It create the device,

Re: 64-bit Notepad2 crashes

2010-12-30 Thread Marcus Meissner
On Thu, Dec 30, 2010 at 07:22:31AM -0500, Susan Cragin wrote: ELF7f3aa090b000-7f3aa0c3d000 Export libwine.so.1 if you've compiled wine yourself, it's strange that libwine.so doesn't contain any dwarf information maybe you're loading another instance of

Re: 64-bit Notepad2 crashes

2010-12-30 Thread Susan Cragin
On Thu, Dec 30, 2010 at 07:22:31AM -0500, Susan Cragin wrote: ELF 7f3aa090b000-7f3aa0c3d000 Export libwine.so.1 if you've compiled wine yourself, it's strange that libwine.so doesn't contain any dwarf information maybe you're loading another instance of

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac Os

2010-12-30 Thread James Mckenzie
maury loïc lma...@gmail.com wrote: Hello Ken and the Wine community, Please bottom post or post directly to a question. Please do not top post. On Thu, Dec 30, 2010 at 12:51 PM, Ken Thomases k...@codeweavers.com wrote: Hi Loïc, On Dec 30, 2010, at 4:20 AM, maury loïc wrote: it's my

Re: 64-bit Notepad2 crashes

2010-12-30 Thread James Mckenzie
Susan Cragin susancra...@earthlink.net wrote: Sent: Dec 30, 2010 8:30 AM To: Marcus Meissner mar...@jet.franken.de Cc: Wine Developers wine-devel@winehq.org, Eric Pouech eric.pou...@orange.fr Subject: Re: 64-bit Notepad2 crashes On Thu, Dec 30, 2010 at 07:22:31AM -0500, Susan Cragin wrote: ELF

Re: 64-bit Notepad2 crashes

2010-12-30 Thread Susan Cragin
-Original Message- From: James Mckenzie jjmckenzi...@earthlink.net Sent: Dec 30, 2010 10:38 AM To: Susan Cragin susancra...@earthlink.net, Marcus Meissner mar...@jet.franken.de Cc: Wine Developers wine-devel@winehq.org, Eric Pouech eric.pou...@orange.fr Subject: Re: 64-bit Notepad2

Re: kernel32/tests: Skip some debugger tests on 64-bit

2010-12-30 Thread Jacek Caban
On 12/30/10 4:31 PM, Greg Geldorp wrote: I get very different results for the kernel32:debugger tests depending on which compiler I use. With VS2008, the test runs fine. With mingw64 4.4.1-1a (used by the TestBot build VM), the child process that's supposed to crash keeps running, re-executing

re: JanitorialProjects/ReplaceMalloc: remove malloc and free from dlls folder

2010-12-30 Thread Dan Kegel
Yegor wrote: it's my first contribution to wine... Welcome! so I wanted to start with some simple task. Changing memory allocation might not be simple. Your patch touches two different DLLs. You should probably split this patch up, one patch per dll. Also, the fact that your change to

Re: 64-bit Notepad2 crashes

2010-12-30 Thread Susan Cragin
On Thu, Dec 30, 2010 at 07:22:31AM -0500, Susan Cragin wrote: ELF7f3aa090b000-7f3aa0c3d000 Export libwine.so.1 if you've compiled wine yourself, it's strange that libwine.so doesn't contain any dwarf information maybe you're loading another instance of libwine?

Re: 64-bit Notepad2 crashes

2010-12-30 Thread Susan Cragin
IGNORE MY LAST POST. I'm away from home and don't have my glasses with me. Wine build complete. su...@ubuntu:~/wine$ wine checkinstall wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory

Re: wininet/tests: Don't call GetLastError() twice

2010-12-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7966 Your paranoid

Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite

2010-12-30 Thread Vitaliy Margolen
On 12/30/2010 12:23 PM, Travis Athougies wrote: Tests to ensure the HLSL compiler won't crash on malformed input. You still haven't fixed strings spanning multiple lines. Please send a patch that fixes all incorrect strings first. Then continue on with the correct style. Adding more invalid

Re: imagehlp/tests: Don't test function directly when reporting GetLastError()

2010-12-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7970 Your paranoid

Re: mscms/tests: Fix test message

2010-12-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7968 Your paranoid

Re: riched32/tests: Don't test function directly when reporting GetLastError()

2010-12-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7969 Your paranoid

Re: gdi32/tests: Don't test function directly when reporting GetLastError()

2010-12-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7979 Your paranoid

Re: oledb32: Use correct 32/64-bit typedefs

2010-12-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7981 Your paranoid

Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite

2010-12-30 Thread James McKenzie
On 12/30/10 12:48 PM, Vitaliy Margolen wrote: On 12/30/2010 12:23 PM, Travis Athougies wrote: Tests to ensure the HLSL compiler won't crash on malformed input. You still haven't fixed strings spanning multiple lines. Please send a patch that fixes all incorrect strings first. Then continue on

Re: 64-bit Notepad2 crashes

2010-12-30 Thread Susan Cragin
Does this 'path' exist in LD_LIBRARY_PATH or equivilent? Otherwise ld might not be able to 'find' it when starting the program. James McKenzie James... You've just exhausted my technical knowledge. How do I do / find that? Susan: For the BASH shell: Type in set and look for the