Re: Improve handling of invalid input in dlls/comctl32/datetime.c

2011-01-19 Thread Gerald Pfeifer
For the record, this is how this has been addressed a few months after this discussion. That's another way of doing it. :-) Gerald commit 1af17844301c4924dd8324cbf2f9c3c1ef0394b2 Author: Huw Davies Date: Tue May 4 14:05:13 2010 +0100 comctl32: Silence a few compiler warnings. diff --g

Re: today's git does not compile

2011-01-19 Thread Dan Kegel
Nicely done! Thanks for taking the time to do the full-on gcc bug report with .i file. If at some point in the future you want to ascend to the next level of gcc bug reporting awesomeness, read up on delta debugging, an easy technique for automatically reducing the .i file to (nearly) the smalles

Re: setupapi.dll: Call from 0x7b839292 to unimplemented function setupapi.dll.CM_Get_DevNode_Status (Crashing while running a USB production tool)

2011-01-19 Thread Austin English
On Wed, Jan 19, 2011 at 1:00 PM, James McKenzie wrote: > On 1/19/11 12:52 PM, Qian Hong wrote: >> >> On Thu, Jan 20, 2011 at 3:15 AM, Ricardo Filipe >>  wrote: >>> >>> That should only need a stub to go forward (setupapi is already full of >>> them). >>> If you are not able to patch wine with a s

Re: setupapi.dll: Call from 0x7b839292 to unimplemented function setupapi.dll.CM_Get_DevNode_Status (Crashing while running a USB production tool)

2011-01-19 Thread James McKenzie
On 1/19/11 12:52 PM, Qian Hong wrote: On Thu, Jan 20, 2011 at 3:15 AM, Ricardo Filipe wrote: That should only need a stub to go forward (setupapi is already full of them). If you are not able to patch wine with a stub of that function then yeah, open a bug report. Thanks for reply :) Reported

Re: [PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.

2011-01-19 Thread Erich Hoover
On Wed, Jan 19, 2011 at 1:05 PM, Jacek Caban wrote: > On 1/18/11 7:31 PM, Erich Hoover wrote: > >   I've attached a test where I disabled the client/container, and you > > can see that it then gets passed through (QueryStatusWB will return > success instead of passing through the client target and

Re: [PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.

2011-01-19 Thread Jacek Caban
On 1/18/11 7:31 PM, Erich Hoover wrote: > On Tue, Jan 18, 2011 at 3:08 AM, Jacek Caban mailto:ja...@codeweavers.com>> wrote: > ... > I'm not sure what you mean by "hijack the IOleCommandTarget". All we do is implementing client's IOleCommandTarget. It's something different from document's o

Re: setupapi.dll: Call from 0x7b839292 to unimplemented function setupapi.dll.CM_Get_DevNode_Status (Crashing while running a USB production tool)

2011-01-19 Thread Qian Hong
Thanks for reply :) Reported here : http://goo.gl/FHely On Thu, Jan 20, 2011 at 3:15 AM, Ricardo Filipe wrote: > > That should only need a stub to go forward (setupapi is already full of > them). > If you are not able to patch wine with a stub of that function then yeah, > open a bug report.

re: today's git does not compile

2011-01-19 Thread Susan Cragin
https://bugs.launchpad.net/ubuntu/+source/gcc-4.5/+bug/704633 Bug successfully updated and confirmed by a member of Ubuntu's testing team, so we're off to the races.

Re: setupapi.dll: Call from 0x7b839292 to unimplemented function setupapi.dll.CM_Get_DevNode_Status (Crashing while running a USB production tool)

2011-01-19 Thread Ricardo Filipe
2011/1/19 Qian Hong > Dear All, while testing a USB production tool with unofficial USB > patches + native oleaut32.dll, > I got a crashing and such logs: > > wine: Call from 0x7b839292 to unimplemented function > setupapi.dll.CM_Get_DevNode_Status, aborting > wine: Unimplemented function setupap

setupapi.dll: Call from 0x7b839292 to unimplemented function setupapi.dll.CM_Get_DevNode_Status (Crashing while running a USB production tool)

2011-01-19 Thread Qian Hong
Dear All, while testing a USB production tool with unofficial USB patches + native oleaut32.dll, I got a crashing and such logs: wine: Call from 0x7b839292 to unimplemented function setupapi.dll.CM_Get_DevNode_Status, aborting wine: Unimplemented function setupapi.dll.CM_Get_DevNode_Status called

kernel32: Correctly parse the input strings for advanced keys.

2011-01-19 Thread James Eder
On systems without the appropriate curses development files, compilation is broken here: gcc -m32 -c -I/home/james/build/wine/wine-git/dlls/kernel32 -I. -I/home/james/build/wine/wine-git/include -I../../include -D__WINESRC__ -D_KERNEL32_ -D_NORMALIZE_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-ali

Re: Fail to use USB-Key/USB-Shield with wine USB patch :cannot start service 'SCardSvr':win error code:0x00000424

2011-01-19 Thread Qian Hong
On Mon, Jan 17, 2011 at 9:10 PM, Saulius Krasuckas wrote: > You should open new bug for this, I guess. > Just filed an issue: http://bugs.winehq.org/show_bug.cgi?id=25784 > Well, IIRC the USB patch you mentioned isn't officially supported by Wine > (for now), so you could ask it's author Alexa

FYI: GCC-4.6 rebuild tests

2011-01-19 Thread Susan Cragin
GCC-4.6 has more build failures than mine. Here's the info. They don't test wine, apparently. It's not on the list. Maybe I can add it, or get it added. -Forwarded Message- >From: Matthias Klose >Sent: Jan 19, 2011 10:28 AM >To: ubuntu-devel , ubuntu-devel > >Subject: GCC-4.6 rebuild

Translating a same message used in different contexts

2011-01-19 Thread Akihiro Sagawa
Hi, I'm one of Japanese translators of Wine. A few weeks ago, Wine's string resources were moved to one po format file. So I started translation about it. And now I face to a problem which is a same msgid text used in different contexts, like "Desktop" used in shell32.rc. One of its contexts is a

Re: today's git does not compile

2011-01-19 Thread Dan Kegel
On Wed, Jan 19, 2011 at 4:46 AM, Reece Dunn wrote: > You need to run it with the command line given in your output in the > directory where it was run. That is: > >   cd /home/susan/wine/dlls/winex11.drv > >   gcc -save-temps -m32 -c -I. -I. -I../../include -I../../include > -D__WINESRC__  -D_REEN

Re: [PATCH 3/3] dinput: Combine ASCII and Unicode device create callbacks. Add tests.

2011-01-19 Thread Vitaliy Margolen
On 01/18/2011 09:22 PM, Marvin wrote: === WNT4WSSP6 (32 bit device) === device.c:164: Test failed: DirectInputCreate() failed: 80040154 Yup, NT 4.0 doesn't have DirectX 7. Let me change that part a bit to not use CreateDeviceEx which only available in DX 7. Vitaliy.

Re: today's git does not compile

2011-01-19 Thread Reece Dunn
On 19 January 2011 12:41, Susan Cragin wrote: > Dan, I can't work the -save-temps option. All three give me "no input files." > /wine-git$ gcc -save-temps > /wine-git$ gcc -save-temps=cwd (or =obj) > gcc: no input files You need to run it with the command line given in your output in the director

re: today's git does not compile

2011-01-19 Thread Susan Cragin
>Try switching from -O2 to -O1 with > configure CFLAGS="-g -O1" >and rebuild. Does that help? Yes. That works. >Regardless of whether that gets you past the problem, >please file a bug in launchpad against gcc-4.5. >Ideally they'd want you to run with -save-temps and give >them a copy of pen.i

Re: [PATCH 4/4] [Kernel32]: add ability to load additional terminfo data from Wine registry

2011-01-19 Thread Alexandre Julliard
Eric Pouech writes: > @@ -690,6 +690,9 @@ HKLM,SOFTWARE\Microsoft\Active Setup\Installed > Components\{de5aed00-a4bf-11d1-99 > HKLM,SOFTWARE\Microsoft\Active Setup\Installed > Components\{de5aed00-a4bf-11d1-9948-00c04f98bbc9},"IsInstalled",2,1 > HKLM,SOFTWARE\Microsoft\Active Setup\Installed

Re: [PATCH] [WineGCC]: correctly manage the -V option (gcc expects to be among the first ones, with -b)

2011-01-19 Thread Alexandre Julliard
Eric Pouech writes: > @@ -969,7 +972,7 @@ static void build(struct options* opts) > if (fake_module) return; /* nothing else to do */ > > /* link everything together now */ > -strarray_addall(link_args, get_translator(opts)); > +strarray_addall(link_args, get_translator(opts,

Re: oleaut32/tmarshal: Remove S_OK value assumptions, fix potential stream leak

2011-01-19 Thread Alexandre Julliard
Nikolay Sivov writes: > Remove S_OK value assumptions, fix potential stream leak Returning an error value and 0 on success is a common pattern, using a magic constant for 0 is not an improvement. -- Alexandre Julliard julli...@winehq.org

Re: [10/10] shell32: Fix initial reference count for a new IAutoComplete instance.

2011-01-19 Thread Nikolay Sivov
On 1/15/2011 11:28, Andrew Nguyen wrote: Spotted with Valgrind. --- dlls/shell32/autocomplete.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(- This doesn't look right. If initial count is zero this failure code will decrement to -1: --- if (FAILED (IUnknown_QueryInterface (_