Re: server: fix connect failures on newer kernels

2011-01-24 Thread Marcus Meissner
On Mon, Jan 24, 2011 at 12:21:15AM -0500, Mike Kaplinskiy wrote: For some reason the newer kernels report POLLOUT|POLLERR|POLLHUP when connect() fails. Strip the POLLOUT in this case. This (hopefully) fixes bug 25456. diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c index

Re: server: fix connect failures on newer kernels

2011-01-24 Thread Dmitry Timoshkov
Marcus Meissner mar...@jet.franken.de wrote: diff --git a/server/sock.c b/server/sock.c index d37a316..134efb0 100644 --- a/server/sock.c +++ b/server/sock.c @@ -388,6 +388,9 @@ static void sock_poll_event( struct fd *fd, int event ) if (sock-state FD_CONNECT) { +

Re: oleaut32/typelib2: Use implementation pointer to trace ICreateTypeInfo2

2011-01-24 Thread Michael Stefaniuc
Hello Nikolay, On 01/24/2011 01:01 AM, Nikolay Sivov wrote: Use implementation pointer to trace ICreateTypeInfo2 diff --git a/dlls/oleaut32/typelib2.c b/dlls/oleaut32/typelib2.c index 8260ef2..5c843a1 100644 --- a/dlls/oleaut32/typelib2.c +++ b/dlls/oleaut32/typelib2.c @@ -2322,6 +2321,7

Questioning the depth_clamp_test in d3d8:visual

2011-01-24 Thread Joerg-Cyril.Hoehle
Hi, Trying to understand bugs #10636 and #19773 , I glanced at the d3d8 visual.ok directx test results. It appears that the green colour on test.winehq does not mean much. - All (any exception?) WTB machines skip the tests because d3d8 is not installed. - Same for Francois Gouget's virtual

Re: Questioning the depth_clamp_test in d3d8:visual

2011-01-24 Thread Henri Verbeet
On 24 January 2011 13:02, joerg-cyril.hoe...@t-systems.com wrote: My conclusion: the tests only prove that Wine wants to mimic Intel graphics, but they do not account for the variety of observed test results. The issue is more subtle than that.

Re: Questioning the depth_clamp_test in d3d8:visual

2011-01-24 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 24.01.2011 um 13:02 schrieb joerg-cyril.hoe...@t-systems.com joerg-cyril.hoe...@t-systems.com: - Wylda's Intel-based machine #2 passes the tests. Hurray! - One unknown win7 machine with Intel gfx also passes them. - Aurimas' machine produces

Re: [PATCH] To: wine-patc...@winehq.org

2011-01-24 Thread Alexandre Julliard
Eric Pouech eric.pou...@orange.fr writes: [Kernel32]: in bare console with curses, ensure control stream is sent to tty (even when some fd:s are redirected) There doesn't seem to be much point in initializing input if we can't see the output. On the contrary, I think we should err on the side

Re: gdi32: Prevent character code from wrapping around.

2011-01-24 Thread Alexandre Julliard
Kusanagi Kouichi sl...@ac.auone-net.jp writes: If lastChar is 0x, FONT_GetCharsByRangeA falls into infinite loop and crash. You probably want more sanity checks (with tests), characters above 0x wouldn't make sense anyway. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.

2011-01-24 Thread Erich Hoover
On Sun, Jan 23, 2011 at 11:32 AM, Jacek Caban ja...@codeweavers.com wrote: On 1/20/11 6:40 PM, Erich Hoover wrote: On Thu, Jan 20, 2011 at 4:00 AM, Jacek Cabanja...@codeweavers.com  wrote: +    ok(status   success_flag, OLECMDID_STOP not enabled/supported: %08x\n, status); You could test the

Re: oleaut32/typelib2: Use implementation pointer to trace ICreateTypeInfo2

2011-01-24 Thread Nikolay Sivov
On 1/24/2011 12:38, Michael Stefaniuc wrote: Hello Nikolay, On 01/24/2011 01:01 AM, Nikolay Sivov wrote: Use implementation pointer to trace ICreateTypeInfo2 diff --git a/dlls/oleaut32/typelib2.c b/dlls/oleaut32/typelib2.c index 8260ef2..5c843a1 100644 --- a/dlls/oleaut32/typelib2.c +++

Static analysis scan

2011-01-24 Thread Amine Khaldi
Hello folks, I've set up a static analysis scan using clang static analyzer. The results are available at http://austinenglish.com/logs/clang_analyzer/index.html thanks to Austin for the web space. Please feel free to fix the defects. I'll run future scans when the defects get fixed

Re: Static analysis scan

2011-01-24 Thread Juan Lang
Hi Amine, I've set up a static analysis scan using clang static analyzer. The results are available at http://austinenglish.com/logs/clang_analyzer/index.html thanks to Austin for the web space. Please feel free to fix the defects. I'll run future scans when the defects get fixed

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 3)

2011-01-24 Thread Ken Thomases
Loïc, Your mailer seems to have mangled your patch with line wrapping. There are some suggestions on Wine's SubmittingPatches wiki page for avoiding this. Primarily, you should attach the patch to your email. If you already did that, then you may need to use a different mailer. For

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 3)

2011-01-24 Thread Henri Verbeet
On 25 January 2011 00:29, Ken Thomases k...@codeweavers.com wrote: Your mailer seems to have mangled your patch with line wrapping.  There are some suggestions on Wine's SubmittingPatches wiki page for avoiding this.   Primarily, you should attach the patch to your email.  If you already did

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 3)

2011-01-24 Thread Charles Davis
On 1/24/11 4:51 PM, Henri Verbeet wrote: On 25 January 2011 00:29, Ken Thomases k...@codeweavers.com wrote: Your mailer seems to have mangled your patch with line wrapping. There are some suggestions on Wine's SubmittingPatches wiki page for avoiding this. Primarily, you should attach the

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 3)

2011-01-24 Thread Henri Verbeet
On 25 January 2011 01:06, Charles Davis cda...@mymail.mines.edu wrote: Uh, you mean git send-email, right? Right.