On Tue, Feb 1, 2011 at 3:08 AM, Juan Lang juan.l...@gmail.com wrote:
Hi Ken, thanks for the reply.
As Henri said, it's that it's a set of external dependencies (not just
one; GnuTLS has its own dependencies) and that they are security-related.
To the greatest extent practical,
On Tuesday 01 February 2011 09:49:46 am Iain Arnell wrote:
To fix inclusion of gdiplus.h under C++, this patch:
* adds missing class declaration for GpPen
* adds missing class declaration for CharacterRange
* fixes PenAlignment/GpPenAlignment declaration
* avoids redeclaration of PixelFormat
On 1 February 2011 02:08, Juan Lang juan.l...@gmail.com wrote:
Sure, I can buy that. I'll note that OpenSSL is also available for
the Mac, and already loaded by wininet and winhttp. It could be
appropriate to move from GnuTLS to OpenSSL for schannel, so we'd only
have a single implementation
While skimming through the new patches, I found:
+WCHAR *encode_stream( const WCHAR *in )
+{
+ DWORD c, next, count;
+ WCHAR *out, *p;
+
+ count = strlenW( in );
+ if (count MAX_STREAM_NAME)
+ return NULL;
+
+ count += 2;
+ out = HeapAlloc( GetProcessHeap(),
Piotr Caban pi...@codeweavers.com writes:
void InitChangeNotifications(void)
{
+watched_directories = 0;
+interrupts_server_terminate = CreateEventW(NULL, FALSE, FALSE, NULL);
+interrupts_server = CreateThread(NULL, 0, interrupts_server_thread,
NULL, 0, NULL);
}
This needs
On Tue, Feb 1, 2011 at 10:28 AM, Paul Chitescu pa...@voip.null.ro wrote:
On Tuesday 01 February 2011 09:49:46 am Iain Arnell wrote:
To fix inclusion of gdiplus.h under C++, this patch:
* adds missing class declaration for GpPen
* adds missing class declaration for CharacterRange
* fixes
On 2/1/2011 17:14, Paul Vriens wrote:
Hi,
Addresses Coverity #1090.
If CoCreateInstance() fails we check the uninitialized urlfile variable.
Same story with urlobj. In fact it looks better to try CoCreateInstance
first, before anything else like lstrcpy and just return earlier on failure.
Well, I think that regardless of what schannel ends up using, wininet
and winhttp should be implemented on top schannel in the long term,
instead of using OpenSSL directly. I don't think GnuTLS is really the
Well, that's certainly true, as there are features of at least wininet
that can't be
On 02/01/2011 03:26 PM, Nikolay Sivov wrote:
On 2/1/2011 17:14, Paul Vriens wrote:
Hi,
Addresses Coverity #1090.
If CoCreateInstance() fails we check the uninitialized urlfile variable.
Same story with urlobj. In fact it looks better to try CoCreateInstance
first, before anything else like
On 2/1/2011 19:21, Paul Vriens wrote:
On 02/01/2011 03:26 PM, Nikolay Sivov wrote:
On 2/1/2011 17:14, Paul Vriens wrote:
Hi,
Addresses Coverity #1090.
If CoCreateInstance() fails we check the uninitialized urlfile
variable.
Same story with urlobj. In fact it looks better to try
On 1 February 2011 17:19, Juan Lang juan.l...@gmail.com wrote:
what IMO complicates writing them is that only the client part of
schannel is currently implemented.
That might be true for writing tests against Wine's implementation,
but there's nothing to stop them from being skipped if a
Hi Christian, I'm afraid this patch is incorrect. In particular,
-chars = CertRDNValueToStrA(
- rdn-rgRDNAttr[j].dwValueType,
- rdn-rgRDNAttr[j].Value, psz ? psz + ret : NULL,
- psz ? csz - ret : 0);
+if ((dwStrType
It doesn't need a try-except block, just better wrap-around handling.
Ah, you mean to enhance the if-check?
Well..., to me it seems that there is a problem with the 2nd check:
(void *)(frame + 1) = NtCurrentTeb()-Tib.StackBase
If frame is 0x or close to it (e.g.
On Sat, Jan 29, 2011 at 4:36 PM, Vitaliy vita...@kievinfo.com wrote:
On 01/29/2011 12:21 PM, Dan Kegel wrote:
Hi Albert,
http://wiki.winehq.org/FAQ?action=diffrev2=384rev1=383 looks
like it was a pretty big edit.
Try smaller ones, and try to do just one kind of change per edit.
That, and
On 02/01/2011 09:47 PM, Albert Lee wrote:
On Sat, Jan 29, 2011 at 4:36 PM, Vitaliyvita...@kievinfo.com wrote:
-cd ~/.wine/drive_c/Program\ Files
+cd .wine/drive_c/Program\ Files
This will break if current directory is not $HOME.
'cd' immediately precedes this.
That still doesn't make the
Dear Nikolay and James,
On Sun, Jan 30, 2011 at 11:09 PM, James McKenzie
jjmckenzi...@earthlink.net wrote:
Qian:
I would like to echo Nikolay's comment and add one more:
Please search through the Bug Reports before submitting a new one.
I really feel very sorry, I apologize for posting such
16 matches
Mail list logo