Most of the objections from the previous try still stand: check your
whitespaces (whitespace after every comma, whitespaces around
operators, whitespace after if or for keywords), you have to be
consistent. Comparing indices doesn't make much sense now that you
don't check vertices, I think you
Adam Martinson amartin...@codeweavers.com writes:
@@ -239,6 +243,19 @@ extern int getopt_long_only (int ___argc, char *const
*___argv,
int ffs( int x );
#endif
+#if defined(__GNUC__) (GCC_VERSION = 30406)
+#define ctz(x) __builtin_ctz(x)
+#elif defined(__GNUC__)
Adam Martinson amartin...@codeweavers.com writes:
---
dlls/wined3d/device.c | 17 -
1 files changed, 8 insertions(+), 9 deletions(-)
You still need to demonstrate that this is an improvement. Compilers are
pretty good nowadays, and doing such micro-optimizations at the
Hi Thomas,
On 3/16/11 11:21 AM, Thomas Faber wrote:
Hi,
the documentation for the OLEINPLACEFRAMEINFO structure [1] says
that the 'cb' member must be initialized before passing the structure
to IOleInPlaceSite::GetWindowContext (where the rest of it will be
filled).
In addition to the fix, I
On 3/15/11 10:44 PM, Scott Ritchie wrote:
Do you really mean 1.3.15 or do you mean the upcoming 1.3.16?
I meant post-1.3.15, so it's the updcoming 1.3.16, sorry for the confusion.
Jacek
Hi,
Testbot job #9994 proves that Wine and native differ in their handling of a 0
CALLBACK_WINDOW handle.
Wine's PostMessage redirects a 0 handle to PostThreadMessage(currentThreadID()),
while native finds no notification on the thread's queue in such a case.
(As a consequence, Wine's player
Hi,
MSDN is silent about the lifetime of the MIDI/MIXER/WAVEOPENDESC structure
that is deliverred via the W/MODM_OPEN/MXM_OPEN message to the winmm drivers
(WAVEOOPENDESC is not even documented for MS-Windows (not CE) anymore).
http://msdn.microsoft.com/en-us/library/ff537518%28v=vs.85%29.aspx
Hans Leidekker h...@codeweavers.com writes:
+for (i = 0; i output-NumberOfMountPoints; i++)
+{
+if (output-MountPoints[i].DeviceNameOffset)
+{
+const WCHAR *device = (const WCHAR *)((const char *)output +
output-MountPoints[i].DeviceNameOffset);
+
I think this will be needed by d3dx9, though it hasn't been fully wired up yet.
On Wed, Mar 16, 2011 at 3:57 AM, Francois Gouget fgou...@free.fr wrote:
Any reason why we were not freeing glyphmetrics_float?
No reason, just a mistake on my part.
Hey,
Op 16-03-11 16:03, joerg-cyril.hoe...@t-systems.com schreef:
Hi,
MSDN is silent about the lifetime of the MIDI/MIXER/WAVEOPENDESC structure
that is deliverred via the W/MODM_OPEN/MXM_OPEN message to the winmm drivers
(WAVEOOPENDESC is not even documented for MS-Windows (not CE) anymore).
Hey,
Op 16-03-11 15:52, joerg-cyril.hoe...@t-systems.com schreef:
Hi,
Testbot job #9994 proves that Wine and native differ in their handling of a 0
CALLBACK_WINDOW handle.
Wine's PostMessage redirects a 0 handle to PostThreadMessage(currentThreadID()),
while native finds no notification on
Does that work when compiling with -O3 ?
Maybe you need a noinline attribute,
http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html#Function-Attributes
Hi Dan,
Op 16-03-11 20:06, Dan Kegel schreef:
Does that work when compiling with -O3 ?
Maybe you need a noinline attribute,
http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html#Function-Attributes
I don't think it will ever be inlined because of the calling convention
differences.
Adam Martinson amartin...@codeweavers.com writes:
On 03/16/2011 02:24 PM, Alexandre Julliard wrote:
Adam Martinsonamartin...@codeweavers.com writes:
Look at any d3d app with oprofile. That function is called
EVERYWHERE. In my testing this reduces
IWineD3DDeviceImpl_MarkStateDirty() from
Thomas Faber thfa...@gmx.de wrote:
ip_frame = NULL;
ip_uiwindow = NULL;
+frame_info.cb = sizeof(OLEINPLACEFRAMEINFO);
Using sizeof(frame_info) here and in other places instead of
sizeof(OLEINPLACEFRAMEINFO)
would be better IMHO.
--
Dmitry.
16 matches
Mail list logo
