Re: d3dx9_36: Implement D3DXCreateBox

2011-03-27 Thread Andrew Nguyen
On 03/27/2011 04:52 PM, Joshua Beck wrote: > On a side note, you could rearrange this loop to use less multiplications: > +for(i = 0; i< 24; i++) > +{ > +int sixi = 6 * i; > +vertices[sixi] *= width; > +vertices[sixi + 1] *= height; > +vertices[sixi + 2]

Re: ws2_32: return an error in SO_CONNECT_TIME stub

2011-03-27 Thread Dmitry Timoshkov
Austin English wrote: > @@ -2554,7 +2554,7 @@ INT WINAPI WS_getsockopt(SOCKET s, INT level, > } > *(DWORD*)optval = pretendtime++; > *optlen = sizeof(DWORD); > -return ret; > +return SOCKET_ERROR; > } Filling out optval and

Re: d3dx9_36: Implement D3DXCreateBox

2011-03-27 Thread Dmitry Timoshkov
Joshua Beck wrote: > >> Or even better: > >> +for(i = 0; i< 144; i+=4) > >> +{ > >> +vertices[i ] *= width; > >> +vertices[++i] *= height; > >> +vertices[++i] *= depth; > >> +} > >> > > There shouild be i + 1 and i + 2 instead of two ++i otherwise > >

Re: d3dx9_36: Implement D3DXCreateBox

2011-03-27 Thread Joshua Beck
On 03/27/2011 10:58 PM, Dmitry Timoshkov wrote: Joshua Beck wrote: Or even better: +for(i = 0; i< 144; i+=4) +{ +vertices[i ] *= width; +vertices[++i] *= height; +vertices[++i] *= depth; +} There shouild be i + 1 and i + 2 instead of two ++i ot

Re: d3dx9_36: Implement D3DXCreateBox

2011-03-27 Thread Dmitry Timoshkov
Joshua Beck wrote: > Or even better: > +for(i = 0; i< 144; i+=4) > +{ > +vertices[i ] *= width; > +vertices[++i] *= height; > +vertices[++i] *= depth; > +} There shouild be i + 1 and i + 2 instead of two ++i otherwise the loop index gets corrupted. -- Dmit

Re: Summer of Code 2011 ideas

2011-03-27 Thread Jerome Leclanche
On Mon, Mar 28, 2011 at 12:53 AM, Charles Davis wrote: > 2. D3D10 support. Here's an idea that isn't tied to Mac OS X. In Wine, > D3D10 support is still in the embryonic stage (i.e. lots of stubs, > anything interesting doesn't work quite right). It looks like Henri > wants to wait until he finish

Summer of Code 2011 ideas

2011-03-27 Thread Charles Davis
Hi, I intend to participate in the Google Summer of Code (again), so I'd like to bounce some ideas off of you guys again. (I don't know why; I'll probably end up doing an extension of last year's project that I did for LLVM. But just in case...) I know that students are supposed to start submittin

Re: d3dx9_36: Implement D3DXCreateBox

2011-03-27 Thread Joshua Beck
On 3/27/2011 11:08 AM, Joris Huizer wrote: But you are changing the values during the function: + +for(i = 0; i< 24; i++) +{ +vertices[6 * i] *= width; +vertices[6 * i + 1] *= height; +vertices[6 * i + 2] *= depth; +} + On a side note, you could rearran

Re: d3dx9_36: Implement D3DXCreateBox

2011-03-27 Thread Joris Huizer
Hello, In this patch, one part seemed strange to me: You are declaring vertices as static memory: +static FLOAT vertices[144] But you are changing the values during the function: + +for(i = 0; i< 24; i++) +{ +vertices[6 * i] *= width; +vertices[6 * i + 1] *= he

Re: RFC: Remove unimplemented application menus?

2011-03-27 Thread André Hentschel
Am 27.03.2011 13:50, schrieb Francois Gouget: > > Some Wine programs, winefile in particular, have a lot of unimplemented > menus. That is you can see the menu entry but clicking on it only gives > you a 'Not yet implemented' error dialog (or does nothing in the case > of iexplore). For instanc

Re: RFC: wined3d: Check for and use FBO blits early in BltOverride

2011-03-27 Thread Henri Verbeet
On 27 March 2011 10:57, Stefan Dösinger wrote: > BltOverride is a horrible mess, and I'm afraid the patch doesn't make it any > better. Yeah, I'm not so convinced this is really an improvement either.

Re: [1/4] wined3d/context: Track the number of render targets in FBO entries.

2011-03-27 Thread Henri Verbeet
On 23 March 2011 23:50, Adam Martinson wrote: > On 03/22/2011 01:33 PM, Henri Verbeet wrote: >> >> How much of a real difference does this patch make, after you >> avoid the redundant lookups? (I.e., after the second patch in this >> series.) > > In that case the additional reduction in context_ap

RFC: Remove unimplemented application menus?

2011-03-27 Thread Francois Gouget
Some Wine programs, winefile in particular, have a lot of unimplemented menus. That is you can see the menu entry but clicking on it only gives you a 'Not yet implemented' error dialog (or does nothing in the case of iexplore). For instance just for the first two winefile menus none of the fol

Re: [2/4] wined3d: Track when the FBO is dirty.

2011-03-27 Thread Henri Verbeet
On 21 March 2011 21:57, Adam Martinson wrote: > @@ -2102,6 +2121,7 @@ BOOL context_apply_clear_state(struct wined3d_context > *context, IWineD3DDeviceIm > if (rt_count < context->gl_info->limits.buffers) > memset(context->blit_targets + rt_count, 0, > (context->gl_i

Re: RFC: wined3d: Check for and use FBO blits early in BltOverride

2011-03-27 Thread Chris Robinson
On Sunday, March 27, 2011 1:57:17 AM Stefan Dösinger wrote: > BltOverride is a horrible mess, and I'm afraid the patch doesn't make it > any better. A long time ago Roderick started a cleanup to give the blit > selection routine a more structured approach, but he never finished the > work. Unfortun

Re: d3dx10: Float16To32Array and Float32To16Array (GSoC)

2011-03-27 Thread Stefan Dösinger
On Friday 25 March 2011 08:40:04 Joshua Beck wrote: > Is there any documentation I can read on how to program for these DLLs? > I've been looking through MSDN and I can't find anything specifically > about those DLLs. However I did find Windows Imaging Component (which I > think is what windowscode

Re: RFC: wined3d: Check for and use FBO blits early in BltOverride

2011-03-27 Thread Stefan Dösinger
On Sunday 27 March 2011 06:26:47 Chris Robinson wrote: > After some testing and talking with Henri, it seems a number of checks > aren't needed if FBO blits are available, particularly the > swapchain/active render target checks. The attached patch makes > BltOverride check for FBO blits earlier, w