comctl32: realloc or free and alloc

2011-04-29 Thread Alexey Fisher
Hallo, i currently digg in comctl32 to find why my app fails. I found that string conversation AtoW in some places silently fails. The problem is that the destination for string is just a fresh pointer (not NULL). Str_SetPtrAtoW check if it is NULL pointer and if not it trys to ReAlloc. There was

Re: wined3d: If Wine fails to acquire the focus window, allow the wndproc function to continue receiving messages.

2011-04-29 Thread Henri Verbeet
On 30 April 2011 01:23, John Edmonds wrote: > @@ -6559,6 +6559,7 @@ static HRESULT WINAPI > IWineD3DDeviceImpl_Reset(IWineD3DDevice *iface, >                 { >                     ERR("Failed to acquire focus window, hr %#x.\n", hr); >                     wined3d_swapchain_decref(swapchain); >

Re: [PATCH] dinput: Mark internal symbols as hidden

2011-04-29 Thread Henri Verbeet
On 30 April 2011 00:41, Stefan Dösinger wrote: > I don't know how much the effect of marking a few functions hidden changes > that > though. In the d3d code most things are already either static or hidden, and > still not using -fPIC on wined3d alone improves things. > Things like TRACEs still ca

Re: gecko and native msvcrt

2011-04-29 Thread Hin-Tak Leung
--- On Fri, 29/4/11, Eric Pouech wrote: > Le 29/04/2011 23:07, Dan Kegel a > écrit : > > While testing a game with current gecko, I saw the > error > > > > wine: Call from 0x7bc4ad90 to unimplemented function > msvcrt.dll._snwprintf_s, > > aborting > > > > The game needed a native msvcrt, so I ha

Re: wineoss.drv: Add mmdevapi driver.

2011-04-29 Thread Gerald Pfeifer
I believe commit be332326ba8fc3def406c5f29adf04fbe9a83976 Author: Andrew Eikum Date: Wed Apr 27 09:12:36 2011 -0500 is causing the following build failures on my nightly FreeBSD testers: mmdevdrv.c:463:20: error: 'AFMT_S24_PACKED' undeclared (first use in this function) mmdevdrv.c:

Re: [PATCH] dinput: Mark internal symbols as hidden

2011-04-29 Thread Stefan Dösinger
On Friday 29 April 2011 21:01:36 Marcus Meissner wrote: > I do not think there will be noticable speed-up. Actually, not using -fPIC gives a ~2-3% speed boost in a number of d3d benchmarks. I don't know how much the effect of marking a few functions hidden changes that though. In the d3d code mo

Re: gecko and native msvcrt

2011-04-29 Thread Eric Pouech
Le 29/04/2011 23:07, Dan Kegel a écrit : While testing a game with current gecko, I saw the error wine: Call from 0x7bc4ad90 to unimplemented function msvcrt.dll._snwprintf_s, aborting The game needed a native msvcrt, so I had installed one with winetricks, and it didn't export that function.

gecko and native msvcrt

2011-04-29 Thread Dan Kegel
While testing a game with current gecko, I saw the error wine: Call from 0x7bc4ad90 to unimplemented function msvcrt.dll._snwprintf_s, aborting The game needed a native msvcrt, so I had installed one with winetricks, and it didn't export that function. So it seems that new gecko is incompatible

re: msvbvm60: add stub dll

2011-04-29 Thread Dan Kegel
Austin wrote: > Fixes http://bugs.winehq.org/show_bug.cgi?id=19816 That bug is "Add implementation of MSVBVM60". I don't think a stub fixes it. What apps benefit from having a stub? - Dan

Re: [PATCH] dinput: Mark internal symbols as hidden

2011-04-29 Thread Marcus Meissner
On Fri, Apr 29, 2011 at 08:12:36PM +0200, André Hentschel wrote: > Am 29.04.2011 16:18, schrieb Marcus Meissner: > > On Fri, Apr 29, 2011 at 07:38:30AM -0600, Vitaliy Margolen wrote: > >> On 04/29/2011 01:31 AM, Marcus Meissner wrote: > > > > will generate without the visibility line a PLT relocat

Re: [PATCH] dinput: Mark internal symbols as hidden

2011-04-29 Thread André Hentschel
Am 29.04.2011 16:18, schrieb Marcus Meissner: > On Fri, Apr 29, 2011 at 07:38:30AM -0600, Vitaliy Margolen wrote: >> On 04/29/2011 01:31 AM, Marcus Meissner wrote: > > will generate without the visibility line a PLT relocation resolving call: > > 045c : > 45c: 55 push

Fix WineHQ bug #19762

2011-04-29 Thread Joerg-Cyril.Hoehle
Kai Wasserbäch wrote: >as bug #19762 is open for some time now, fully bisected, the solution applied >for >several versions in my Debian packages ([0]) without reports about breakage, I >hearby propose the reversion of commit 67631163. http://bugs.winehq.org/show_bug.cgi?id=19762#c21 That commit

Re: [PATCH] dinput: Mark internal symbols as hidden

2011-04-29 Thread Chris Robinson
On Friday, April 29, 2011 7:18:47 AM Marcus Meissner wrote: > If they are not declared hidden, the -fPIC compile generates PLT > relocations for those symbols, even if they are internal to the dll (the > compiler does not know what to export during our build). > > With the hidden attribute these g

Re: Fix WineHQ bug #19762

2011-04-29 Thread Henri Verbeet
On 29 April 2011 12:29, Kai Wasserbäch wrote: > several versions in my Debian packages ([0]) without reports about breakage, I > hearby propose the reversion of commit 67631163. Wylda tried to reach the I don't think reverting that commit is the right thing to do, it's just going to break somethin

Re: [PATCH] dinput: Mark internal symbols as hidden

2011-04-29 Thread Marcus Meissner
On Fri, Apr 29, 2011 at 07:38:30AM -0600, Vitaliy Margolen wrote: > On 04/29/2011 01:31 AM, Marcus Meissner wrote: > >--- > > dlls/dinput/device_private.h | 148 > > +- > > 1 files changed, 74 insertions(+), 74 deletions(-) > > What exactly is this suppos

Re: [PATCH] dinput: Mark internal symbols as hidden

2011-04-29 Thread Vitaliy Margolen
On 04/29/2011 01:31 AM, Marcus Meissner wrote: --- dlls/dinput/device_private.h | 148 +- 1 files changed, 74 insertions(+), 74 deletions(-) What exactly is this supposed to to? This is inside header file, everything declared in it is internal to din

Re: include: Generate rmxftmpl.h from rmxftmpl.x using new build tool. (try 3)

2011-04-29 Thread David Adam
Hello, why did you use C++ comments ? A+ David +xof 0302txt 0064 > +// Copyright (C) 2011 Dylan Smith > +// > +// This library is free software; you can redistribute it and/or > > > >

Re: [1/5] wined3d: Add missing temporary variable declaration to ARB shader backend.

2011-04-29 Thread Stefan Dösinger
Am 29.04.2011 um 00:39 schrieb Matteo Bruni: > 2011/4/29 Stefan Dösinger : >>> +shader_addline(buffer, "TEMP TB;\n"); >> Which shader instruction uses this? Afair vertex shaders should only use TA, >> but there's no proper infrastructure that manages that. >> > > AFAICS, TB could get used i

Re: msvcrt: fix utime to correctly handle a NULL-pointer for the utimbuf structure field

2011-04-29 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10627 Your paranoid android

Re: po: Update French translation

2011-04-29 Thread Frédéric Delanoy
On Fri, Apr 29, 2011 at 08:04, Nicolas Le Cam wrote: > Hi Frédéric, > > Le 29 avril 2011 00:16, Frédéric Delanoy a écrit > : >>  #: winerror.mc:441 >>  msgid "No more search handles\n" >> -msgstr "Il n'y a plus de descripteurs de recherche\n" >> +msgstr "Il n'y a plus de descripteur de recherche