Re: winscard/tests: Implement test for two functions of winscard.dll

2011-05-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10749 Your paranoid android

Re: wineoss.drv: Add mmdevapi driver.

2011-05-05 Thread Gerald Pfeifer
On Fri, 29 Apr 2011, Gerald Pfeifer wrote: > commit be332326ba8fc3def406c5f29adf04fbe9a83976 > Author: Andrew Eikum > Date: Wed Apr 27 09:12:36 2011 -0500 > > is causing the following build failures on my nightly FreeBSD testers: > > mmdevdrv.c:463:20: error: 'AFMT_S24_PACKED' undeclar

avicap32: fix build with recent kernel headers

2011-05-05 Thread Rafał Mużyło
Attached patch seems to fix build problem with recent kernel headers, where v4l1 was removed. I'm sending it here first (instead straight to wine-patches), as I have no real way of testing it - I only know it builds. As such, I haven't bothered yet with keeping consistant folding style. In case o

Re: po: Update French translation

2011-05-05 Thread Frédéric Delanoy
2011/5/6 Nicolas Le Cam : >>  #: regedit.rc:88 >> -#, fuzzy >>  msgid "Modify Binary Data..." >> -msgstr "Modifier les données &binaires" >> +msgstr "Modifier les données &binaires..." > I'm not sure you can add a keyboard accelerator if there isn't one in > the original message. Well actually, it

Re: po: Update French translation

2011-05-05 Thread Nicolas Le Cam
>  #: regedit.rc:88 > -#, fuzzy >  msgid "Modify Binary Data..." > -msgstr "Modifier les données &binaires" > +msgstr "Modifier les données &binaires..." I'm not sure you can add a keyboard accelerator if there isn't one in the original message. -- Nicolas Le Cam

Re: Strange zero operation in dlls/riched20/tests/editor.c (Coverity)

2011-05-05 Thread Dylan Smith
On Thu, May 5, 2011 at 11:39 AM, Marcus Meissner wrote: > Hi Dylan, folks, > > Coverity sees following constructs in dlls/riched20/tests/editor.c > introduced by your commit aa3b75f6b74fa87641b1f2b5912fbb82feb4c2da > > +SendMessage(hwndRichEdit, WM_CHAR, 22, > +(MapVirtualKey(

Re: [3/3] msxml3/domdoc: Add support for VT_ARRAY|VT_UI1 in domdoc_load(). (try 2)

2011-05-05 Thread Adam Martinson
On 05/05/2011 09:37 AM, Nikolay Sivov wrote: On 5/5/2011 18:14, Adam Martinson wrote: I think this is actually the most straightforward/readable way to handle it. If multi-dimensional SAFEARRAYs are actually supported, we will need separate cases for them. It's just not the way I thought about

Re: [2/3] msxml3/domdoc: Add an internal function to load from a UTF8 string.

2011-05-05 Thread Adam Martinson
On 05/05/2011 09:21 AM, Nikolay Sivov wrote: On 5/5/2011 18:09, Adam Martinson wrote: On 05/04/2011 05:56 PM, Nikolay Sivov wrote: You don't need a separate helper for that. doparse() should do fine with "UTF-8" encoding parameter to force encoding. This is to avoid calling domdoc_loadXML() fro

Strange zero operation in dlls/riched20/tests/editor.c (Coverity)

2011-05-05 Thread Marcus Meissner
Hi Dylan, folks, Coverity sees following constructs in dlls/riched20/tests/editor.c introduced by your commit aa3b75f6b74fa87641b1f2b5912fbb82feb4c2da +SendMessage(hwndRichEdit, WM_CHAR, 22, +(MapVirtualKey('V', MAPVK_VK_TO_VSC) << 16) & 1); (several more of similar) The 4th

Re: [3/3] msxml3/domdoc: Add support for VT_ARRAY|VT_UI1 in domdoc_load(). (try 2)

2011-05-05 Thread Nikolay Sivov
On 5/5/2011 18:14, Adam Martinson wrote: On 05/04/2011 06:04 PM, Nikolay Sivov wrote: On 5/5/2011 00:38, Adam Martinson wrote: Fixes bugs 14864 + 16453. --- dlls/msxml3/domdoc.c | 27 + dlls/msxml3/tests/domdoc.c | 94 +++- 2 fil

Re: [2/3] msxml3/domdoc: Add an internal function to load from a UTF8 string.

2011-05-05 Thread Nikolay Sivov
On 5/5/2011 18:09, Adam Martinson wrote: On 05/04/2011 05:56 PM, Nikolay Sivov wrote: You don't need a separate helper for that. doparse() should do fine with "UTF-8" encoding parameter to force encoding. This is to avoid calling domdoc_loadXML() from domdoc_load(). When we need almost identic

Re: [3/3] msxml3/domdoc: Add support for VT_ARRAY|VT_UI1 in domdoc_load(). (try 2)

2011-05-05 Thread Adam Martinson
On 05/04/2011 06:04 PM, Nikolay Sivov wrote: On 5/5/2011 00:38, Adam Martinson wrote: Fixes bugs 14864 + 16453. --- dlls/msxml3/domdoc.c | 27 + dlls/msxml3/tests/domdoc.c | 94 +++- 2 files changed, 120 insertions(+), 1 deletions

Re: [2/3] msxml3/domdoc: Add an internal function to load from a UTF8 string.

2011-05-05 Thread Adam Martinson
On 05/04/2011 05:56 PM, Nikolay Sivov wrote: You don't need a separate helper for that. doparse() should do fine with "UTF-8" encoding parameter to force encoding. This is to avoid calling domdoc_loadXML() from domdoc_load(). When we need almost identical behavior from 2 separate interface func

Re: cmd: WCMD_delete: simplify logic, avoid assigning variable to i tself (try 2)

2011-05-05 Thread Alexandre Julliard
Dan Kegel writes: > Simpler version suggested by Henri. > I'm hoping this is enough of an improvement to be worth it. It would be better to build a simple mask and test against that, instead of all that silliness with booleans. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32. (try 4)

2011-05-05 Thread Alexandre Julliard
Charles Davis writes: > +case 0x05: > +data = "CdRomPeripheral"; > +snprintf(buffer, sizeof(buffer), "Cdrom%d", cdrom_no++); > +break; This needs to be set to the device name that mountmgr has assigned to it. That's the point of doing this in mountmgr: making sure tha

Re: [PATCH try3] wininet: Added support for persistent HTTP connections

2011-05-05 Thread Alexandre Julliard
Jacek Caban writes: > try3: I've included better content draining in this patch (that I was > hoping to do as follow-up previously, due to already big size of the > patch). That fixes observed test failures. Older wininet implementations > don't have it, so the test fails for them. I'm getting a