Re: Big ugly build changes might be needed for Debian/Ubuntu

2011-05-22 Thread Marcus Meissner
On Sat, May 21, 2011 at 05:57:40PM -0700, James McKenzie wrote: On 5/19/11 1:51 PM, Marcus Meissner wrote: It is trivial. You basically build wine twice, once in the 32bit environment and once inthe 64bit one. Maybe Wine can look into some sort of merge process to build both and at runtime

Re: ddraw: Don't interpret end padding as dwCaps2 for x64.

2011-05-22 Thread Stefan Dösinger
On Sunday 22 May 2011 06:57:30 Dylan Smith wrote: 4 bytes of padding are at the end of DDSURFACEDESC when compiling for x64, because it contains a pointer field followed by an odd number of DWORD fields. Does DDSURFACEDESC have the same padding when using the microsoft headers and msvc?

Re: user32: Partially implement FlashWindowEx with tests

2011-05-22 Thread Dmitry Timoshkov
André Hentschel n...@dawncrow.de wrote: +if (!pfwi-hwnd || pfwi-cbSize sizeof(FLASHWINFO)) +{ +SetLastError(ERROR_INVALID_PARAMETER); +return FALSE; +} I don't see in your tests the case for 'cbSize sizeof(FLASHWINFO)'. Also using !IsWindow() instead of !hwnd

Re: Big ugly build changes might be needed for Debian/Ubuntu

2011-05-22 Thread Ove Kåven
Den 21. mai 2011 19:38, skrev Scott Ritchie: Well now we can just Depends: wine:i386 or similar, I think. Last time I asked, they said the first multiarch implementation will not support that. The implementation cost of that would be very high (among other things, it might violate the current

Re: Big ugly build changes might be needed for Debian/Ubuntu

2011-05-22 Thread James McKenzie
On 5/21/11 11:51 PM, Marcus Meissner wrote: On Sat, May 21, 2011 at 05:57:40PM -0700, James McKenzie wrote: On 5/19/11 1:51 PM, Marcus Meissner wrote: It is trivial. You basically build wine twice, once in the 32bit environment and once inthe 64bit one. Maybe Wine can look into some sort of

Re: user32: Partially implement FlashWindowEx with tests

2011-05-22 Thread André Hentschel
Am 22.05.2011 09:58, schrieb Dmitry Timoshkov: André Hentschel n...@dawncrow.de wrote: +if (!pfwi-hwnd || pfwi-cbSize sizeof(FLASHWINFO)) +{ +SetLastError(ERROR_INVALID_PARAMETER); +return FALSE; +} I don't see in your tests the case for 'cbSize

Re: Big ugly build changes might be needed for Debian/Ubuntu

2011-05-22 Thread Marcus Meissner
On Sun, May 22, 2011 at 06:26:45AM -0700, James McKenzie wrote: On 5/21/11 11:51 PM, Marcus Meissner wrote: On Sat, May 21, 2011 at 05:57:40PM -0700, James McKenzie wrote: On 5/19/11 1:51 PM, Marcus Meissner wrote: It is trivial. You basically build wine twice, once in the 32bit environment

Re: Big ugly build changes might be needed for Debian/Ubuntu

2011-05-22 Thread Scott Ritchie
On 05/22/2011 03:53 AM, Ove Kåven wrote: Den 21. mai 2011 19:38, skrev Scott Ritchie: Well now we can just Depends: wine:i386 or similar, I think. Last time I asked, they said the first multiarch implementation will not support that. The implementation cost of that would be very high (among

Re: ddraw: Don't interpret end padding as dwCaps2 for x64.

2011-05-22 Thread Dylan Smith
On Sun, May 22, 2011 at 3:10 AM, Stefan Dösinger stefandoesin...@gmx.at wrote: On Sunday 22 May 2011 06:57:30 Dylan Smith wrote: 4 bytes of padding are at the end of DDSURFACEDESC when compiling for x64, because it contains a pointer field followed by an odd number of DWORD fields. Does

Re: user32: Partially implement FlashWindowEx with tests

2011-05-22 Thread Detlef Riekenberg
On So, 2011-05-22, André Hentschel wrote Thanks, will get into try 2 pfwi-cbSize sizeof(FLASHWINFO) || pfwi-cbSize sizeof(FLASHWINFO) That code can be reduced to: pfwi-cbSize != sizeof(FLASHWINFO) -- By by ... Detlef

Re: Big ugly build changes might be needed for Debian/Ubuntu

2011-05-22 Thread Ove Kåven
Den 22. mai 2011 21:48, skrev Scott Ritchie: On 05/22/2011 03:53 AM, Ove Kåven wrote: Den 21. mai 2011 19:38, skrev Scott Ritchie: Well now we can just Depends: wine:i386 or similar, I think. Last time I asked, they said the first multiarch implementation will not support that. The

Re: comctl32/tests: Add casts to avoid comparison of different int types. [take 2]

2011-05-22 Thread Gerald Pfeifer
On Wed, 16 Feb 2011, Alexandre Julliard wrote: This is the first hunk of a patch a few days ago; testbot.winehq.org thinks it's fine: https://testbot.winehq.org/JobDetails.pl?Key=9291 You don't need casts. If the variable has the wrong type you can change that. At first I didn't realize what

Re: comctl32: Shed an unused parameter of TOOLTIPS_HitTestT and rename to TOOLTIPS_HitTest. (RESEND)

2011-05-22 Thread Nikolay Sivov
On Sun, May 22, 2011 at 6:07 PM, Gerald Pfeifer ger...@pfeifer.com wrote: Any problems with this patch I submitted back in February? I believe I mentioned it, or I should have. Message handler is incomplete, cause it should return text as well, that's why it has A/W versions. This needs tests

Re: urlmon: Fix incorrect pointer arithmetic (too conversative) in map_url_to_zone.

2011-05-22 Thread Nikolay Sivov
On Sun, May 22, 2011 at 10:53 PM, Gerald Pfeifer ger...@pfeifer.com wrote: The difference between two pointers (of the same type) is the number of elements, not the number of bytes. That's why it was divided by element size to get 'number of elements'. What's a problem?  Thus the code below