Re: cmd: Don't read past end of thisVar in WCMD_expand_envvar (valgrind)

2011-05-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11166 Your paranoid android

Re: cmd: Don't read past end of thisVar in WCMD_expand_envvar (valgrind)

2011-05-24 Thread Dan Kegel
On Tue, May 24, 2011 at 10:26 PM, Marvin wrote: > === WNT4WSSP6 (32 bit) === > batch.c:223: Test failed: unexpected char 0x54 position 0 in line 86 (got > 'This Line Is Never Reached.  If this runs, it is a bug.', wanted '65536') Well, foo. Guess NT is different. I'll rework the tests sometime

Re: windows are incompletely drawn: bisected to commit 7864ade5a8306c0078e16ae6d7e40bdece29395b

2011-05-24 Thread Austin English
On Tue, May 24, 2011 at 17:24, Wolfgang Walter wrote: > An application we use shows incompletely painted windows with 1.3.19. I > bisected it to commit > > 7864ade5a8306c0078e16ae6d7e40bdece29395b is the first bad commit > commit 7864ade5a8306c0078e16ae6d7e40bdece29395b > Author: Dmitry Timoshkov

Re: [2/5] d3dx9: Generate effect instances from materials for mesh loading.

2011-05-24 Thread Matteo Bruni
2011/5/24 Dylan Smith : > --- >  dlls/d3dx9_36/mesh.c |  117 +++-- >  1 files changed, 112 insertions(+), 5 deletions(-) > > diff --git a/dlls/d3dx9_36/mesh.c b/dlls/d3dx9_36/mesh.c > index fa32797..20b3262 100644 > --- a/dlls/d3dx9_36/mesh.c > +++ b/dlls

windows are incompletely drawn: bisected to commit 7864ade5a8306c0078e16ae6d7e40bdece29395b

2011-05-24 Thread Wolfgang Walter
An application we use shows incompletely painted windows with 1.3.19. I bisected it to commit 7864ade5a8306c0078e16ae6d7e40bdece29395b is the first bad commit commit 7864ade5a8306c0078e16ae6d7e40bdece29395b Author: Dmitry Timoshkov Date: Tue Sep 14 14:24:11 2010 +0900 winex11.drv: Avoid c

Re: [1/5] wined3d: Don't check the FBO status if FIXMEs are off

2011-05-24 Thread Henri Verbeet
On 24 May 2011 22:37, Stefan Dösinger wrote: > I put the fixme checks outside context_check_fbo_status because the > ENTER_GL() / LEAVE_GL() > locking is more expensive than the FBO validation itself. Moving the locking > into the function I'm not sure that's really worth it. If the GL lock is

Re: usp10/test: make sure to only trace on _test_shape_ok number of glyphs if font is not valid

2011-05-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11158 Your paranoid android

Re: [2/2]usp10/test: add Tibetan shaping test

2011-05-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11159 Your paranoid android

Re: [PATCH 4/5] wined3d: Mask out writes to unused render targets.

2011-05-24 Thread Stefan Dösinger
On Tuesday 24 May 2011 21:18:53 Henri Verbeet wrote: > @@ -1999,19 +1999,22 @@ static void context_apply_draw_buffers(struct > wined3d_context *context, UINT rt_ if > (wined3d_settings.offscreen_rendering_mode == ORM_FBO) { > const struct wined3d_gl_info *gl_info = context->gl_info; >

Re: [PATCH] wined3d: Mark wined3d_pixel_format with hidden visibility

2011-05-24 Thread Henri Verbeet
On 13 May 2011 18:27, Marcus Meissner wrote: > @@ -1273,7 +1273,7 @@ struct wined3d_pixel_format >     BOOL doubleBuffer; >     int auxBuffers; >     int numSamples; > -} wined3d_pixel_format; > +} wined3d_pixel_format DECLSPEC_HIDDEN; > No, that's wrong. It's not supposed to be a variable at all,

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-05-24 Thread Stefan Dösinger
On Tuesday 24 May 2011 19:56:06 Michael Mc Donnell wrote: > Sorry I phrased that in a wrong way. In the UpdateSemantics function I > call IDirect3DDevice9_CreateVertexDeclaration which allocates a new > Vertex Declaration on the heap. Is there an alternative? I guess you could cache existing decl

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-05-24 Thread Michael Mc Donnell
Thanks for the lengthy feedback! On Tue, May 24, 2011 at 3:36 PM, Stefan Dösinger wrote: > Hi, > I'm at school right now, so I had only a very quick look. I'll take a closer > look later in the evening. > > On Tuesday 24 May 2011 14:38:19 Michael Mc Donnell wrote: >> This is my first try at imple

Re: [1/8]usp10/tests: update test_ScriptShapeOpenType framework to shape in a given font

2011-05-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11133 Your paranoid android

Re: [6/8]usp10/test: add Thaana shaping test

2011-05-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11138 Your paranoid android

Re: [8/8]usp10/test: add Lao shaping test

2011-05-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11140 Your paranoid android

Re: [7/8]usp10/test: add Phags-pa shaping test

2011-05-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11139 Your paranoid android

Re: [5/8]usp10/tests: add Syriac shaping test

2011-05-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11137 Your paranoid android

Re: [4/8]usp10: add Thai shaping test

2011-05-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11136 Your paranoid android

Re: [3/8]usp10: add Arabic Shaping Test

2011-05-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11135 Your paranoid android

Re: [2/8]usp10: add Hebrew shaping test

2011-05-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11134 Your paranoid android

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-05-24 Thread Stefan Dösinger
Hi, I'm at school right now, so I had only a very quick look. I'll take a closer look later in the evening. On Tuesday 24 May 2011 14:38:19 Michael Mc Donnell wrote: > This is my first try at implementing the UpdateSemantics mesh method. > It works fine here on my local machine, passes the new te

Re: [11/15]usp10/tests: update test_ScriptShapeOpenType framework to shape in a given font

2011-05-24 Thread Aric Stewart
Ah, I wondered if I was pushing the Macro thing too far. -aric On 11/05/24 5:26, Alexandre Julliard wrote: Aric Stewart writes: @@ -297,9 +297,13 @@ static void test_ScriptItemize( void ) test_items_ok(test10,4,&Control,&State,1,t101,FALSE,0); } -static inline void _test_shape_ok(HD

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-05-24 Thread Michael Mc Donnell
Hi Stefan This is my first try at implementing the UpdateSemantics mesh method. It works fine here on my local machine, passes the new tests, and works with my little interactive demo(not included). I still have a few questions though. This implementation allocates new heap memory and I suspect t

Re: [PATCH] winealsa.drv: Implement device enumeration

2011-05-24 Thread Alexandre Julliard
Andrew Eikum writes: > --- > dlls/winealsa.drv/mmdevdrv.c | 113 > +++--- > 1 files changed, 94 insertions(+), 19 deletions(-) It doesn't work here (and I didn't even plug in my USB headset ;-) ../../../tools/runtest -q -P wine -M mmdevapi.dll -T ../../.. -

Re: [8/15]usp10/tests: Hebrew shaping test

2011-05-24 Thread Alexandre Julliard
Aric Stewart writes: > --- > dlls/usp10/tests/usp10.c |9 + > 1 files changed, 9 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M usp10.dll -T ../../.. -p usp10_test.exe.so usp10.c && touch usp10.ok usp10.c:438: Test failed: 0: Glyph not pre

Re: [11/15]usp10/tests: update test_ScriptShapeOpenType framework to shape in a given font

2011-05-24 Thread Alexandre Julliard
Aric Stewart writes: > @@ -297,9 +297,13 @@ static void test_ScriptItemize( void ) > test_items_ok(test10,4,&Control,&State,1,t101,FALSE,0); > } > > -static inline void _test_shape_ok(HDC hdc, LPCWSTR string, DWORD cchString, > - SCRIPT_CONTROL *Control, SCRIPT_STA

Re: ole32/ole2: Don't call IDropTarget::QueryInterface() in RegisterDragDrop(). [whitespace fixed]

2011-05-24 Thread Huw Davies
> +static IDropTarget* WrapDropTarget(IDropTarget* inner) > +{ > +DropTargetWrapper* This = HeapAlloc(GetProcessHeap(), 0, sizeof(*This)); > + > +if (This) > +{ > +This->iface = (IDropTarget){ &DropTargetWrapper_VTbl }; This->iface.lpVtbl = &DropTargetWrapper_VTbl; > - hr = C

Re: performance regression or not?

2011-05-24 Thread Ken Thomases
On May 23, 2011, at 12:13 PM, wrote: > - I'm now wondering whether thread affinity may play a role. > Alas, I don't know how to disable one core with Mac OS X 10.5.8 Double-click on /Developer/Extras/PreferencePanes/Processor.prefPane. That will install it to System Preferences. Then, you