Re: [1/3] kernel32/heap: Emulate Win9x if appropriate in GlobalMemoryStatusEx(). (resend)

2011-06-02 Thread Adam Martinson
On 06/02/2011 09:21 PM, Charles Davis wrote: On 6/2/11 2:46 PM, Adam Martinson wrote: On 06/02/2011 03:10 PM, Dmitry Timoshkov wrote: Adam Martinson wrote: +osver.dwOSVersionInfoSize = sizeof(osver); +GetVersionExW(&osver); + ... +if (osver.dwMajorVersion>= 5) Once again, tha

Re: [1/3] kernel32/heap: Emulate Win9x if appropriate in GlobalMemoryStatusEx(). (resend)

2011-06-02 Thread Charles Davis
On 6/2/11 2:46 PM, Adam Martinson wrote: > On 06/02/2011 03:10 PM, Dmitry Timoshkov wrote: >> Adam Martinson wrote: >> >>> +osver.dwOSVersionInfoSize = sizeof(osver); >>> +GetVersionExW(&osver); >>> + >> ... >>> +if (osver.dwMajorVersion>= 5) >> Once again, that's wrong way of detectin

Re: [2/3] kernel32/heap: Fix some hacks in GlobalMemoryStatus(). (try 2)

2011-06-02 Thread Adam Martinson
On 06/02/2011 03:11 PM, Dmitry Timoshkov wrote: Adam Martinson wrote: +/* Check the current process and all ancestors that share its address space. + * Some apps run sub-processes that have the IMAGE_FILE_LARGE_ADDRESS_AWARE flag set, but + * the parent process doesn't (eg, Dragon NaturallySp

Re: [1/3] kernel32/heap: Emulate Win9x if appropriate in GlobalMemoryStatusEx(). (resend)

2011-06-02 Thread Adam Martinson
On 06/02/2011 03:10 PM, Dmitry Timoshkov wrote: Adam Martinson wrote: +osver.dwOSVersionInfoSize = sizeof(osver); +GetVersionExW(&osver); + ... +if (osver.dwMajorVersion>= 5) Once again, that's wrong way of detecting win9x, or please try to explain better how the patch does what

Re: [13/18]usp10/tests: add Gurmukhi shaping test

2011-06-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11438 Your paranoid android

Re: [2/3] kernel32/heap: Fix some hacks in GlobalMemoryStatus(). (try 2)

2011-06-02 Thread Dmitry Timoshkov
Adam Martinson wrote: > +/* Check the current process and all ancestors that share its address space. > + * Some apps run sub-processes that have the IMAGE_FILE_LARGE_ADDRESS_AWARE > flag set, but > + * the parent process doesn't (eg, Dragon NaturallySpeaking 7 setup runs > Install Shield 6). >

Re: [1/3] kernel32/heap: Emulate Win9x if appropriate in GlobalMemoryStatusEx(). (resend)

2011-06-02 Thread Dmitry Timoshkov
Adam Martinson wrote: > +osver.dwOSVersionInfoSize = sizeof(osver); > +GetVersionExW(&osver); > + ... > +if (osver.dwMajorVersion >= 5) Once again, that's wrong way of detecting win9x, or please try to explain better how the patch does what the subject describes, and for which app it

Re: [2/19](resend)usp10: improve Sinhala shaping using Indic rules

2011-06-02 Thread Alexandre Julliard
Aric Stewart writes: > @@ -0,0 +1,236 @@ > + > +#include "config.h" > +#include > +#include > +#include Please add a license header on new files. > +#define IS_VALID_INDEX (next < cChar) Don't reference local variables directly, pass them to the macro. > +#define OPTIONAL_CHAR(a) if (IS_VA

Re: ddraw: Add tests for Setcooperativelevel

2011-06-02 Thread Stefan Dösinger
On Wednesday 01 June 2011 20:37:36 paulo lesgaz wrote: > Yes, see bug 25660 > My tests prove that > DDSCL_CREATEDEVICEWINDOW+DDSCL_EXCLUSIVE+DDSCL_FULLSCREEN is allowed with > a NULL window. That is what expected by Half life I demo. Erm, I missed that in your patch, it was right at the top of the

Re: [1/26](resend)usp10: Add Indic syllable parsing and reordering system

2011-06-02 Thread Alexandre Julliard
Aric Stewart writes: > +void Indic_ReorderCharacters( LPWSTR input, int cChar, lexical_function lex, > reorder_function reorder_f) > +{ > +int index = 0; > +int next = 0; > +int center; > + > +if (!lex || ! reorder_f) > +{ > +ERR("Failure to have required functions\n"