TaskDialog implementation

2011-06-09 Thread Patrick Gauthier
Hello everyone, I'd like to port my re-implementation of task dialogs (http://www.korosoft.net/projects/tdemu/) to WINE, actually I have posted a small patch yesterday (merely rearranges some source around, preparatory work) which sadly did not seem to get accepted. I'm going to take my code and

Re: [PATCH 1/4] shell32/tests: basic tests of IKnownFolderManager

2011-06-09 Thread Mariusz Pluciński
Thank you for suggestions. I fixed the problems. W dniu 05.06.2011 22:26, Vincent Povirk pisze: +/* try to set new path */ +hr = IKnownFolder_SetPath(folder, 0, sTempDir); +todo_wine +ok(hr == S_OK, setting path failed: 0x%08x\n, hr); I'd suggest

Re: [1/2] d3dx9/test: Add UpdateSemantics test.

2011-06-09 Thread Michael Mc Donnell
On Wed, Jun 8, 2011 at 8:32 PM, Stefan Dösinger stefandoesin...@gmx.at wrote: On Wednesday 08 June 2011 18:51:41 Michael Mc Donnell wrote:    unsigned int faces[] = {0, 1, 2};    unsigned int num_faces = sizeof(faces) / 3; Does this do what you want? As far as I can see you want

Re: [1/2] d3dx9/test: Add UpdateSemantics test.

2011-06-09 Thread Henri Verbeet
On 9 June 2011 13:01, Michael Mc Donnell mich...@mcdonnell.dk wrote: On a side note, failing to get a device means that the d3dx tests are always skipped on the testbot? The ones that need a device, yes. The testbot machines are all VMs, so they don't have real display hardware. For a realistic

Re: [1/2] d3dx9/test: Add UpdateSemantics test.

2011-06-09 Thread Ricardo Filipe
2011/6/9 Henri Verbeet hverb...@gmail.com On 9 June 2011 13:01, Michael Mc Donnell mich...@mcdonnell.dk wrote: On a side note, failing to get a device means that the d3dx tests are always skipped on the testbot? The ones that need a device, yes. The testbot machines are all VMs, so they

Re: [1/2] d3dx9/test: Add UpdateSemantics test.

2011-06-09 Thread Stefan Dösinger
On Thursday 09 June 2011 13:01:17 Michael Mc Donnell wrote: Change it to brackets on new lines? I actually copied the style from the method above mine. Is this better?: +struct +{ ... +} vertices[] = +{ Yes, although I'd also move the vertices[] in a separate line. The

Re: [1/2] d3dx9/test: Add UpdateSemantics test.

2011-06-09 Thread Stefan Dösinger
On Thursday 09 June 2011 13:22:27 Henri Verbeet wrote: The ones that need a device, yes. The testbot machines are all VMs, so they don't have real display hardware. Maybe we can set up the refrast? It has some problems, and not all our tests will pass(intentionally), but it would allow to run

Re: [PATCH 2/2] urlmon: Added empty file binding test

2011-06-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11581 Your paranoid

Re: TaskDialog implementation

2011-06-09 Thread Lats
I have been looking at this and my advice is start simple and establish the basic framework ie. display a frame with a title. Then add functions and text items or buttons types one by one. Add complexity to the functions after the basic form is accepted. On 09/06/11 17:00, Patrick Gauthier

Re: TaskDialog implementation

2011-06-09 Thread Juan Lang
Hi Patrick, As this is quite a big amount of work, I would like to have some guidance (what must I do to be sure it is accepted) so that I do not end up doing all that for nothing - starting by knowing why my patch from yesterday was not accepted (what did I do wrong). The patch was marked

Re: TaskDialog implementation

2011-06-09 Thread Vincent Povirk
+if (pnButton) *pnButton = IDYES; +if (pnRadioButton) *pnRadioButton = pTaskConfig-nDefaultButton; +if (pfVerificationFlagChecked) *pfVerificationFlagChecked = TRUE; +return S_OK; I don't think it's appropriate to make selections for the user like this. If you can't present all of

Re: [1/2] d3dx9/test: Add UpdateSemantics test.

2011-06-09 Thread Michael Mc Donnell
On Thu, Jun 9, 2011 at 1:56 PM, Ricardo Filipe ricardojdfil...@gmail.com wrote: 2011/6/9 Henri Verbeet hverb...@gmail.com On 9 June 2011 13:01, Michael Mc Donnell mich...@mcdonnell.dk wrote: On a side note, failing to get a device means that the d3dx tests are always skipped on the testbot?

re: TaskDialog implementation

2011-06-09 Thread Dan Kegel
Patrick wrote: I'd like to port my re-implementation of task dialogs (http://www.korosoft.net/projects/tdemu/) to WINE Awesome! I would like to have some guidance ... [Why was my patch from yesterday not accepted?] An iota of guidance was provided at http://source.winehq.org/patches/ Scroll

Re: setupapi: Make sure machine name is non-empty before failing

2011-06-09 Thread Dmitry Timoshkov
Juan Lang juan.l...@gmail.com wrote: +static const WCHAR emptyW[] = { 0 }; ... -if (MachineName != NULL) +if (MachineName != NULL strcmpW(MachineName, emptyW)) What's wrong with 'if (MachineName *MachineName)' ? -- Dmitry.

Re: setupapi: Make sure machine name is non-empty before failing

2011-06-09 Thread Juan Lang
What's wrong with 'if (MachineName *MachineName)' ? Nothing, it's my brain that's lacking. Thanks. --Juan

Re: setupapi: Make sure machine name is non-empty before failing (try 2)

2011-06-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11589 Your paranoid

Re: [1/2] d3dx9/test: Add UpdateSemantics test. (try 2)

2011-06-09 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Looks ok to me Am 09.06.2011 um 17:50 schrieb Michael Mc Donnell: Removed a superfluous test. Added NULL check before releasing mesh. Changed struct declaration style. Changed the struct declaration style again. --- dlls/d3dx9_36/tests/mesh.c