Your patches have dos line endings (i.e. \r\n) which causes git apply to
fail, although the patch command only gives a warning.
@@ -208,6 +221,12 @@ static DWORD WINAPI
ID3DXMeshImpl_GetNumBytesPerVertex(ID3DXMesh *iface)
TRACE(iface (%p)\n, This);
+if (!This-vertex_declaration)
+
+static void test_update_semantics(void)
+{
...
+ int offset = 12;
sizeof(D3DXVECTOR3) might be clearer.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=11594
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=11595
Your paranoid
Hans Leidekker h...@codeweavers.com writes:
@@ -772,10 +772,22 @@ static HANDLE execute_command( const WCHAR *exe, WCHAR
*arg, const WCHAR *dir )
{
STARTUPINFOW si;
PROCESS_INFORMATION info;
+int len;
+WCHAR *cmd;
BOOL ret;
+len = strlenW( exe );
+if
Hans Leidekker h...@codeweavers.com writes:
ENUM_SERVICE_STATUSW and ENUM_SERVICE_STATUS_PROCESSW embed pointers so we
cannot
use these structures on Wow64, where the service manager runs as a 64-bit
process and
the querying process can be 32-bit.
You should still keep the proper
On Fri, Jun 10, 2011 at 8:08 AM, Dylan Smith dylan.ah.sm...@gmail.com wrote:
Your patches have dos line endings (i.e. \r\n) which causes git apply to
fail, although the patch command only gives a warning.
Yeah I think this is because of git-imap was changed to convert the
line endings on the
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=11601
Your paranoid
On Fri, Jun 10, 2011 at 8:10 AM, Dylan Smith dylan.ah.sm...@gmail.com wrote:
+static void test_update_semantics(void)
+{
...
+ int offset = 12;
sizeof(D3DXVECTOR3) might be clearer.
Ok, I'll change that along with your other comments about the patch
for the UpdateSemantics
On Mon, Jun 6, 2011 at 03:17, Dan Kegel d...@kegel.com wrote:
https://testbot.winehq.org/JobDetails.pl?Key=11509 shows failures and
crashes, but the nearly identical
https://testbot.winehq.org/JobDetails.pl?Key=11510 does not. (The latter one
just adds a call to GetProcessMemoryInfo() in the
Hi,
The sad news reached me two days ago that Ge (Greg) van Geldorp passed
away. Please find below the mail from his brother.
I've briefly talked to Jeremy and Alexandre about this loss and the idea
came up to have something on the winehq frontpage for a while. Jeremey
also mentioned to
Hi Lauri,
ok(pdst != NULL, inet_ntoa failed %s\n, dst);
-ok(!strcmp(pdst, addr0_Str),Address %s != %s\n, pdst, addr0_Str);
+ok(pdst !strcmp(pdst, addr0_Str),Address %s != %s\n, pdst, addr0_Str);
This change doesn't accomplish anything. In the first place, the
previous ok which you
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=11621
Your paranoid
The sad news reached me two days ago that Ge (Greg) van Geldorp passed
away. Please find below the mail from his brother.
This is sad news indeed. The testbot he created is tremendously useful
and a great achievement. He also was always helpful and nice when I
asked him about it. His
On Fri, Jun 10, 2011 at 16:37, Wolfram Sang wolf...@the-dreams.de wrote:
The sad news reached me two days ago that Ge (Greg) van Geldorp passed
away. Please find below the mail from his brother.
This is sad news indeed. The testbot he created is tremendously useful and a
great achievement.
On Fri, 10 Jun 2011 14:19:43 -0700, Juan Lang wrote:
This change doesn't accomplish anything.
Yes it does. It makes Clang happy and avoids a null pointer dereference
in case the tests are failing. (Even if they're passing now, someone
might break them in future.)
In the first place, the
Sad news indeed. His work on getting winetestbot integrated into wine was
amazing. He was also nice every time I talked to him.
I'll miss him. Hierbij mijn steunbetuiging aan zijn nabestaanden.
~Maarten
(Sorry for the late reply. BSD dev machine had some hard disk issues.)
Thanks for all your input. Here are some comments:
On 06/09/11 10:51, Juan Lang wrote:
The patch was marked as Pending. That usually means Alexandre's
waiting for something, e.g. for you to fix something obvious, or to
It would be a lot easier to find and fix real things if there weren't a
thousand false ones hanging around. But if you feel it's better to have a
lot of warnings and some possible bugs than a lot of checks and no bugs,
then maybe I'll not waste any more time fixing them.
This is a false
On 6/10/11 2:59 PM, Austin English wrote:
On Fri, Jun 10, 2011 at 16:37, Wolfram Sangwolf...@the-dreams.de wrote:
The sad news reached me two days ago that Ge (Greg) van Geldorp passed
away. Please find below the mail from his brother.
This is sad news indeed. The testbot he created is
I'm sad to hear that Ge has passed away. He was really a nice guy and
his contributions to Wine have been very helpful.
We zullen hem missen.
Roderick
On 06/09/11 10:55, Vincent Povirk wrote:
+ if (pnButton) *pnButton = IDYES;
+ if (pnRadioButton) *pnRadioButton = pTaskConfig-nDefaultButton;
+ if (pfVerificationFlagChecked) *pfVerificationFlagChecked = TRUE;
+ return S_OK;
I don't think it's appropriate to make selections for
22 matches
Mail list logo
