Re: [3/3] msxml3: Added IStream support to IMXWriter

2011-06-19 Thread Adam Martinson
On 06/19/2011 09:32 PM, Thomas Mullaly wrote: +static inline void reset_output_buffer(mxwriter *This, LPCSTR encoding) +{ +xmlOutputBufferClose(This->buffer); + +if (encoding) +This->buffer = xmlAllocOutputBuffer(xmlFindCharEncodingHandler(encoding)); +else if (!This->dest) +

Re: [1/3] msxml3/tests: Added IStream tests for IMXWriter

2011-06-19 Thread Adam Martinson
On 06/19/2011 09:31 PM, Thomas Mullaly wrote: +#define DEFINE_EXPECT(func) \ +static BOOL expect_ ## func = FALSE, called_ ## func = FALSE + +#define SET_EXPECT(func) \ +expect_ ## func = TRUE This seems like macro-overkill. I think a struct/table here may be a bit cleaner. +static c

Re: ddraw: Add tests for SetCooperativeLevels

2011-06-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11839 Your paranoid android

Re: [PATCH 2/4] server: Add function to count only valid handles in a process

2011-06-19 Thread Vitaliy Margolen
On 06/19/2011 08:15 PM, Austin Lund wrote: [PATCH 2/4] server: Add function to count only valid handles in a process This makes no sense. All handles are valid inside wineserver. Vitaliy.

Re: [PATCH 1/4] dlls/ntdll: Add handle count to NtQuerySystemInformation

2011-06-19 Thread Vitaliy Margolen
On 06/19/2011 08:15 PM, Austin Lund wrote: +ret = wine_server_call( req ); +shi->Count += reply->handles; +len = sizeof(SYSTEM_HANDLE_ENTRY)*shi->Count + sizeof(ULONG); +shi = RtlReAllocateHeap(GetProcessHeap(), HEA

CopyFileExW Support

2011-06-19 Thread Arthur Dene Ice
Thank you Jerome, this is my first patch and I pretty much bunged it all up. I appreciate the help. So to recap, subscribe to list first so that I can respond to messages. check. Fix my tab/spacing issue. check. and fix my patch submission subject line so it is more in line with the standard. check

Re: [PATCH 1/6] quartz/tests: COM cleanup for the IPin iface.

2011-06-19 Thread Michael Stefaniuc
On 06/19/2011 02:27 PM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.wineh

Re: [PATCH 5/6] quartz/tests: Store the TestFilterImpl instead of its iface in IEnumPinsImpl.

2011-06-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11827 Your paranoid android

Re: [PATCH 4/6] quatz/tests: Pass back the object instead of the iface in createtestfilter()

2011-06-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11826 Your paranoid android

Re: [PATCH 6/6] quartz/tests: Simplify the file handling in filtergraph.c.

2011-06-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11828 Your paranoid android

Re: [PATCH 2/6] quartz/tests: COM cleanup for the IClassFactory iface.

2011-06-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11824 Your paranoid android

Re: [PATCH 1/6] quartz/tests: COM cleanup for the IPin iface.

2011-06-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11823 Your paranoid android

Re: [PATCH 3/6] quartz/tests: Finish the COM cleanup in filtergraph.c.

2011-06-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11825 Your paranoid android

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 3)

2011-06-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11822 Your paranoid android

Re: wined3d: Use a separate mutex for wndproc_table access.

2011-06-19 Thread Henri Verbeet
On 18 June 2011 12:51, Stefan Dösinger wrote: > You don't need wined3d_wndproc_mutex_(un)lock. Just use EnterCriticalSection / > LeaveCriticalSection directly. wined3d_mutex_lock exists because it is > exported from wined3d. > I don't know, I think there's something to say for having those functio

Re: CopyFileExW Support

2011-06-19 Thread Jerome Leclanche
You are severely mixing tabs and spaces, you should fix your editor. You also have a lot of unrelated trailing whitespace changes; granted they all remove trailing whitespace, but since this isn't a small patch, it makes it harder to read. J. Leclanche On Sun, Jun 19, 2011 at 2:40 AM, Arthur

Re: Wrong AppDB link

2011-06-19 Thread Ricardo Filipe
it's not there nor in the bug link queue. so it seems someone got to it already :) 2011/6/18 > > Hi, > > by mistake i linked a wrong bug to FAR Manager: > > http://appdb.winehq.org/objectManager.php?sClass=version&iId=15928 > > Could someone remove a link from FAR to bug 27406, please? > > > Tha

Re: openal32: test whether alGetError() returns AL_NO_ERROR when called out of context, with fix.

2011-06-19 Thread Chris Robinson
On Saturday, June 18, 2011 8:32:31 PM Dan Kegel wrote: > Matches native behavior. Makes at least one app happier; see bug 27532. Just to toss in my comments, the "native" behavior referred to is the behavior of Creative's DLLs, but Creative's DLLs aren't the only ones available for Windows. Ope