[1/2] d3dx9/test: Add UpdateSemantics test. (try 3)

2011-06-22 Thread Michael Mc Donnell
Hi Alexandre My UpdateSemantics patches haven't been applied yet. Stefan Dösinger and Dylan Smith think they look ok. Is there something that looks wrong with them to you, or have you just not have the time to look at them yet? Thanks, Michael Mc Donnell

Re: [PATCH 4/6] msvcp90: Added locale class stub

2011-06-22 Thread Alexandre Julliard
Piotr Caban pi...@codeweavers.com writes: +/* ?name@locale@std@@QBE?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@2@XZ */ +/* ?name@locale@std@@QEBA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@2@XZ */ +DEFINE_THISCALL_WRAPPER(locale_name, 8) +void __thiscall

Re: [PATCH 1/5] shell32: Add IKnownFolderManager::RegisterFolder implementation (resend)

2011-06-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11886 Your paranoid

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-06-22 Thread Michael Mc Donnell
On Tue, Jun 21, 2011 at 5:36 PM, Dylan Smith dylan.ah.sm...@gmail.com wrote: On Tue, Jun 21, 2011 at 6:32 AM, Michael Mc Donnell mich...@mcdonnell.dk wrote: Here is my test and implementation of ConvertAdjacencyToPointReps. +    hr = iface-lpVtbl-LockIndexBuffer(iface, D3DLOCK_READONLY,

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-06-22 Thread Dylan Smith
On Wed, Jun 22, 2011 at 10:12 AM, Michael Mc Donnell mich...@mcdonnell.dk wrote: Thanks your comments. I've attached an updated version. +if (indices) HeapFree(GetProcessHeap(), 0, indices); +} +if (new_indices) HeapFree(GetProcessHeap(), 0, new_indices); HeapFree checks for

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-06-22 Thread Michael Mc Donnell
On Wed, Jun 22, 2011 at 4:53 PM, Dylan Smith dylan.ah.sm...@gmail.com wrote: On Wed, Jun 22, 2011 at 10:12 AM, Michael Mc Donnell mich...@mcdonnell.dk wrote: Thanks your comments. I've attached an updated version. +        if (indices) HeapFree(GetProcessHeap(), 0, indices); +    } +    if

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-06-22 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 22.06.2011 um 21:48 schrieb Michael Mc Donnell: HeapFree checks for NULL for you, so remove the NULL check before calling HeapFree. Ok. I see that now in the Wine source. That's a lot nicer than on Windows. Windows also checks for NULL

Re: [PATCH 2/2] d3dx9_36/tests: Added tests for constant table samplers (Try 2)

2011-06-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11904 Your paranoid

Re: Need help at collecting ActionMapping data

2011-06-22 Thread Lucas Zawacki
Hi, so you are the One who can finish off the bug 8754?? :-D I hope so. As soon as my first patches get in I hope things should be working with the keyboard, so if you have access to the NFSU games you should test it. I own force feedback wheel: Logitech Wingman Formula Force GP and did three

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-06-22 Thread Dylan Smith
On Wed, Jun 22, 2011 at 4:08 PM, Stefan Dösinger stefandoesin...@gmx.at wrote: I'll have to do some more background reading on the kind of mesh data structures used here before I can give qualified comments on your patches, so for now I'll yield to Dylan :-) I couldn't actually find

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-06-22 Thread Dylan Smith
On Wed, Jun 22, 2011 at 4:08 PM, Stefan Dösinger stefandoesin...@gmx.at wrote: I'll have to do some more background reading on the kind of mesh data structures used here before I can give qualified comments on your patches, so for now I'll yield to Dylan :-) I looked over the latest patches,