Re: wine bug 27600

2011-06-28 Thread Vincas Miliūnas
On 06/29/2011 01:25 AM, wy...@volny.cz wrote: >> It fails on the #include "winternl.h" line and >> these are standard >> includes, you can try to replace >> >> [code] >> #include >> #include >> [/code] >> >> code fragment with >> >> [code] >> #include "config.h" >> #include "wine/port.h" >> >> #i

Re: wine bug 27600

2011-06-28 Thread wylda
> It fails on the #include "winternl.h" line and > these are standard > includes, you can try to replace > > [code] > #include > #include > [/code] > > code fragment with > > [code] > #include "config.h" > #include "wine/port.h" > > #include > #include > #include > [/code] > > maybe that

Re: gcc 4.6 warning report

2011-06-28 Thread Juan Lang
>> This is a false positive.  h_addr_list is declared as a char **, and >> technically it is, but gethostbyname only returns IPv4 addresses, i.e. >> ones that can fit in a DWORD. > > That doesn't sound like a problem that would give that warning. Why not? A cast of a pointer to a DWORD with 64-bi

Re: wine bug 27600

2011-06-28 Thread Vincas Miliūnas
On 06/29/2011 12:28 AM, wy...@volny.cz wrote: >> Looks like there is some external interference, >> try compiling in a clean >> bash environment; some googling suggests that >> LIBRARY_PATH variable >> should be unset - >> https://bbs.archlinux.org/viewtopic.php?id=30418 >> First be sure it can com

Re: gcc 4.6 warning report

2011-06-28 Thread David Laight
On Tue, Jun 28, 2011 at 12:51:02PM -0700, Juan Lang wrote: > ../../../dlls/netapi32/nbt.c:580:30: warning: cast from pointer to > integer of different size [-Wpointer-to-int-cast] > > This is a false positive. h_addr_list is declared as a char **, and > technically it is, but gethostbyname only r

Re: wine bug 27600

2011-06-28 Thread wylda
> Looks like there is some external interference, > try compiling in a clean > bash environment; some googling suggests that > LIBRARY_PATH variable > should be unset - > https://bbs.archlinux.org/viewtopic.php?id=30418 > First be sure it can compile the original master > branch without issues.

Re: wine bug 27600

2011-06-28 Thread Vincas Miliūnas
On 06/29/2011 12:10 AM, wy...@volny.cz wrote: > So i another try: > * rm -rf * in my git tree. > * git checkout -f 2497a91f6b1326988dd5ea56dc4052cbcc2e521d > * applied all nine patches > * ./tools/make_requests > * configure + make with -O2 and got again: > >> In file included from raw_input.c:28:

Re: wine bug 27600

2011-06-28 Thread wylda
So i another try: * rm -rf * in my git tree. * git checkout -f 2497a91f6b1326988dd5ea56dc4052cbcc2e521d * applied all nine patches * ./tools/make_requests * configure + make with -O2 and got again: > > In file included from raw_input.c:28: > ../include/winternl.h:2359: error: expected > declarati

Re: wine bug 27600

2011-06-28 Thread wylda
> > Did you run ./tools/make_requests ? > > -- > -Austin > Nope. So i did: ./tools/make_requests make distclean ./configure followed by make and got (-O0 issue??): gcc -c -I. -I. -I../include -I../include -D__WINESRC__ -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempt

Re: wine bug 27600

2011-06-28 Thread Austin English
On Tue, Jun 28, 2011 at 13:16, wrote: > > Hi Vincas, i wanted to give bug 27600 a try. So on top of > wine-1.3.23-50-g2497a91 i applied patches: > > 1. 75818 > 2. 75819 > 3. 75831 > 4. 75830 > 5. 75829 > 6. 75820 > 7. 75821 > 8. 75822 > 9. 75823 > > but i end up with failure during the buildup: >

wine bug 27600

2011-06-28 Thread wylda
Hi Vincas, i wanted to give bug 27600 a try. So on top of wine-1.3.23-50-g2497a91 i applied patches: 1. 75818 2. 75819 3. 75831 4. 75830 5. 75829 6. 75820 7. 75821 8. 75822 9. 75823 but i end up with failure during the buildup: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_US

Re: gcc 4.6 warning report

2011-06-28 Thread Juan Lang
../../../dlls/netapi32/nbt.c:580:30: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] This is a false positive. h_addr_list is declared as a char **, and technically it is, but gethostbyname only returns IPv4 addresses, i.e. ones that can fit in a DWORD. --Juan

Re: [PATCH] comctl32: Fixed strncpy (Coverity)

2011-06-28 Thread GOUJON Alexandre
... What is wrong with: buff[0] = 'x'; buff[1] = 0; David and why not buff = { 'x', '\0' };

Re: [PATCH] comctl32: Fixed strncpy (Coverity)

2011-06-28 Thread David Laight
On Tue, Jun 28, 2011 at 09:37:39AM +0200, Michael Stefaniuc wrote: > Hello Marcus, > > On 06/28/2011 09:15 AM, Marcus Meissner wrote: > > This is a 2 CHAR buffer, and we copy in 1 CHAR and \0. So just do that > > via strcpy() and dont confuse the static checker. ... > > -strncpy(buff, "x", siz

Re: [PATCH 3/6] dinput: SetActionMap setting the device buffer (try 2)

2011-06-28 Thread Lucas Zawacki
The new patches address this issue, make some little corrections that are pointed in the comments. Also I organized them better, with the tests first. 2011/6/28 Lucas Zawacki : >> Do you really need to copy it back?  It looks like an input parameter. > > Yes, you're right. In SetActionMap this co

Re: gcc 4.6 warning report

2011-06-28 Thread Vincent Povirk
> ../../../../dlls/gdiplus/tests/image.c: In function ‘test_palette’: > ../../../../dlls/gdiplus/tests/image.c:1773:104: warning: array subscript is > above array bounds [-Warray-bounds] This is because the ColorPalette structure has an array of length 1 at the end, which is really a variable-len

Re: [PATCH 3/6] dinput: SetActionMap setting the device buffer (try 2)

2011-06-28 Thread Lucas Zawacki
> Do you really need to copy it back? It looks like an input parameter. Yes, you're right. In SetActionMap this copy should not be necessary. I'll take this code out and roll a new version of the patches.

Re: [PATCH 3/6] dinput: SetActionMap setting the device buffer (try 2)

2011-06-28 Thread Alexandre Julliard
Lucas Fialho Zawacki writes: > +FIXME("(%p)->(%p,%s,%08x): semi-stub !\n", iface, lpdiaf, lpszUserName, > dwFlags); > + > +diafW.rgoAction = HeapAlloc(GetProcessHeap(), 0, > sizeof(DIACTIONW)*lpdiaf->dwNumActions); > +_copy_diactionformatAtoW(&diafW, lpdiaf); > + > +hr = > IDir

Re: d3dx9/tests: Fix comparison that expects NAN, since NAN != NAN.

2011-06-28 Thread GOUJON Alexandre
On 06/28/2011 10:59 AM, Tijl Coosemans wrote: On Tuesday 28 June 2011 00:40:09 Alexandre Julliard wrote: Dylan Smith writes: @@ -4834,7 +4834,7 @@ static void test_create_skin_info(void) for (i = 0; i< num_influences; i++) { ok(exp_vertices[i] == vertices[i],

Re: d3dx9/tests: Fix comparison that expects NAN, since NAN != NAN.

2011-06-28 Thread Tijl Coosemans
On Tuesday 28 June 2011 00:40:09 Alexandre Julliard wrote: > Dylan Smith writes: >> @@ -4834,7 +4834,7 @@ static void test_create_skin_info(void) >> for (i = 0; i < num_influences; i++) { >> ok(exp_vertices[i] == vertices[i], >> "influence[%d]: exp

Re: [PATCH] comctl32: Fixed strncpy (Coverity)

2011-06-28 Thread Michael Stefaniuc
Hello Marcus, On 06/28/2011 09:15 AM, Marcus Meissner wrote: > This is a 2 CHAR buffer, and we copy in 1 CHAR and \0. So just do that > via strcpy() and dont confuse the static checker. > > CID 1194 > > Ciao, Marcus > --- > dlls/comctl32/tests/treeview.c |2 +- > 1 files changed, 1 insertio