Re: [PATCH 2/2] ntdll: Set restart_scan on first call to NtQueryDirectoryFile.

2011-07-18 Thread Grazvydas Ignotas
On Mon, Jul 18, 2011 at 10:44 PM, Alexandre Julliard wrote: > Grazvydas Ignotas writes: >> It looks like the best way would be to attach state to handle somehow >> (that would be dropped automatically on CloseHandle), but I failed to >> find a way to do so. > > You can't do that either I'm afraid

Re: [PATCH 2/5] d3dx9_36: Improved constant table handle support (try 3)

2011-07-18 Thread Travis Athougies
On Mon, Jul 18, 2011 at 2:41 AM, Alexandre Julliard wrote: > Travis Athougies writes: > >> +static ctab_constant *is_valid_constant(ID3DXConstantTableImpl *This, >> D3DXHANDLE parameter) >> +{ >> +    UINT i; >> + >> +    for (i = 0; i < This->desc.Constants; i++) >> +        if ((ctab_constant

looking for info and advice

2011-07-18 Thread Farmboy0
Hi, As the subject says I am looking for some info about wine. 1) I am trying to understand how wine implements COM objects. I have read the wiki pages on COM and DCOM objects but I am interested in some further assistance. Whats the easiest way to spot a function implementing part of an interfac

Re: [PATCH 2/2] ntdll: Set restart_scan on first call to NtQueryDirectoryFile.

2011-07-18 Thread Alexandre Julliard
Grazvydas Ignotas writes: > You mean fake '.' and '..'? Yes. > Do you have any suggestions how to track state between calls? > I'm thinking about using global structure to track dev_t, ino_t and > off_t (and maybe handle), and if any of those changes since last exit > from the function consider

Re: Rejected or commited?

2011-07-18 Thread Alexandre Julliard
wy...@volny.cz writes: > Hi, > > I just noticed that patch 76524 is "Rejected". > > But there is the same patch commited as > 48d03555a7a6931ee8ba0952ccb92c70925c6bed. > > Duno, if some other patch should not be merged instead. The first one was supposed to be committed, but not the second. I'll

Rejected or commited?

2011-07-18 Thread wylda
Hi, I just noticed that patch 76524 is "Rejected". But there is the same patch commited as 48d03555a7a6931ee8ba0952ccb92c70925c6bed. Duno, if some other patch should not be merged instead. Regards, W. -- Sháníte letenky na pracovní cestu, dovolenou či jen na výlet? Na http://letenky.volny.c

Re: [PATCH 2/2] ntdll: Set restart_scan on first call to NtQueryDirectoryFile.

2011-07-18 Thread Grazvydas Ignotas
On Mon, Jul 18, 2011 at 1:41 PM, Alexandre Julliard wrote: > Grazvydas Ignotas writes: > >> @@ -2004,6 +2004,8 @@ NTSTATUS WINAPI NtQueryDirectoryFile( HANDLE handle, >> HANDLE event, >>          fstat( fd, &st ); >>          curdir.dev = st.st_dev; >>          curdir.ino = st.st_ino; >> +      

Re: jscript: Properly handle aggregation attempt

2011-07-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12575 Your paranoid android

Re: [PATCH 3/3] vbscript: Added creation tests

2011-07-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12573 Your paranoid android

Re: mshtml: Added IHTMLStyle::pageBreakAfter property implementation

2011-07-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12568 Your paranoid android

Re: [PATCH 02/10] ntdll/tests: add a test for STATUS_OBJECT_TYPE_MISMATCH

2011-07-18 Thread Alexandre Julliard
Bernhard Loos writes: > @@ -774,6 +775,28 @@ static void test_query_object(void) > pNtClose( handle ); > } > > +static void test_type_mismatch(void) > +{ > +HANDLE h; > +NTSTATUS res; > + OBJECT_ATTRIBUTES attr; > + > + attr.Length = sizeof(attr); > +

Re: [PATCH 2/2] ntdll: Set restart_scan on first call to NtQueryDirectoryFile.

2011-07-18 Thread Alexandre Julliard
Grazvydas Ignotas writes: > @@ -2004,6 +2004,8 @@ NTSTATUS WINAPI NtQueryDirectoryFile( HANDLE handle, > HANDLE event, > fstat( fd, &st ); > curdir.dev = st.st_dev; > curdir.ino = st.st_ino; > +if (lseek( fd, 0, SEEK_CUR ) == 0) > +restart_scan = TR

Re: [PATCH 2/4] dsound/tests: Add tests to check notifications after duplicate.

2011-07-18 Thread Alexandre Julliard
Akihiro Sagawa writes: > --- > dlls/dsound/tests/dsound.c | 178 > > 1 files changed, 178 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M dsound.dll -T ../../.. -p dsound_test.exe.so dsound.c && touch dsou

Re: [1/2] user32: handle %I... formats in user32.wsprintf* (try 2)

2011-07-18 Thread Alexandre Julliard
Dan Kegel writes: > +i64 = 0x1LL; Don't use LL constants. > @@ -257,14 +282,25 @@ static UINT WPRINTF_GetLen( WPRINTF_FORMAT *format, > WPRINTF_DATA *arg, > case WPR_SIGNED: > len = sprintf( number, "%d", arg->int_view ); > break; > +case WPR_SIGNED64: >

Re: mshtml: Implment IHTMLDocument2 elementFromPoint

2011-07-18 Thread Jacek Caban
Hi Alistair, On 07/18/11 06:29, Alistair Leslie-Hughes wrote: > Hi, > Fixmes http://bugs.winehq.org/show_bug.cgi?id=27682 > > > Changelog: > mshtml: Implment IHTMLDocument2 elementFromPoint > First of all, tests please. + nsIDOMElement *nselem = NULL; + nsresult nsres; +

Re: [PATCH 01/11] wscript: fixed running script from outside its directory (resend)

2011-07-18 Thread Alexandre Julliard
Michał Ziętek writes: > @@ -347,7 +347,7 @@ int WINAPI wWinMain(HINSTANCE hInst, HINSTANCE hPrevInst, > LPWSTR cmdline, int cm > return 1; > } > > -ext = strchrW(filename, '.'); > +ext = strrchrW(filename, '.'); That's not much better. -- Alexandre Julliard julli...@wi

Re: [PATCH 2/5] d3dx9_36: Improved constant table handle support (try 3)

2011-07-18 Thread Alexandre Julliard
Travis Athougies writes: > +static ctab_constant *is_valid_constant(ID3DXConstantTableImpl *This, > D3DXHANDLE parameter) > +{ > +UINT i; > + > +for (i = 0; i < This->desc.Constants; i++) > +if ((ctab_constant *)parameter == &This->constants[i]) > +return (ctab_consta

Re: mshtml: Handle the failure case in get_nsstyle_attr.

2011-07-18 Thread Jacek Caban
Hi Gerald, On 07/15/11 22:49, Gerald Pfeifer wrote: > --- > dlls/mshtml/htmlstyle.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c > index cd1f6b5..3e76e61 100644 > --- a/dlls/mshtml/htmlstyle.c > +++ b/dlls/mshtml/