re: po: Mark translations with mismatched printf format directives as fuzzy.

2011-09-25 Thread Dan Kegel
Patch fails to apply here? error: patch failed: po/ko.po:11305 error: po/ko.po: patch does not apply -- Forwarded message -- From: Date: Sun, Sep 25, 2011 at 5:35 PM Subject: Re: 79310: po: Mark translations with mismatched printf format directives as fuzzy. To: d...@kegel.com

Re: [PATCH 1/5] cmd/tests: add tests for command line parsing

2011-09-25 Thread Frédéric Delanoy
2011/9/25 Frédéric Delanoy : > This patch fails; see http://source.winehq.org/patches/ and > http://source.winehq.org/patches/data/79288.testfail > > Got a lot of errors on NT4, and 1 on other systems > batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 > (got 'THIS FAILS: cmd ign

Re: [PATCH 2/9] cmd: use GetCommandline() rather than argv

2011-09-25 Thread Martin Wilck
Hi Dan, (re-cc'ing wine-devel) > Running it through the buildbot now... seems ok on first two tries, so > you may have accidentally fixed the problem. I'll resubmit to wine-patches shortly, probably tonight. >> > I ran the stuff through the bot, 0 errors everywhere except on NT (NT >> > fails t

Re: user32/tests: Don't test function directly when reporting GetLastError()

2011-09-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14502 Your paranoid android

Re: gdi32: Add traces for the gamma functions

2011-09-25 Thread André Hentschel
Am 25.09.2011 21:20, schrieb Dan Kegel: > Looks like you forgot something: > > cc1: warnings being treated as errors > dc.c: In function ‘GetDeviceGammaRamp’: > dc.c:1289: error: too few arguments for format > dc.c: In function ‘SetDeviceGammaRamp’: > dc.c:1307: error: too few arguments for format

re: gdi32: Add traces for the gamma functions

2011-09-25 Thread Dan Kegel
Looks like you forgot something: cc1: warnings being treated as errors dc.c: In function ‘GetDeviceGammaRamp’: dc.c:1289: error: too few arguments for format dc.c: In function ‘SetDeviceGammaRamp’: dc.c:1307: error: too few arguments for format make[1]: *** [dc.o] Error 1 -- Forwarded me

Re: [PATCH 4/5] cmd: fix handling of special characters in command line

2011-09-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14498 Your paranoid android

Re: [PATCH 5/5] cmd: fix parameter parsing of quotes and special chars

2011-09-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14499 Your paranoid android

Re: [PATCH 1/5] cmd/tests: add tests for command line parsing

2011-09-25 Thread Frédéric Delanoy
This patch fails; see http://source.winehq.org/patches/ and http://source.winehq.org/patches/data/79288.testfail Got a lot of errors on NT4, and 1 on other systems batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@' You

Re: [PATCH 3/5] cmd: improve parsing of quotes in command line

2011-09-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14497 Your paranoid android

Re: [PATCH 2/9] cmd: use GetCommandline() rather than argv

2011-09-25 Thread Dan Kegel
On Sun, Sep 25, 2011 at 5:51 AM, Martin Wilck wrote: >> Did you follow http://wiki.winehq.org/Wine_and_Valgrind ? >> Feel free to ask questions. > > Yes, I did. I am seeing no regressions (read: additional warnings and/or > errors) between the trunk and my patched version. Great. BTW I'd suggest

Re: [PATCH 2/5] cmd: use GetCommandline() rather than argv

2011-09-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14496 Your paranoid android

Re: crypt32: Cryptic string resources

2011-09-25 Thread Ben Peddell
On 25/09/2011 6:29 PM, Francois Gouget wrote: > > Are these strings seem to be lacking spaces a bit. Are they real names > or mere identifiers? Are they actually translatable? > > dlls/crypt32/crypt32.rc: > IDS_SPC_SP_AGENCY_INFO "SpcSpAgencyInfo" > IDS_SPC_FINANCIAL_CRITERIA "SpcFinanci

Re: [PATCH 1/5] cmd/tests: add tests for command line parsing

2011-09-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14495 Your paranoid android

Re: advpack: Only do_ocx_reg (and thus DllRegisterServer) from RegisterOCX when 'N' is passed as a flag. Clarify documentation.

2011-09-25 Thread James Hawkins
I recommend writing unit tests to answer the open questions. Thanks, James On Sat, Sep 24, 2011 at 2:46 PM, Gerald Pfeifer wrote: > Hi James, > > On Thu, 13 May 2010, Gerald Pfeifer wrote: >> Would you feel more comfortable leaving the documentation as is and >> me just suggesting the following?

Re: advpack: Only do_ocx_reg (and thus DllRegisterServer) from RegisterOCX when 'N' is passed as a flag. Clarify documentation.

2011-09-25 Thread Gerald Pfeifer
Hi James, On Thu, 13 May 2010, Gerald Pfeifer wrote: > Would you feel more comfortable leaving the documentation as is and > me just suggesting the following? > > if(strchrW(str_flags,'I')) > hr = do_ocx_reg(hm, TRUE); > > to replace > > hr = do_ocx_reg(hm, TRUE); > > ? > > >

crypt32: Cryptic string resources

2011-09-25 Thread Francois Gouget
Are these strings seem to be lacking spaces a bit. Are they real names or mere identifiers? Are they actually translatable? dlls/crypt32/crypt32.rc: IDS_SPC_SP_AGENCY_INFO "SpcSpAgencyInfo" IDS_SPC_FINANCIAL_CRITERIA "SpcFinancialCriteria" IDS_SPC_MINIMAL_CRITERIA "SpcMinimalCriteria