[RFC] Use ICU in wine ?

2011-10-10 Thread Rafał Mużyło
Right now, wine claims to use DUCET data for lingustic sorting, but by section 1.9.2 of that document (as of version 6.0.0), uses it in a wrong way. The result of it are bugs such as #10767 and #9583. A possible way around it would beby using ICU to get language specific tailoring and applying

Re: [ 3/3] ddraw: Keep track of interface attached by AddAttachedSurface and detach correct interface when parent is released.

2011-10-10 Thread Henri Verbeet
On 10 October 2011 08:07, Octavian Voicu octavian.vo...@gmail.com wrote: +static HRESULT delete_attached_surface_helper(IDirectDrawSurfaceImpl *root, IDirectDrawSurfaceImpl *detach) +{ +    if (detach-attached_iface == detach-IDirectDrawSurface4_iface) +        return

Re: [RFC] Use ICU in wine ?

2011-10-10 Thread Dmitry Timoshkov
Rafał Mużyło galtge...@o2.pl wrote: Right now, wine claims to use DUCET data for lingustic sorting, What's DUCET and where do you see Wine does claim to use it? but by section 1.9.2 of that document (as of version 6.0.0), uses it in a wrong way. Could you please be slightly more specific?

Re: [1/5] d3d8: Never announce support for palettized textures

2011-10-10 Thread Henri Verbeet
On 9 October 2011 17:31, Stefan Dösinger ste...@codeweavers.com wrote:   - I can't say I find e.g. sprinkling d3dformat_is_palettized() over the code particularly elegant. I suppose I could check for it in IDirect3DDevice8Impl_CreateSurface(and the d3d9 equivalent), if all calls that create

Re: [ 3/3] ddraw: Keep track of interface attached by AddAttachedSurface and detach correct interface when parent is released.

2011-10-10 Thread Octavian Voicu
On Mon, Oct 10, 2011 at 10:04 AM, Henri Verbeet hverb...@gmail.com wrote: Can't you just handle this in ddraw_surface_delete_attached_surface()? I.e., replace the Release calls in ddraw_surface?_DeleteAttachedSurface() with a IUnknown_Release(Surf-attached_iface) in

Re: [1/5] d3d8: Never announce support for palettized textures

2011-10-10 Thread Stefan Dösinger
On Monday 10 October 2011 10:20:15 Henri Verbeet wrote: It's not really clear to me that refusing to create P8 surfaces in d3d8/9 really gains us much, or that it's really a prerequisite for the other patches. I guess you've got a point here, if we just allow the surfaces we'll end up with the

DEVELOPMENTAL: use uniscribe in the edit control

2011-10-10 Thread Aric Stewart
This patch is experimental but people had some interest in testing it and I would love some more testing. What is currently known not to be working: * Tabs * Font Fallback * Complex composed glyphs are not breaking or highlighting properly. Testing is appreceated. Send me crashes or

Re: [PATCH] ntdll: deal with images which override the section table during mapping

2011-10-10 Thread Marcus Meissner
On Mon, Oct 10, 2011 at 11:36:33AM +0200, Bernhard Loos wrote: --- dlls/ntdll/virtual.c | 38 ++ 1 files changed, 34 insertions(+), 4 deletions(-) I think this needs tests, the algorithms are very fragile. Ciao, Marcus diff --git a/dlls/ntdll/virtual.c

Re: mscoree: Implement ICorDebug SetManagedHandler (try 3)

2011-10-10 Thread Vincent Povirk
Should SetManagedHandler really fail if the given object doesn't support ICorDebugManagedCallback2 ? You've got a stray whitespace change in RuntimeHost_Destroy. Otherwise, this looks good to me. On Mon, Oct 10, 2011 at 5:12 AM, Alistair Leslie-Hughes leslie_alist...@hotmail.com wrote: Hi,

[RFC] Use ICU in wine ?

2011-10-10 Thread Rafał Mużyło
On Mon, Oct 10, 2011 at 04:16:26PM +0900, Dmitry Timoshkov wrote (and contradicted himself): What's DUCET and where do you see Wine does claim to use it? DUCET: Default Unicode Collation Element Table http://bugs.winehq.org/show_bug.cgi?id=10767#c1 but by section 1.9.2 of that document (as

[RFC] Use ICU in wine ?

2011-10-10 Thread Rafał Mużyło
On Mon, Oct 10, 2011 at 04:16:26PM +0900, Dmitry Timoshkov wrote (and contradicted himself): What's DUCET and where do you see Wine does claim to use it? DUCET: Default Unicode Collation Element Table http://bugs.winehq.org/show_bug.cgi?id=10767#c1 but by section 1.9.2 of that document (as

Re: [RFC] Use ICU in wine ?

2011-10-10 Thread Shachar Shemesh
On 10/10/2011 02:48 AM, Rafał Mużyło wrote: Right now, wine claims to use DUCET data for lingustic sorting, but by section 1.9.2 of that document (as of version 6.0.0), uses it in a wrong way. The result of it are bugs such as #10767 and #9583. A possible way around it would beby using ICU to

Re: [RFC] Use ICU in wine ?

2011-10-10 Thread André Hentschel
Am 10.10.2011 17:33, schrieb Rafał Mużyło: Anyway, if DUCET and Windows default differ is dumping that default even allowed ? I don't think so... I once was hacking on our collation stuff too to fix http://bugs.winehq.org/show_bug.cgi?id=5163 but i guess dumping the windows stuff wouldn't even

Re: mscoree: Implement ICorDebug SetManagedHandler (try 3)

2011-10-10 Thread Alistair Leslie-Hughes
On 11/10/2011 2:07 AM, Vincent Povirk wrote: Should SetManagedHandler really fail if the given object doesn't support ICorDebugManagedCallback2 ? Yes, this is a requirement for debugging .NET 2 applications. Best Regards Alistair Leslie-Hughes

Re: mscoree: Implement ICorDebug SetManagedHandler (try 3)

2011-10-10 Thread Vincent Povirk
Can we have a WARN message in case of .NET 1 applications? On Mon, Oct 10, 2011 at 2:36 PM, Alistair Leslie-Hughes leslie_alist...@hotmail.com wrote: On 11/10/2011 2:07 AM, Vincent Povirk wrote: Should SetManagedHandler really fail if the given object doesn't support ICorDebugManagedCallback2

winex11.drv/keyboard: MAPVK_VK_TO_CHAR direct mapping

2011-10-10 Thread Sebastian Riemer
Hi developers, I've just sent my first patch I would like to see in mainline. I did quite some efforts to verify that my patch is correct by doing extensive compares with Windows, the wine before and the patched wine as well as a special testing version of wine. I want to fix this bug

Re: winex11.drv/keyboard: MAPVK_VK_TO_CHAR correction (Bug 28168)

2011-10-10 Thread Frédéric Delanoy
On Mon, Oct 10, 2011 at 22:46, sebastian.rie...@gmx.de wrote: ---  dlls/winex11.drv/keyboard.c |  563 ++-  1 files changed, 499 insertions(+), 64 deletions(-) Please follow patch submission rules from http://wiki.winehq.org/SubmittingPatches