Re: [PATCH 1/5] wined3d: Don't apply fixups to converted surfaces.

2011-11-25 Thread Stefan Dösinger
Am Freitag, 25. November 2011, 20:23:01 schrieb Henri Verbeet: > > I don't think this is correct. E.g. signed formats without > > GL_NV_texture_shader have load time and read time fixups and both have to > > be applied. > > That's silly. If that's really the case that should be fixed. I don't see

Re: [PATCH 1/5] wined3d: Don't apply fixups to converted surfaces.

2011-11-25 Thread Henri Verbeet
On 25 November 2011 19:50, Stefan Dösinger wrote: > Am Donnerstag, 24. November 2011, 22:52:32 schrieb Henri Verbeet: >> +    if (surface->flags & SFLAG_CONVERTED) >> +    { >> +        ENTER_GL(); >> +        glEnable(textype); >> +        checkGLcall("glEnable(textype)"); >> +        LEAVE_GL();

Re: [PATCH] kernel32: implement GetLogicalProcessorInformation

2011-11-25 Thread Charles Davis
On Nov 25, 2011, at 8:17 AM, Claudio Fontana wrote: > On Fri, Nov 25, 2011 at 4:07 PM, Claudio Fontana > wrote: >> I have resent the patch as a "try 2" (there was a try 1.5 to fix test >> issues under windows older than XP SP3). >> >> The patch contains changes based on your feedback. > > Whic

Re: [PATCH 1/5] wined3d: Don't apply fixups to converted surfaces.

2011-11-25 Thread Stefan Dösinger
Am Donnerstag, 24. November 2011, 22:52:32 schrieb Henri Verbeet: > +if (surface->flags & SFLAG_CONVERTED) > +{ > +ENTER_GL(); > +glEnable(textype); > +checkGLcall("glEnable(textype)"); > +LEAVE_GL(); > +return WINED3D_OK; > +} I don't think this

Re: dinput: Stub IDirectInputJoyConfig8 interface. (try 2)

2011-11-25 Thread Vitaliy Margolen
On 11/25/2011 04:14 AM, Jacek Caban wrote: Hi Vitaliy, On 11/25/11 04:17, Vitaliy Margolen wrote: Fix QueryInterface, simplify use of AddRef, and replace "LPDIRECTINPUTJOYCONFIG8" with "IDirectInputJoyConfig8 *". --- dlls/dinput/dinput_main.c | 7 ++ dlls/dinput/dinput_private.h | 2 + dlls/dinpu

Re: [1/2] kernel32: Add a test for protections accepted by CreateFileMapping, make it pass under Wine.

2011-11-25 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> > @@ -350,9 +350,6 @@ HANDLE WINAPI CreateFileMappingW( HANDLE hFile, >> > LPSECURITY_ATTRIBUTES sa, >> > >> > switch(protect) >> > { >> > -case 0: >> > -protect = PAGE_READONLY; /* Win9x compatibility */ >> > -

Re: [1/2] kernel32: Add a test for protections accepted by CreateFileMapping, make it pass under Wine.

2011-11-25 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > @@ -350,9 +350,6 @@ HANDLE WINAPI CreateFileMappingW( HANDLE hFile, > > LPSECURITY_ATTRIBUTES sa, > > > > switch(protect) > > { > > -case 0: > > -protect = PAGE_READONLY; /* Win9x compatibility */ > > -/* fall through */ > > Did you

Re: [1/2] kernel32: Add a test for protections accepted by CreateFileMapping, make it pass under Wine.

2011-11-25 Thread Alexandre Julliard
Dmitry Timoshkov writes: > @@ -350,9 +350,6 @@ HANDLE WINAPI CreateFileMappingW( HANDLE hFile, > LPSECURITY_ATTRIBUTES sa, > > switch(protect) > { > -case 0: > -protect = PAGE_READONLY; /* Win9x compatibility */ > -/* fall through */ Did you try your test on Win

Re: [PATCH] server: assert on failure to open /dev/null (Coverity)

2011-11-25 Thread Alexandre Julliard
Eric Pouech writes: > Marcus, > > IMO,fatal_error() should be preferred over assert() (hoping that > fatal_error() is actually marked as no_return) There's no reason to have an error here, it will still work fine even if we can't open /dev/null. -- Alexandre Julliard julli...@winehq.org

Re: dinput: Stub IDirectInputJoyConfig8 interface. (try 2)

2011-11-25 Thread Jacek Caban
Hi Vitaliy, On 11/25/11 04:17, Vitaliy Margolen wrote: Fix QueryInterface, simplify use of AddRef, and replace "LPDIRECTINPUTJOYCONFIG8" with "IDirectInputJoyConfig8 *". --- dlls/dinput/dinput_main.c|7 ++ dlls/dinput/dinput_private.h |2 + dlls/dinput/joystick.c | 196 ++

Re: [PATCH] server: assert on failure to open /dev/null (Coverity)

2011-11-25 Thread Eric Pouech
Marcus, IMO,fatal_error() should be preferred over assert() (hoping that fatal_error() is actually marked as no_return) A+ 2011/11/25 Marcus Meissner > Hi, > > if we cannot open /dev/null something is really broken. > CID 5470 > > Ciao, Marcus > --- > server/request.c |1 + > 1 files chang