Re: [2/2] winecfg: Bump NT 3.51 to Service Pack 5

2011-12-01 Thread Vitaliy Margolen
On 12/01/2011 12:15 PM, André Hentschel wrote: --- -{ "nt351", "Windows NT 3.5",3, 51, 0x421, VER_PLATFORM_WIN32_NT, "Service Pack 2", 0, 0, "WinNT"}, +{ "nt351", "Windows NT 3.51", 3, 51, 0x421, VER_PLATFORM_WIN32_NT, "Service Pack 5", 5, 0, "WinNT"}, You need to do

Re: shell32/tests: Initialize all fields of SHFILEOPSTRUCT variables (Coverity)

2011-12-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15738 Your paranoid android

Re: Patch for #29144

2011-12-01 Thread Damian Ivanov
Thank you! I'll test it and include it with my this Saturday. Best regards On Dec 1, 2011 10:50 AM, "Aurélien COUDERC" wrote: > Please find an attached patch for #29144. > > It probably fixes a hole range of freezes with fglrx (Tested on Sykrim and > Might & Magic Heroes VI for instance). > > R

Re: [PATCH 3/3] ddraw/tests: Add a IDirect3DDevice7 GetCaps test

2011-12-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15731 Your paranoid android

Re: [PATCH 3/3] ddraw/tests: Add a IDirect3DDevice7 GetCaps test

2011-12-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15731 Your paranoid android

Re: [PATCH 3/3] ddraw/tests: Add a IDirect3DDevice2 GetCaps test

2011-12-01 Thread Stefan Dösinger
Am Donnerstag, 1. Dezember 2011, 15:15:23 schrieb Henri Verbeet: > If we're going to redo the way the tests work anyway, we probably > shouldn't reuse the same objects for everything either. You mean reinitialize ddraw/d3d for every test? I'm not sure if that's a good idea(or enough, depending on

Re: [2/2] kernel32: Add a bunch of VirtualProtect tests on a memory-mapped file. Resend.

2011-12-01 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > That's a good start, but it would be interesting to try this with > various combinations of CreateFileMapping/MapViewOfFile protections, as > I expect that the mapping protections would influence what you can then > do in VirtualProtect. Once this test is committed I'

Re: [PATCH 3/3] ddraw/tests: Add a IDirect3DDevice2 GetCaps test

2011-12-01 Thread Henri Verbeet
On 1 December 2011 11:57, Stefan Dösinger wrote: > An IDirect3DDevice3 test will follow once the d3d initialization design has > been approved. > If we're going to redo the way the tests work anyway, we probably shouldn't reuse the same objects for everything either.

Re: [PATCH 1/3] ddraw: Size handling fixes for IDirect3DDevice::GetDesc (try 3)

2011-12-01 Thread Henri Verbeet
On 1 December 2011 11:51, Stefan Dösinger wrote: > Subject: [PATCH 1/3] ddraw: Size handling fixes for IDirect3DDevice::GetDesc There is no IDirect3DDevice::GetDesc(). > +    if(size == 172 || size == 204 || size == sizeof(D3DDEVICEDESC) /* 252 > */) return TRUE; Please fix the formatting here a

Re: [2/2] kernel32: Add a bunch of VirtualProtect tests on a memory-mapped file. Resend.

2011-12-01 Thread Alexandre Julliard
Dmitry Timoshkov writes: > --- > dlls/kernel32/tests/virtual.c | 187 +--- > 1 files changed, 154 insertions(+), 33 deletions(-) That's a good start, but it would be interesting to try this with various combinations of CreateFileMapping/MapViewOfFile protect

Re: [PATCH 2/3] ddraw/tests: Add a IDirect3DDevice7 GetCaps test

2011-12-01 Thread Stefan Dösinger
Am Donnerstag, 1. Dezember 2011, 13:30:56 schrieb Marvin: > === WINEBUILD (build) === > Patch failed to apply Apparently git send-email doesn't help with the encoding, even though it explicitly asked me if I want to send the mails with UTF-8 encoding. I have submitted those 3 patches to the testb

Re: [PATCH 2/3] ddraw/tests: Add a IDirect3DDevice7 GetCaps test

2011-12-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15726 Your paranoid android

Re: [PATCH 3/3] ddraw/tests: Add a IDirect3DDevice2 GetCaps test

2011-12-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15727 Your paranoid android

Re: difficulties compiling or installing git on precise pagolin

2011-12-01 Thread Jerome Leclanche
Scott Richie is in charge of that. I would wait a bit though, from what I remember he's finishing the transition from ia32-libs. Just install the deps manually for now? JL On Thu, Dec 1, 2011 at 12:07 PM, Susan Cragin wrote: > In the development version of ubuntu, wine can neither be compiled n

Re: [3/3] ddraw/tests: Add a IDirect3DDevice2 GetCaps test

2011-12-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15723 Your paranoid android

difficulties compiling or installing git on precise pagolin

2011-12-01 Thread Susan Cragin
In the development version of ubuntu, wine can neither be compiled nor installed. ~$ sudo apt-get build-dep wine1.3 [sudo] password for susan: Reading package lists... Done Building dependency tree Reading state information... Done The following packages have unmet dependencies: ia32-li

Re: [2/3] ddraw/tests: Add a IDirect3DDevice7 GetCaps test

2011-12-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15722 Your paranoid android

Re: Patch for #29144

2011-12-01 Thread Henri Verbeet
2011/12/1 Aurélien COUDERC : > @@ -5189,7 +5189,7 @@ static void fillGLAttribFuncs(const struct > wined3d_gl_info *gl_info) > multi_texcoord_funcs[WINED3D_FFP_EMIT_USHORT4N] = invalid_texcoord_func; > multi_texcoord_funcs[WINED3D_FFP_EMIT_UDEC3] = invalid_texcoord_func; > multi

Re: Patch for #29144

2011-12-01 Thread Frédéric Delanoy
2011/12/1 Aurélien COUDERC : > Please find an attached patch for #29144. > > It probably fixes a hole range of freezes with fglrx (Tested on Sykrim and > Might & Magic Heroes VI for instance). Please follow WineHQ Patch submission guidelines as described on http://wiki.winehq.org/SubmittingPatches