Re: [2/4](resend)strmbase: implement BaseControlWindow

2012-03-15 Thread Nikolay Sivov
On 3/16/2012 04:00, Aric Stewart wrote: +HRESULT WINAPI BaseControlWindowImpl_GetTypeInfo(IVideoWindow *iface, UINT iTInfo, LCID lcid, ITypeInfo**ppTInfo) +{ +BaseControlWindow* This = (BaseControlWindow*)iface; + It doesn't look like a normal COM interface (lack of refcount for example, a

Re: [PATCH 2/8] amstream/tests: Make test.avi filename an unicode string and test the file presence once for all.

2012-03-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17386 Your paranoid android

Re: [PATCH 8/8] amstream/tests: Add some tests to retreive media streams to media stream filter.

2012-03-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17392 Your paranoid android

Re: [PATCH 7/8] amstream: Implement IAMMultiMediaStreamImpl_AddMediaStream + add tests.

2012-03-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17391 Your paranoid android

Re: [PATCH 6/8] amstream: No media stream is created when the defaut renderer is used.

2012-03-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17390 Your paranoid android

Re: [PATCH 5/8] amstream: Video streams do not support default renderer.

2012-03-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17389 Your paranoid android

Re: [PATCH 4/8] amstream: Check purpose id in AddMediaStream.

2012-03-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17388 Your paranoid android

Re: [PATCH 3/8] amstream/tests: Add media streams tests.

2012-03-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17387 Your paranoid android

Re: po: Update Korean translation

2012-03-15 Thread Frédéric Delanoy
On Wed, Mar 14, 2012 at 13:31, Hwang YunSong(황윤성) wrote: > fuzzy sections translated > Please remove the "#| msgid" comment lines (previous msgid) and resubmit.

Re: kernel32: add a stub for InitializeConditionVariable

2012-03-15 Thread Dmitry Timoshkov
Austin English wrote: > +VOID WINAPI InitializeConditionVariable(PCONDITION_VARIABLE variable) > +{ > +FIXME("stub: %p\n", variable); > +variable = NULL; > +} 'variable = NULL;' is a nop, you may need to add a real initialization. -- Dmitry.

Re: wpp: Stop parsing single and double quoted string constants after a first newline character.

2012-03-15 Thread Józef Kucia
On Thu, Mar 15, 2012 at 12:55 PM, Matteo Bruni wrote: > So, I guess this change will only have any effect on non-standard > complying sources, and in the specific case of asm-style comments, it > brings us the behavior we want. On the other hand, it also actually > turns an error (unexpected end o

Re: kernel32/tests: Verify the stability of CreateTimerQueue.

2012-03-15 Thread Alexandre Julliard
joerg-cyril.hoe...@t-systems.com writes: > What do you suggest? > a) remove if(winetest...) and always execute the average test > - Live with occasional failures when the Linux scheduler decides so. >(This is not unlike audio glitches when sometimes, Linux wakes up a thread > after 100ms onl

Re: Web based translation tool

2012-03-15 Thread Nicolas Le Cam
Le 15 mars 2012 16:12, Aric Stewart a écrit : > Hi Yaron, > > Thanks for continuing to push this forward. I have been a bit swamped > recently.  The thing is that there are several projects who are all JUST on > the edge of being able to do what we need but none that are there yet. > > I got an e-

Re: [PATCH 1/4] mshtml: Get rid of PRBool in nsiface.idl

2012-03-15 Thread Henri Verbeet
On 15 March 2012 11:54, Jacek Caban wrote: > > +typedef unsigned char cpp_bool; > +#define bool cpp_bool > +cpp_quote("#define PRBool cpp_bool") /* FIXME */ Is there any chance this is going to conflict with bool from stdbool.h? Technically that's C99, and we don't use C99, but I imagine it could

Re: Web based translation tool

2012-03-15 Thread Aric Stewart
Hi Yaron, Thanks for continuing to push this forward. I have been a bit swamped recently. The thing is that there are several projects who are all JUST on the edge of being able to do what we need but none that are there yet. I got an e-mail from a pootle developer saying that they are doing

Re: [PATCH 2/2] ieframe: Added EnumVerbs tests

2012-03-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17375 Your paranoid android

Re: [PATCH 2/2] ieframe: Added EnumVerbs tests

2012-03-15 Thread Jacek Caban
On 03/15/12 13:18, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/

Re: wpp: Stop parsing single and double quoted string constants after a first newline character.

2012-03-15 Thread Matteo Bruni
Il 14 marzo 2012 23:02, Józef Kucia ha scritto: > @@ -679,11 +649,23 @@ void pp_writestring(const char *format, ...) >                } >        } >  \\.      add_string(ppy_text, ppy_leng); > -\n       { > +\n             { >                newline(1); >                add_string(ppy_text, ppy_le

Re: Web based translation tool

2012-03-15 Thread Yaron Shahrabani
Hey guys! Sorry for being so pushy but please tell me who do I need to talk to in order to push this forward. I can't use my Linux machine during the week and I don't have time to create patches, establishing a Web interface will help me improve and maintain the Hebrew translation of Wine. Thanks

Re: kernel32/tests: Verify the stability of CreateTimerQueue.

2012-03-15 Thread Joerg-Cyril . Hoehle
Hi, >sometimes one DeleteTimerQueueTimer(INVALID_HANDLE_VALUE) >fails (presumably with IO_PENDING) because a callback was executing >concurrently. This random failure rose an alarm. I looked at it further and found out that the current testsuite is not complete enough to demonstrate that given IN