Re: [PATCH 1/5] winex11: Use GLX_DONT_CARE instead of ~0 in ConvertAttribWGLtoGLX().

2012-03-27 Thread Chris Robinson
On Tuesday, March 27, 2012 8:35:49 PM Henri Verbeet wrote: > - int pixelattrib = ~0; > + int pixelattrib = GLX_DONT_CARE; I want to say there's a reason we used ~0 instead of GLX_DONT_CARE, but it's been too long that I can't remember. I think it was because GLX_DONT_CARE didn't include all po

'Pending' patches state

2012-03-27 Thread Dmitry Timoshkov
Hello, http://source.winehq.org/patches has the following legend for the Pending patch status: Pending * The patch is not obviously correct at first glance. Making a more convincing argument, preferably in the form of a test case, may help. * Waiting for feedback from the main developer in that

Re: po: Update German translation

2012-03-27 Thread Julian Rüger
Hi André, Am Dienstag, den 27.03.2012, 21:43 +0200 schrieb André Hentschel: > --- > po/de.po |7 +++ > 1 files changed, 3 insertions(+), 4 deletions(-) > > #: jscript.rc:37 >-#, fuzzy > #| msgid "Invalid parameter.\n" > msgid "Invalid character" >-msgstr "Ungültiger Parameter.\n" >+msgst

Re: [PATCH] devenum: Add tests for devenum. (try 2)

2012-03-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17512 Your paranoid android

Re: [PATCH] devenum: Add tests for devenum.

2012-03-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17507 Your paranoid android

Re: Web based translation tool

2012-03-27 Thread Michal Čihař
Hi Dne Tue, 27 Mar 2012 00:00:04 +0200 Frédéric Delanoy napsal(a): > On Mon, Mar 26, 2012 at 16:23, Michal Čihař wrote: > > It turned out such feature seems to be important for more projects, so I > > will end up implementing some way of merging of commits for 1.0. > > Details can be found at h

Re: [PATCH 1/2] winmm: Support DRVM_MAPPER_PREFERRED_GET in waveXxxMessage

2012-03-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17495 Your paranoid android

Would like to get some feedback on GSOC idea

2012-03-27 Thread M C
Hi everyone, My name is Marek Chmiel, I am a student a NEIU. I am studying computer science and network security related topics. This semester I had spent a fair amount of time writing crypt related functions with java, and became very interested in Cryptography. After looking over the suggested i

RFC: Duplicate in/out device naming

2012-03-27 Thread Andrew Eikum
I'm working on Bug 14559 and have run into an interesting UI problem. In WinMM, there are three "classes" of devices: waveIn, waveOut, and mixer. Windows 7's WinMM implementation provides one mixer for each waveIn and waveOut device. The "WCHAR caps.szPname[32]" field for the matching mixer and w

Re: winex11.drv: Do not trash existing clip rectangle if XInput2 is not available.

2012-03-27 Thread Alexandre Julliard
Vitaliy Margolen writes: > On 03/27/2012 08:04 AM, Alexandre Julliard wrote: >> Vitaliy Margolen writes: >> >>> Dinput needs to talk to x11drv directly to get xi2 events. Same for >>> requests to clip cursor in exclusive mode. The current method of using >>> hooks can stay for backwards compatib

Re: [PATCH] mciqtz: Actually assign result to the output structure

2012-03-27 Thread Aric Stewart
Hi Joerg, Cool, but what I could use is concrete test cases with reported failures. Could you give me some example scripts, maybe with accompanying media files, with the issues pointed out. You could give me where the expected behavior does not match the existing behavior. clear tests and

Re: winex11.drv: Do not trash existing clip rectangle if XInput2 is not available.

2012-03-27 Thread Vitaliy Margolen
On 03/27/2012 08:04 AM, Alexandre Julliard wrote: Vitaliy Margolen writes: Dinput needs to talk to x11drv directly to get xi2 events. Same for requests to clip cursor in exclusive mode. The current method of using hooks can stay for backwards compatibility. I'm not at all convinced that this

Re: Need suggestion to choose a GSoC idea

2012-03-27 Thread Qian Hong
Hi Aric, Thanks for reply. On Tue, Mar 27, 2012 at 7:56 PM, Aric Stewart wrote: > Hi, > > Oh, I would love this. However speaking from experience font code is very > hard. You would need to directly specify what you wanted to try to do and > what needs improvement. The code there is very messy a

Re: winex11.drv: Do not trash existing clip rectangle if XInput2 is not available.

2012-03-27 Thread Alexandre Julliard
Vitaliy Margolen writes: > Dinput needs to talk to x11drv directly to get xi2 events. Same for > requests to clip cursor in exclusive mode. The current method of using > hooks can stay for backwards compatibility. I'm not at all convinced that this would be an improvement, particularly since you

Re: winex11.drv: Do not trash existing clip rectangle if XInput2 is not available.

2012-03-27 Thread Vitaliy Margolen
On 03/27/2012 02:29 AM, Alexandre Julliard wrote: Vitaliy Margolen writes: If you have suggestions on how to do this differently please explain them. Dinput needs to talk to x11drv directly to get xi2 events. Same for requests to clip cursor in exclusive mode. The current method of using hoo

Re: Need suggestion to choose a GSoC idea

2012-03-27 Thread Aric Stewart
Hi, On 3/26/12 10:29 PM, Qian Hong wrote: - Improve Wine CJK font support The main idea is fix Bug 16325 [11], Aric and others have done a lot of work on it, and I'm glad to participating too. I think the main blocker for Wine CJK font support is Font Association now, is it suitable for a GSoC

Re: [3/8] scrrun: Add IFileSystem3 support

2012-03-27 Thread Alistair Leslie-Hughes
Hi Jacek, Is there any reason for this to be heap-based object? It looks to me like it would better be a static object (AFAICS you don't even need FileSystem struct since you're not going to store anything in it). No, Just habit to create them like this. Best Regards Alistair Leslie-Hughes

Re: [6/8] scrrun: Implement IFileSystem3 FolderExists

2012-03-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17493 Your paranoid android

Re: [5/8] scrrun: Implement IFileSystem3 FileExists

2012-03-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17492 Your paranoid android

Re: [4/8] scrrun: Add scrrun tests

2012-03-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17491 Your paranoid android

Re: [5/8] scrrun: Implement IFileSystem3 FileExists

2012-03-27 Thread Jacek Caban
Hi Alistair, On 03/27/12 11:42, Alistair Leslie-Hughes wrote: > +static const WCHAR existing_fileW[] = { > +'c', ':', '\\', 'W', 'i', 'n', 'd', 'o', 'w', 's', '\\', 's', 'y', > 's', 't', 'e', 'm', '3', > +'2', '\\', 'n', 't', 'd', 'l', 'l', '.', 'd', 'l', 'l', 0}; Hardcoding

Re: [3/8] scrrun: Add IFileSystem3 support

2012-03-27 Thread Jacek Caban
Hi Alistair, On 03/27/12 11:41, Alistair Leslie-Hughes wrote: > +typedef struct FileSystem > +{ > +IFileSystem3 IFileSystem3_iface; > +LONG ref; > +} FileSystem; > + > +static inline FileSystem *impl_from_IFileSystem3( IFileSystem3 *iface ) > +{ > +return CONTAINING_RECORD(iface, FileS

Re: winex11.drv: Do not trash existing clip rectangle if XInput2 is not available.

2012-03-27 Thread Alexandre Julliard
Vitaliy Margolen writes: > If Dmitry fixes a real bug that means dinput shouldn't depend on > broken behavior. And I'm questioning that exact behavior which > shouldn't have been there in the first place. Dinput's exclusive mode > works regardless of what ClipCursor is set to. Of course the beha

Re: Need suggestion to choose a GSoC idea

2012-03-27 Thread Qian Hong
Hi Holy, On Tue, Mar 27, 2012 at 12:38 PM, HolyCause wrote: > I already asked Austin about that for my GSoC proposal: > >> in short, I think this effort is best spent somewhere else. GUI >> testing is really hard to get right, and very expensive(time, effort, >> disk space, cpu power, etc.). > >

Re: [PATCH] cmd/tests: If we rewind to the beginning of the line, don't increment line number.

2012-03-27 Thread Christian Costa
Le 27/03/2012 08:32, Frédéric Delanoy a écrit : On Mon, Mar 26, 2012 at 10:13, Christian Costa wrote: If some particular cases, a bias is introduced in the line number which make error message mismatch the content of the .exp file. This patch fixes that. --- programs/cmd/tests/batch.c |4