Re: My GSoC proposition: Raw Input

2012-04-04 Thread Vitaliy Margolen
On 04/04/2012 12:34 PM, Henri Verbeet wrote: On 4 April 2012 20:21, Eryk Wieliczko wrote: I've been thinking about joining GSoC as a student this year. As an idea I propose Raw Input, and I seek your advise. Is this topic good, what are possible catches, etc. I think that it might be possible t

About the "Implement Common Windows Scripting Classes"

2012-04-04 Thread Lucas Zawacki
Hello, regarding the "Implement Common Windows Scripting Classes" gsoc idea. How many of these classes would be fine for the length of the program? I'm thinking that maybe 3 classes with thorough would be cool for a proposal. Some of them like "Dictionary" seem to be pretty straight forward and sm

Re: [PATCH 1/2] Revert "gdi32: Load fonts from default Mac external font paths."

2012-04-04 Thread Ken Thomases
Forgot to note that this is a resend. On Apr 4, 2012, at 5:40 PM, Ken Thomases wrote: > > This reverts commit 85a71387dac1ca3ad47970800c8c01743681b528. > --- > dlls/gdi32/freetype.c | 17 + > 1 files changed, 1 insertions(+), 16 deletions(-) > > <0001-Revert-gdi32-Load-fonts-fr

Re: Web based translation tool

2012-04-04 Thread Michal Čihař
Hi Dne Thu, 15 Mar 2012 10:12:14 -0500 Aric Stewart napsal(a): > I do not know if Weblate will work or not. > > Basically we have 3 big requirements that have been sticking points for > various solutions. > > 1) Real Names and e-mails for all contributors > > 2) Individual attribution for al

Re: [PATCH] d3drm: Retreive mesh name at loading time. Implement GetName and SetName.

2012-04-04 Thread Christian Costa
Le 04/04/2012 21:24, Henri Verbeet a écrit : You should use debugstr_a() for printing strings like that. Also, where does the 128 char limit come from? Indeed 128 is inapropriate. A dynamic allocation is much better. I will resubmit a patch. Thanks.

Re: [PATCH 2/4] amstream: Add IAudioMediaStream stub implementation.

2012-04-04 Thread Henri Verbeet
On 4 April 2012 21:57, Christian Costa wrote: > +static HRESULT WINAPI IAudioMediaStreamImpl_QueryInterface(IAudioMediaStream > *iface, > +        REFIID riid, void **ppv) > +{ > +    IAudioMediaStreamImpl *This = impl_from_IAudioMediaStream(iface); > + > +    TRACE("(%p/%p)->(%s,%p)\n", iface, T

Re: [PATCH 4/4] d3drm: Implement IDirect3DRMFrameX_GetChildren method and IDirect3DRMFrameArray interface. (resend)

2012-04-04 Thread Christian Costa
Le 03/04/2012 12:14, Christian Costa a écrit : 2012/4/3 Marvin > Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but cou

Re: amstream: IAMMultiMediaStreamImpl_SetState: correct ifs

2012-04-04 Thread Christian Costa
Le 04/04/2012 21:22, Joris Huizer a écrit : Correcting a mistake in 27c4ad3bec1229020ab38ab5b45f0969204192ef Oupsss.. :(

Re: [PATCH] d3drm: Retreive mesh name at loading time. Implement GetName and SetName.

2012-04-04 Thread Henri Verbeet
You should use debugstr_a() for printing strings like that. Also, where does the 128 char limit come from?

Re: RFC: KUSER_SHARED_DATA update patch to fix bug 29168

2012-04-04 Thread Joey Yandle
> > Writable shared memory is unacceptable, but as long as it's read-only > from the client there's no problem in principle. > Excellent, thanks Alexandre. I'm attaching my current shared memory diff. It uses shm_open + mmap in wineserver to map the shared memory area read/write, and shm_open

Re: My GSoC proposition: Raw Input

2012-04-04 Thread Henri Verbeet
On 4 April 2012 20:21, Eryk Wieliczko wrote: > I've been thinking about joining GSoC as a student this year. As an > idea I propose Raw Input, and I seek your advise. Is this topic good, > what are possible catches, etc. > I think that it might be possible to finally do a decent > implementation,

My GSoC proposition: Raw Input

2012-04-04 Thread Eryk Wieliczko
I've been thinking about joining GSoC as a student this year. As an idea I propose Raw Input, and I seek your advise. Is this topic good, what are possible catches, etc. I think that it might be possible to finally do a decent implementation, that would (besides mouse and keyboard) also support joy

Re: user32/tests: Add DlgDirList tests

2012-04-04 Thread Alexandre Julliard
Bruno Jesus <00cp...@gmail.com> writes: > Based on original patch from Christian Lupien from bug 8226. > > Tests required to later fix http://bugs.winehq.org/show_bug.cgi?id=8226 This should be added to the existing DlgDirList tests, making sure that these things are not already being tested. --

Re: [2/2] advapi32: Do not terminate a regular program if it calls StartServiceCtrlDispatcher.

2012-04-04 Thread Alexandre Julliard
Alexander Morozov writes: > This patch partially fixes #30290. > > Pipe is renamed to spipe (service pipe) to prevent compilation error: > service.c:88:15: error: ‘pipe’ redeclared as different kind of symbol > /usr/include/unistd.h:414:12: note: previous declaration of ‘pipe’ was > here You sho

Re: msi: fixed MsiGetFileHashW for empty files (try 2)

2012-04-04 Thread Alexandre Julliard
Robert van Herk writes: > @@ -493,6 +493,45 @@ static void test_MsiGetFileHash(void) > } > } > > +static void test_MsiGetFileHashForEmptyFile(void) { > +char path[MAX_PATH]; > +MSIFILEHASHINFO hi; > +char file[MAX_PATH]; > +UINT res; > + > +/* Create empty te

Re: [PATCH 2/2] ntdll: Fix section header heap deadlock.

2012-04-04 Thread Alexandre Julliard
"Erich E. Hoover" writes: > Real Name: > Erich Hoover > > Description: > Using the process heap for the section headers can cause a > deadlock (Bug #30356), this patch uses the virtual heap instead. I don't think we want to use the virtual heap for that sort of thing, it should be used o

Re: [PATCH 2/3] wininet: Don't delete locked entry in DeleteUrlCacheEntry

2012-04-04 Thread Alexandre Julliard
Piotr Caban writes: > --- > dlls/wininet/urlcache.c |9 + > 1 files changed, 9 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so urlcache.c && touch urlcache.ok urlcache.c:557: Test succeeded ins

Re: gdi32: Constification.

2012-04-04 Thread Alexandre Julliard
Kusanagi Kouichi writes: > @@ -6407,7 +6409,7 @@ static BOOL get_text_metrics(GdiFont *font, > LPTEXTMETRICW ptm) > return TRUE; > } > > -static BOOL face_has_symbol_charmap(FT_Face ft_face) > +static BOOL face_has_symbol_charmap(const FT_Face ft_face) > { > int i; > > @@ -6729,7