Re: ws2_32/tests: Add hostent struct tests for gethostbyname

2012-04-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17727 Your paranoid android

Re: [2/2] comctl32: Fix message sequence on right mouse click

2012-04-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17723 Your paranoid android

Re: [1/2] comctl32/tests: Added tests for mouse events handling

2012-04-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17721 Your paranoid android

Re: [PATCH 2/3] wininet/tests: Added more tests for urlcache, including a new flag in CacheEntryType.

2012-04-07 Thread Piotr Caban
On 4/7/12 12:48 PM, Morten Rønne wrote: How should I go about moving it? Should the patch (as it has been commited) be removed from wine or should I send a new one, based on the current state? Send a new patch based on current state. You can also change it a little later, e.g. while improving D

Re: [PATCH 2/3] wininet/tests: Added more tests for urlcache, including a new flag in CacheEntryType.

2012-04-07 Thread Morten Rønne
Dear Piotr I have found the flag by testing urlcache functions and look into the cache. After that I added it together with the other definitions of that flag field. As this is sort of internal to urlcache, I wouldn't be surprised if this is not defined in any official header. How should I go

Re: winealsa: Fix an uninitialized variable compiler warning.

2012-04-07 Thread Józef Kucia
On Fri, Apr 6, 2012 at 4:31 PM, Andrew Eikum wrote: > Thanks. GCC 4.7 must be smart enough to detect the same if-conditions, > and doesn't issue a warning for me. Kind of impressive, actually. > > Andrew > GCC 4.5 wasn't that smart yet. -- Józef Kucia