Re: wininet/tests: fix a compiler warning on LLVM/Clang

2012-05-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18347 Your paranoid

Re: wininet/tests: fix a compiler warning on LLVM/Clang

2012-05-14 Thread Jacek Caban
Hi Austin, On 05/14/12 08:19, Austin English wrote: clang -c -I. -I. -I../../../include -I../../../include -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers

Re: wininet: Fixed typo in tests and accompanying implementation

2012-05-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18349 Your paranoid

Re: msxml3: avoid a dangling else (LLVM/Clang)

2012-05-14 Thread Michael Stefaniuc
Hello Austin, On 05/14/2012 08:01 AM, Austin English wrote: diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c index 6805c75..14fd01b 100644 --- a/dlls/msxml3/domdoc.c +++ b/dlls/msxml3/domdoc.c @@ -2277,8 +2277,10 @@ static HRESULT WINAPI domdoc_loadXML( /* skip

Re: msxml3: avoid a dangling else (LLVM/Clang)

2012-05-14 Thread Eric Pouech
while (*ptr) if (isspaceW(*ptr)) ptr++; else break; I do not mind terse code but that kinda overdoes it. I would put the else on a separate line. trafic on wine-devel is rather low those days what about opening a code-style flame-war ? A+ -- Eric

Re: msxml3: avoid a dangling else (LLVM/Clang)

2012-05-14 Thread Michael Stefaniuc
On 05/14/2012 11:47 AM, Eric Pouech wrote: while (*ptr) if (isspaceW(*ptr)) ptr++; else break; I do not mind terse code but that kinda overdoes it. I would put the else on a separate line. trafic on wine-devel is rather low those days what about

Re: [1/3] user32/tests: Add GetUserObjectInformation tests

2012-05-14 Thread Alexandre Julliard
Owen Rudge oru...@codeweavers.com writes: There appears to be a bug in the GetUserObjectInformationA function on Windows that results in an incorrect buffer length being returned when the buffer size provided by the caller is insufficient. The 'A' function returns the Unicode length instead

Re: [1/3] user32/tests: Add GetUserObjectInformation tests

2012-05-14 Thread Owen Rudge
On 14/05/2012 11:43, Alexandre Julliard wrote: Using the number of Unicode chars multiplied by 2 is a reasonable upper bound on the A string size, and it's used in a number of places. This can't really be considered a Windows bug. OK; it's perhaps not a bug in that case. I believe my patch is

Re: [1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset.

2012-05-14 Thread Vincent Povirk
-            GdipMeasureString(graphics, string, length, font, rect, format, bounds, 0, 0); +            GdipMeasureString(graphics, string, length, font, bounds, format, bounds, 0, 0); You probably shouldn't use the same GpRect* for both parameters there.

Re: [1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset.

2012-05-14 Thread Dmitry Timoshkov
Vincent Povirk madewokh...@gmail.com wrote: -            GdipMeasureString(graphics, string, length, font, rect, format, bounds, 0, 0); +            GdipMeasureString(graphics, string, length, font, bounds, format, bounds, 0, 0); You probably shouldn't use the same GpRect* for both

Re: [1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset.

2012-05-14 Thread Vincent Povirk
+            GdipMeasureString(graphics, string, length, font, bounds, format, bounds, 0, 0); You probably shouldn't use the same GpRect* for both parameters there. I don't see any problem with that. GdipMeasureString modifies the out parameter and reads the in parameter as it goes, and

Re: [1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset.

2012-05-14 Thread Dmitry Timoshkov
Vincent Povirk madewokh...@gmail.com wrote: +            GdipMeasureString(graphics, string, length, font, bounds, format, bounds, 0, 0); You probably shouldn't use the same GpRect* for both parameters there. I don't see any problem with that. GdipMeasureString modifies the out

Re: [1/3] user32/tests: Add GetUserObjectInformation tests

2012-05-14 Thread Alexandre Julliard
Owen Rudge o...@owenrudge.net writes: On 14/05/2012 11:43, Alexandre Julliard wrote: Using the number of Unicode chars multiplied by 2 is a reasonable upper bound on the A string size, and it's used in a number of places. This can't really be considered a Windows bug. OK; it's perhaps not a

Re: [1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset. Take 2.

2012-05-14 Thread Vincent Povirk
If the string wraps, and you don't give the width to GdipMeasureString, won't it return a too small height? On Mon, May 14, 2012 at 9:11 AM, Dmitry Timoshkov dmi...@baikal.ru wrote: GdipMeasureString() clips the string extents to passed rectangle width and height, but that leads to wrong

Re: [1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset. Take 2.

2012-05-14 Thread Dmitry Timoshkov
Vincent Povirk madewokh...@gmail.com wrote: If the string wraps, and you don't give the width to GdipMeasureString, won't it return a too small height? GdipMeasureString considers an empty rect as a rect without clipping. -- Dmitry.

Re: [1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset. Take 2.

2012-05-14 Thread Vincent Povirk
OK, but if the rect passed to GdipDrawString has a non-zero width, and depending on the string formatting options, GdipDrawString may wrap the text. GdipMeasureString will not wrap the text if you call it with a width of 0. On Mon, May 14, 2012 at 9:37 AM, Dmitry Timoshkov dmi...@baikal.ru wrote:

Re: ddraw: Forward AddAttachedSurface to the correct equivalent

2012-05-14 Thread Stefan Dösinger
Am Sonntag, 13. Mai 2012, 20:39:27 schrieb David Adam: +hr = ddraw_surface3_AddAttachedSurface(This- IDirectDrawSurface3_iface, +attachment_impl ? attachment_impl-IDirectDrawSurface3_iface : NULL); It isn't immediately clear to me why Surface3 is correct instead of Surface7. Do

Re: [1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset. Take 2.

2012-05-14 Thread Dmitry Timoshkov
Vincent Povirk madewokh...@gmail.com wrote: OK, but if the rect passed to GdipDrawString has a non-zero width, and depending on the string formatting options, GdipDrawString may wrap the text. GdipMeasureString will not wrap the text if you call it with a width of 0. That's a good point,

Re: Using an IDE on Wine?

2012-05-14 Thread Michael Ost
On 5/13/12 10:00 AM, wine-devel-requ...@winehq.org wrote: How many of you use an Integrated Development Environment (IDE) when working on Wine? If you do, which one do you use and how, how useful is it and how hard was it to set up? I use Qt Creator for Linux for our winelib application. Our

Re: wmvcore: Add stub for WMCreateSyncReader

2012-05-14 Thread Nikolay Sivov
On 5/14/2012 19:34, André Hentschel wrote: Otherwise GTA San Andreas runs into it and crashes. This stub let's it work again. a workaround is to disable wmvcore in winecfg... --- dlls/wmvcore/wmvcore.spec |2 +- dlls/wmvcore/wmvcore_main.c |8 2 files changed, 9

XINPUT JOYSTICK PATCH

2012-05-14 Thread Giovanni Ongaro
I have written a modification of the xinput1_3 dll that simulates xbox joystick with a logitech rumblepad 2 joystick,also provided is a way to disable dinput joysticks through an environment variable, it seems to work well,may it be of interest to the wine project?

Re: [1/2] gdiplus: Measure the passed in string without height clipping in order to compute correct Y offset. Take 3.

2012-05-14 Thread Vincent Povirk
Looks good to me.

Re: XINPUT JOYSTICK PATCH

2012-05-14 Thread Jaime Rave
2012/5/14 Giovanni Ongaro giovanni.nic...@ticino.com: I have written a modification of the xinput1_3 dll that simulates xbox joystick with a logitech rumblepad 2 joystick,also provided is a way to disable dinput joysticks through an environment variable, it seems to work well,may it be of

Re: ddraw: Forward AddAttachedSurface to the correct equivalent

2012-05-14 Thread Matteo Bruni
2012/5/14 Stefan Dösinger stefandoesin...@gmx.at: Am Sonntag, 13. Mai 2012, 20:39:27 schrieb David Adam: +    hr = ddraw_surface3_AddAttachedSurface(This- IDirectDrawSurface3_iface, +            attachment_impl ? attachment_impl-IDirectDrawSurface3_iface : NULL); It isn't immediately clear to

Wine Mono 0.0.4 Release - I'm serious now!

2012-05-14 Thread Vincent Povirk
I have published version 0.0.4 of Wine Mono on Sourceforge. I fully intend to make this release a part of Wine. The source tarball is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.4/wine-mono-0.0.4.tar.gz/download The binary is at