Re: iphlpapi: Don't rely on the HAVE_XXX macros having a numeric values.

2012-06-08 Thread Dan Kegel
Alexandre wrote: > It's common practice to avoid it, to make things like -Wundef more useful. Good point. Reading http://ozlabs.org/~rusty/index.cgi/tech/2008-01-04.html makes me sad. -Wundef would be a lot more useful if autoconf defined symbols to zero instead of undefining them; then we could

Re: iphlpapi: Don't rely on the HAVE_XXX macros having a numeric values.

2012-06-08 Thread Alexandre Julliard
Dan Kegel writes: > On Fri, Jun 8, 2012 at 11:51 AM, Francois Gouget wrote: >> On Fri, 8 Jun 2012, Dan Kegel wrote: >>> Isn't this a no-op?  I thought that an undefined symbol was >>> treated as false by the preprocessor. >> >> Actually you may be right. But then this is the only place in Wine w

Re: iphlpapi: Don't rely on the HAVE_XXX macros having a numeric values.

2012-06-08 Thread Dan Kegel
On Fri, Jun 8, 2012 at 11:51 AM, Francois Gouget wrote: > On Fri, 8 Jun 2012, Dan Kegel wrote: >> Isn't this a no-op?  I thought that an undefined symbol was >> treated as false by the preprocessor. > > Actually you may be right. But then this is the only place in Wine where > we rely on this and

re: iphlpapi: Don't rely on the HAVE_XXX macros having a numeric values.

2012-06-08 Thread Francois Gouget
On Fri, 8 Jun 2012, Dan Kegel wrote: > -#elif defined(HAVE_SYS_SYSCTL_H) && defined(IPCTL_STATS) && > (HAVE_STRUCT_IPSTAT_IPS_TOTAL || HAVE_STRUCT_IP_STATS_IPS_TOTAL) > +#elif defined(HAVE_SYS_SYSCTL_H) && defined(IPCTL_STATS) && > (defined(HAVE_STRUCT_IPSTAT_IPS_TOTAL) || > defined(HAVE_STRUCT_IP

Re: [PATCH 3/3] wininet: Added InternetGetSecurityInfoByURL tests

2012-06-08 Thread Alexandre Julliard
Jacek Caban writes: > --- > dlls/wininet/tests/Makefile.in |2 +- > dlls/wininet/tests/http.c | 38 > ++ > 2 files changed, 39 insertions(+), 1 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p win

Re: Patch 1/2 - [scrrun] - Add initial support for Dictionary - try 2

2012-06-08 Thread Vijay Kiran Kamuju
On Fri, Jun 8, 2012 at 11:00 AM, Jacek Caban wrote: > Hi Vijay, > > On 06/08/12 03:15, Vijay Kiran Kamuju wrote: >> +    *ppvObject = NULL; >> +    if ( IsEqualGUID( riid, &IID_IDictionary ) || >> +         IsEqualGUID( riid, &IID_IPersist ) || >> +         IsEqualGUID( riid, &IID_IDispatch ) || >

re: iphlpapi: Don't rely on the HAVE_XXX macros having a numeric values.

2012-06-08 Thread Dan Kegel
-#elif defined(HAVE_SYS_SYSCTL_H) && defined(IPCTL_STATS) && (HAVE_STRUCT_IPSTAT_IPS_TOTAL || HAVE_STRUCT_IP_STATS_IPS_TOTAL) +#elif defined(HAVE_SYS_SYSCTL_H) && defined(IPCTL_STATS) && (defined(HAVE_STRUCT_IPSTAT_IPS_TOTAL) || defined(HAVE_STRUCT_IP_STATS_IPS_TOTAL)) Isn't this a no-op? I thoug

Re: [PATCH 1/5] hhctrl.ocx: Add HTML to Unicode parsing capability.

2012-06-08 Thread Jacek Caban
On 06/08/12 16:10, Erich E. Hoover wrote: > On Fri, Jun 8, 2012 at 2:58 AM, Jacek Caban wrote: >> ... >> Did you test indexes like 'alert("really!?")' ? :) >> Seriously, HTMLDocument is not the right tool for the job. > I can. Do you have a suggestion for an alternative? I don't know any helper

Re: [PATCH 3/3] wininet: Added InternetGetSecurityInfoByURL tests

2012-06-08 Thread Jacek Caban
On 06/08/12 15:13, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/

Re: [PATCH 3/3] wininet: Added InternetGetSecurityInfoByURL tests

2012-06-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18903 Your paranoid android

Re: msxml3: Implement IXMLParser Get/Set Flags

2012-06-08 Thread Alistair Leslie-Hughes
On 8/06/2012 7:15 PM, Marvin wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetai

Re: msxml3: Implement IXMLParser Get/Set Flags

2012-06-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18891 Your paranoid android

Re: Patch 1/2 - [scrrun] - Add initial support for Dictionary - try 2

2012-06-08 Thread Jacek Caban
Hi Vijay, On 06/08/12 03:15, Vijay Kiran Kamuju wrote: > +*ppvObject = NULL; > +if ( IsEqualGUID( riid, &IID_IDictionary ) || > + IsEqualGUID( riid, &IID_IPersist ) || > + IsEqualGUID( riid, &IID_IDispatch ) || > + IsEqualGUID( riid, &IID_IUnknown ) ) > +{ > +

Re: [PATCH 1/5] hhctrl.ocx: Add HTML to Unicode parsing capability.

2012-06-08 Thread Jacek Caban
Hi Erich, On 06/07/12 23:09, Erich E. Hoover wrote: > +/* Post the HTML text to the document */ > +array = SafeArrayCreateVector(VT_VARIANT, 0, 1); > +if(!array) > +goto cleanup; > +hr = SafeArrayAccessData(array, (LPVOID*)&array_param); > +if (FAILED(hr)) > +go

Re: [PATCH 4/4] mshtml: Added IWindowForBindingUI tests

2012-06-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18890 Your paranoid android