Re: [PATCH 1/3] gdi32/tests: Make GetStockObject tests pass on East-Asian machines. (try 2)

2012-06-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19269 Your paranoid android

Re: [PATCH 2/3] gdi32: Fix East-Asian font parameters. (resend)

2012-06-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19270 Your paranoid android

msi:RECORD_StreamFromFile bug, help needed

2012-06-18 Thread robert.van.h...@serioustoys.com
Hi all, I think I found a msi.dll, record.c, RECORD_StreamFromFile. This function calls GlobalAlloc, with a file size as an argument. However, I believe that this can easily fail (which it does in my case) when the file size is too large. In my case, my msi builder (WiX) calls MsiRecordSetStrea

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-18 Thread Darryl Slack
Well after fighting with pulseaudio after all this time I have tried this patch with wine 1.5.6 with a Presonus StudioLive 24.4.2 Fire-wire controller within wine, to control software known as Virtual DJ with timecoded vinyl records. With Andrew's patch, there are stalled buffer errors, and I was

Re: windowscodecs: Create a IWICMetadataReader for a TIFF frame. Take 3.

2012-06-18 Thread Dmitry Timoshkov
Vincent Povirk wrote: > I'm still a little worried about seeking the stream behind libtiff's > back, but otherwise it looks good. I think we can always change that if it breaks things, but I didn't see any side effects so far. -- Dmitry.

Re: windowscodecs: Create a IWICMetadataReader for a TIFF frame. Take 3.

2012-06-18 Thread Vincent Povirk
I'm still a little worried about seeking the stream behind libtiff's back, but otherwise it looks good.

Re: Disabling joysticks with registry keys and joy.cpl

2012-06-18 Thread Lucas Zawacki
On Mon, Jun 18, 2012 at 11:04 PM, Vitaliy Margolen wrote: > If you worry about devices moving around and getting different IDs - then > use part of GUID to identify driver and add device name to identify the > joystick. Yes, that seems like the way to go. I'll use the GUIDs to show the device nam

Re: Disabling joysticks with registry keys and joy.cpl

2012-06-18 Thread Vitaliy Margolen
On 06/18/2012 12:07 PM, Lucas Zawacki wrote: The bottom line is: can I add platform dependent code in joy.cpl for this purpose? If that's not an option, do you have some other way to do through joy.cpl or should it be registry only? If you use generated device GUIDs that won't be as "platform dep

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability.

2012-06-18 Thread Erich E. Hoover
On Mon, Jun 18, 2012 at 3:26 PM, André Hentschel wrote: > Am 18.06.2012 15:52, schrieb Erich E. Hoover: > ... > > Changelog: > >     hhctrl.ocx: Add HTML to Unicode decoding capability. > > You're adding dead code here, you should maybe merge Patch 1 & 2 Since part 2 and 3 are both dependent upon

Re: d3dx9_36: Reckonize A8B8G8R8 format

2012-06-18 Thread Stefan Dösinger
Am Montag, 18. Juni 2012, 23:59:52 schrieb Stefan Dösinger: > Hi, > > Please add the format to the dds tests in dlls/d3dx9_36/tests/surface.c > > > { 32, 0x, 0x, 0x, 0x, > > D3DFMT_G16R16 > > }, > > > +{ 32, 0xff, 0xff00, 0xff, 0xff0

Re: d3dx9_36: Reckonize A8B8G8R8 format

2012-06-18 Thread Stefan Dösinger
Hi, Please add the format to the dds tests in dlls/d3dx9_36/tests/surface.c > { 32, 0x, 0x, 0x, 0x, D3DFMT_G16R16 }, > +{ 32, 0xff, 0xff00, 0xff, 0xff00, D3DFMT_A8B8G8R8 }, The other 32 bit formats in this table have their bitmasks padded

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability.

2012-06-18 Thread André Hentschel
Am 18.06.2012 15:52, schrieb Erich E. Hoover: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for >

Re: comctl32: hotkey control needs to invalidate itself when painting for some apps

2012-06-18 Thread Dan Kegel
On Mon, Jun 18, 2012 at 11:41 AM, Dmitry Timoshkov wrote: >> +     /* In some apps, the hotkey doesn't draw unless we invalidate it here >> */ >> +     InvalidateRect(infoPtr->hwndSelf, NULL, FALSE); > > It doesn't make sense to invalidate before painting in the paint > handler. Looking at the +

Re: comctl32: hotkey control needs to invalidate itself when painting for some apps

2012-06-18 Thread Dmitry Timoshkov
Dan Kegel wrote: > @@ -190,6 +190,8 @@ HOTKEY_Paint(HOTKEY_INFO *infoPtr, HDC hdc) > HOTKEY_Refresh(infoPtr, hdc); > else { > PAINTSTRUCT ps; > + /* In some apps, the hotkey doesn't draw unless we invalidate it here */ > + InvalidateRect(infoPtr->hwndSelf, NULL, FALSE);

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-18 Thread Chris Robinson
On Monday, June 18, 2012 11:18:45 AM Andrew Eikum wrote: > Is there any guarantee that Pulse /will/ give us a sufficient buffer? > From the API docs[1], it just "tries to assure" that we have the > requested buffer size, which actually means nothing. It "tries to assure that at least tlength bytes

Re: comctl32: hotkey control needs to invalidate itself when painting for some apps

2012-06-18 Thread Austin English
On Mon, Jun 18, 2012 at 11:14 AM, Dan Kegel wrote: > In at least one app, the hotkey control doesn't draw itself. > Invalidating its own window during HOTKEY_Paint gets the > control to draw properly, and makes the app happy. > > Fixes http://bugs.winehq.org/show_bug.cgi?id=30486 > (Unlike the pat

comctl32: hotkey control needs to invalidate itself when painting for some apps

2012-06-18 Thread Dan Kegel
In at least one app, the hotkey control doesn't draw itself. Invalidating its own window during HOTKEY_Paint gets the control to draw properly, and makes the app happy. Fixes http://bugs.winehq.org/show_bug.cgi?id=30486 (Unlike the patch attached to that bug, this one doesn't also ask the backgrou

Disabling joysticks with registry keys and joy.cpl

2012-06-18 Thread Lucas Zawacki
Hello all, disabling an specific joystick device is an issue that is raised from time to time in this list. I'm planning on implementing it as a registry key like 'DirectInput/Disable controllername'. However I'd like the ability to disable specific joysticks on Linux, like the /dev/input/js* ver

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-18 Thread Andrew Eikum
On Mon, Jun 18, 2012 at 08:49:55AM -0700, Chris Robinson wrote: > On Monday, June 18, 2012 9:31:04 AM Andrew Eikum wrote: > > Yeah, I experimented with ADJUST_LATENCY, as it seems to be the trick > > to getting lower latencies. Then we have to maintain our own buffer, > > which is why I switched to

Re: windowscodecs: Create a IWICMetadataReader for a TIFF frame. Take 2.

2012-06-18 Thread Dmitry Timoshkov
Vincent Povirk wrote: > This looks better, but I still think you should use > WICPersistOptionNoCacheStream. > > Some of your failure cases in create_metadata_reader will return a > reference to an IWICMetadataReader, which seems wrong. Apparently that was a hasty attempt to make the patch appe

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-18 Thread Chris Robinson
On Monday, June 18, 2012 9:31:04 AM Andrew Eikum wrote: > We chatted a little on IRC this weekend, but thanks again for the > advice. No problem. :) > Mmdevapi sends it data to the lower systems in period-sized chunks, > and the reported buffer fill level decreases in period-sized chunks. > But t

Re: windowscodecs: Create a IWICMetadataReader for a TIFF frame. Take 2.

2012-06-18 Thread Vincent Povirk
This looks better, but I still think you should use WICPersistOptionNoCacheStream. Some of your failure cases in create_metadata_reader will return a reference to an IWICMetadataReader, which seems wrong.

Re: windowscodecs: Create a IWICMetadataReader when loading a TIFF frame.

2012-06-18 Thread Dmitry Timoshkov
Dmitry Timoshkov wrote: > > Also, I just noticed that you're calling create_metadata_reader > > unconditionally from QueryInterface, and not checking in the process > > whether the reader has already been created. That will leak if QI is > > called multiple times. > > > > I'm not sure doing real

Re: windowscodecs: Create a IWICMetadataReader when loading a TIFF frame.

2012-06-18 Thread Dmitry Timoshkov
Vincent Povirk wrote: > >> We can't use that stream because we provide separate seek and > >> read/write methods to libtiff, and libtiff may rely on the stream's > >> position to not change between operations. > > > > libtiff doesn't rely on stream positions, and my use of stream matches > > MSDN

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-18 Thread Andrew Eikum
On Fri, Jun 15, 2012 at 06:23:57PM -0700, Chris Robinson wrote: > The update_size is only relevant if mmdevapi updates in period-sized chunks. > If it doesn't, you can just remove it and the rounding. The tlength should be > kept updated using pa_stream_set_buffer_attr_callback, in case the serve

Re: atl80: prefer native, if present

2012-06-18 Thread Alexandre Julliard
Daniel Jelinski writes: > 2012/6/18, Alexandre Julliard : >> There's no reason to do that, most of the dll is already implemented. > > It hides at least bug [1] from the end user, since the application > comes with a bundled atl80 and works fine with it. It would probably > also hide [2], since t

Re: windowscodecs: Create a IWICMetadataReader when loading a TIFF frame.

2012-06-18 Thread Vincent Povirk
>> > +        hr = IWICPersistStream_LoadEx(persist, This->parent->stream, >> > NULL, persist_options); >> > +        if (FAILED(hr)) >> > +            ERR("IWICPersistStream_LoadEx error %#x\n", hr); >> >> We can't use that stream because we provide separate seek and >> read/write methods to libt

Re: windowscodecs: Create a IWICMetadataReader when loading a TIFF frame.

2012-06-18 Thread Dmitry Timoshkov
Vincent Povirk wrote: > > +        hr = IWICPersistStream_LoadEx(persist, This->parent->stream, NULL, > > persist_options); > > +        if (FAILED(hr)) > > +            ERR("IWICPersistStream_LoadEx error %#x\n", hr); > > We can't use that stream because we provide separate seek and > read/wri

Re: windowscodecs: Create a IWICMetadataReader when loading a TIFF frame.

2012-06-18 Thread Vincent Povirk
> +        hr = IWICPersistStream_LoadEx(persist, This->parent->stream, NULL, > persist_options); > +        if (FAILED(hr)) > +            ERR("IWICPersistStream_LoadEx error %#x\n", hr); We can't use that stream because we provide separate seek and read/write methods to libtiff, and libtiff may

Re: atl80: prefer native, if present

2012-06-18 Thread Daniel Jelinski
2012/6/18, Alexandre Julliard : > Daniel Jelinski writes: > >> From 7243b3594c9c0b13770ede1ab32d4dd1329b1dd4 Mon Sep 17 00:00:00 2001 >> From: Daniel Jelinski >> Date: Sun, 17 Jun 2012 17:37:15 +0200 >> Subject: atl80: prefer native, if present >> >> --- >> dlls/atl80/atl80.c | 11 +++

Re: mshtml: Implement IHTMLScriptElement_put_src

2012-06-18 Thread Jacek Caban
André, On 06/15/12 23:45, André Hentschel wrote: > --- > dlls/mshtml/htmlscript.c | 14 -- > dlls/mshtml/tests/dom.c |6 ++ > 2 files changed, 18 insertions(+), 2 deletions(-) > > diff --git a/dlls/mshtml/htmlscript.c b/dlls/mshtml/htmlscript.c > index 376db7b..1714cfe 1006

Re: atl80: prefer native, if present

2012-06-18 Thread Alexandre Julliard
Daniel Jelinski writes: > From 7243b3594c9c0b13770ede1ab32d4dd1329b1dd4 Mon Sep 17 00:00:00 2001 > From: Daniel Jelinski > Date: Sun, 17 Jun 2012 17:37:15 +0200 > Subject: atl80: prefer native, if present > > --- > dlls/atl80/atl80.c | 11 +++ > 1 files changed, 11 insertions(+), 0 de

Re: [PATCH 2/5] include/ddk: Add DVD_DESCRIPTOR_HEADER descriptor structure (try 2)

2012-06-18 Thread Alexandre Julliard
Alexandre Goujon writes: > @@ -113,7 +113,16 @@ typedef struct DVD_READ_STRUCTURE { > > /* From 0 to 4 */ > UCHAR LayerNumber; > -}DVD_READ_STRUCTURE, * PDVD_READ_STRUCTURE; > +} DVD_READ_STRUCTURE, *PDVD_READ_STRUCTURE; > + > +typedef struct _DVD_DESCRIPTOR_HEADER { > +US

Re: [6/6] wbemprox: Add tests for IWbemServices.

2012-06-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19208 Your paranoid android