Wine, fullscreen applications, and RandR 1.2

2012-09-04 Thread Andy Ritger
Hello wine developers, I work on NVIDIA's Linux graphics driver team, and have a few questions about how Wine should interact with X driver mode lists. Sorry if this isn't the correct forum for these questions. Starting in release 302.xx, we finally added RandR 1.2 support to NVIDIA's X driver.

Re: [PATCH 1/3] [cmd] "PATH=value" fails whereas "PATH value" works

2012-09-04 Thread Ann and Jason Edmeades
> > > === WVISTAADM (32 bit) === > Failure running script in VM: The specified guest user must be logged in > interactively to perform this operation > I dont think this is related to my patch, especially when the tests run and pass on patch 2

Re: [PATCH 1/3] [cmd] "PATH=value" fails whereas "PATH value" works

2012-09-04 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21386 Your paranoid android

Re: Building winetest-latest.exe?

2012-09-04 Thread Dan Kegel
On Tue, Sep 4, 2012 at 3:18 PM, Francois Gouget wrote: >> (But as it turns out, the code I needed to fix was in buildbot, >> not winetest.) > > Maybe the WineTestBot code needs a similar fix? > In testbot/src/TestLauncher/TestLauncher.c? Yeah, um, ^buildbot^testbot I have a patch at http://bugs.w

Re: Building winetest-latest.exe?

2012-09-04 Thread Francois Gouget
On Mon, 3 Sep 2012, Dan Kegel wrote: [...] > > Sort of. You don't need a separate build tree for building the tests. > > Just have mingw32 installed, run ./configure, then 'make crosstest'. > > I've done 'make crosstest' many times, but building winetest.exe itself > does seem to require the two t

Re: Building winetest-latest.exe?

2012-09-04 Thread Francois Gouget
On Sun, 2 Sep 2012, Vincent Povirk wrote: > As I understand it, you need to set up a mingw build as in > http://wiki.winehq.org/CompilingDLLsUsingMingw The above page says to use mingw32 but this version of MinGW is pretty old (4.2) and, as far as I can tell, can only build 32bit Windows binari

Re: [1/2] gdiplus: Add some tests for scaling an image with various pixel offset modes.

2012-09-04 Thread Vincent Povirk
> match = memcmp(dst_8x1, td[i].image, sizeof(dst_8x1)) == 0; > +if (!match) > +todo_wine ok(match, "%d: data should match\n", i); > +else > ok(match, "%d: data should match\n", i); This sort of thing makes me nervous. Couldn't you do this in such a way th

Re: d3dx9_36 [try 3]: Implement D3DXSHRotate

2012-09-04 Thread Rico Schüller
On 04.09.2012 19:31, Nozomi Kodama wrote: Your mail makes me thing two or three remarks. I agree that in the plain wine, code must be optimized to use less memory as possible and to be the fastest as possible. But, the tests are here to check that the implemented function behaves like the window

Re: wininet: Set last error for invalid URL argument

2012-09-04 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21380 Your paranoid android

Re: d3dx9_36 [try 3]: Implement D3DXSHRotate

2012-09-04 Thread Matteo Bruni
2012/9/4 Rico Schüller : > On 04.09.2012 13:19, Nozomi Kodama wrote: > +FLOAT expected, in[100], out[100], > ... > +for (i = 0; i < 49; i++) > +in[i] = i + 1.01f; > > I guess this belongs together. > > I'd like to make some suggestions, please don't take it personally. > > When you

Re: [2/2] gdiplus: Add preliminary support for pixel offset modes.

2012-09-04 Thread Vincent Povirk
> return sample_bitmap_pixel(src_rect, bits, width, height, > -gdip_round(point->X), gdip_round(point->Y), attributes); > +point->X + pixel_offset, point->Y + pixel_offset, attributes); > +} This is going to break tiling. By removing gdip_round you're implicitl

Re: jscript: Fixed empty cases in the end of switch statement

2012-09-04 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21379 Your paranoid android

Re: [PATCH 1/4] mshtml: Properly expose frame and iframe element's windows to scripts

2012-09-04 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21376 Your paranoid android

Re: d3dx9_36 [try 3]: Implement D3DXSHRotate

2012-09-04 Thread Rico Schüller
On 04.09.2012 13:19, Nozomi Kodama wrote: +FLOAT expected, in[100], out[100], ... +for (i = 0; i < 49; i++) +in[i] = i + 1.01f; I guess this belongs together. I'd like to make some suggestions, please don't take it personally. When you got a comment on a patch, read it carefully

Re: Wine Gecko 1.8-beta1

2012-09-04 Thread Dmitry Timoshkov
Vincent Povirk wrote: > > On related note, I seriously consider dropping debug builds and replace > > them by unstripped release build or even just a separated package > > containing only debug symbols for the release build. > > No one has complained about the debugging symbols in Wine Mono yet.

Re: d3dx9_36 [try 2]: Implement D3DXSHRotate

2012-09-04 Thread Rico Schüller
On 03.09.2012 20:59, Nozomi Kodama wrote: Thanks Rico and Henri for your help. Nozomi The patch looks much better now. But I have some minor things which I didn't mention last time... +ok(received_ptr == out, "order %u, Expected %p, received %p\n", order, out, received_ptr);