Re: [PATCH 1/2] gdi32/tests: Added tests for symbol fonts.

2012-09-07 Thread Qian Hong
Hello, Please ignore this series of patch, I'll provide a fix for the failure test.

Re: [PATCH 2/2] gdi32: Fixed get_name_table_entry for symbol fonts.

2012-09-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21462 Your paranoid android

Re: [PATCH 1/2] gdi32/tests: Added tests for symbol fonts.

2012-09-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21461 Your paranoid android

Re: Wine, fullscreen applications, and RandR 1.2

2012-09-07 Thread Andy Ritger
On Thu, Sep 06, 2012 at 01:05:42AM -0700, Henri Verbeet wrote: > On 5 September 2012 22:45, Andy Ritger wrote: > > On Wed, Sep 05, 2012 at 11:26:23AM -0700, Henri Verbeet wrote: > >> From Wine's point of view, we'd just get a bunch of extra code to maintain > >> because nvidia does things differen

Re: [PATCH 6/9] mshtml: Use first script host's GUID as default script guid

2012-09-07 Thread Alexandre Julliard
Jacek Caban writes: > dlls/mshtml/htmlwindow.c |1 - > dlls/mshtml/mshtml_private.h |1 - > dlls/mshtml/script.c | 18 ++ > dlls/mshtml/tests/vbtest.html | 15 +-- > 4 files changed, 23 insertions(+), 12 deletions(-) It doesn't work here on

Re: [2/5] vcomp: add better stub for _vcomp_fork (resend)

2012-09-07 Thread Dan Kegel
On Fri, Sep 7, 2012 at 7:21 AM, Dan Kegel wrote: > As I mentioned earlier, the testbot can't handle vcomp.dll tests > until a fix for http://bugs.winehq.org/show_bug.cgi?id=31609 > is deployed. > > It can handle vcomp100.dll tests, though (no manifest). I guess I can submit > the series again wit

Re: [PATCH 9/9] vbscript: Added support for VT_NULL in stack_pop_bool

2012-09-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21447 Your paranoid android

Re: [PATCH 8/9] vbscript: Added support for comparing to null

2012-09-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21446 Your paranoid android

Re: [PATCH 7/9] mshtml: Check if value is function only when it needs to be in invoke_builtin_prop

2012-09-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21445 Your paranoid android

Re: [PATCH 6/9] mshtml: Use first script host's GUID as default script guid

2012-09-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21444 Your paranoid android

Re: [2/5] vcomp: add better stub for _vcomp_fork (resend)

2012-09-07 Thread Dan Kegel
As I mentioned earlier, the testbot can't handle vcomp.dll tests until a fix for http://bugs.winehq.org/show_bug.cgi?id=31609 is deployed. It can handle vcomp100.dll tests, though (no manifest). I guess I can submit the series again with the vcomp100 forwarding and tests in a sixth patch, that wo

Re: [PATCH 2/2] user32: Correct class small icons behavior (try 2).

2012-09-07 Thread Sergey Guralnik
On 2012-09-07 15:24, Sergey Guralnik wrote: This patch based on MSDN's description of WNDCLASSEX structure: ... hIconSm: Handle to a small icon that is associated with the window class. If this member is NULL, the system searches the icon resource specified by the hIcon memb

Re: [PATCH 1/2] user32/tests: Added test for class icons handling.

2012-09-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21432 Your paranoid android

Re: [PATCH 2/2] user32: Correct class small icons behavior.

2012-09-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21433 Your paranoid android

Re: [PATCH 4/5] gdi32: Added font name tests on non English locale.

2012-09-07 Thread Qian Hong
Hello, On Fri, Sep 7, 2012 at 2:28 AM, Alexandre Julliard wrote: > You should avoid that sort of thing, it will be hard to debug, > particularly since get_ttf_nametable_entry itself has ok() calls. Store > the result in a variable instead. Thanks for review! I've sent a improved version. -- Re

Re: [PATCH 1/3] user32: Implement RegisterRawInputDevices().

2012-09-07 Thread Alexandre Julliard
Henri Verbeet writes: > @@ -2931,3 +2965,14 @@ DECL_HANDLER(set_cursor) > reply->new_clip= input->desktop->cursor.clip; > reply->last_change = input->desktop->cursor.last_change; > } > + > +DECL_HANDLER(update_rawinput_devices) > +{ > +const struct rawinput_device *devices = ge