Re: [1/3] scrrun: Implement IDictionary_Add and Count (try 2)

2012-10-11 Thread Alistair Leslie-Hughes
On 9/10/2012 8:54 PM, Henri Verbeet wrote: On 9 October 2012 11:26, Alistair Leslie-Hughes wrote: Changelog: scrrun: Implement IDictionary_Add and Count Actually, does it ever make sense to use a linked list at all to implement a dictionary? It seems to me that if you only ever have a h

Re: [PATCH] amstream: Display new ref in AddRef and Release.

2012-10-11 Thread Christian Costa
Le 12/10/2012 06:32, Nikolay Sivov a écrit : On 10/12/2012 00:46, Christian Costa wrote: --- dlls/amstream/mediastreamfilter.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/dlls/amstream/mediastreamfilter.c b/dlls/amstream/mediastreamfilter.c index ee9

Re: [PATCH] amstream: Check params in IAMMultiMediaStreamImpl_OpenFile.

2012-10-11 Thread Nikolay Sivov
On 10/12/2012 00:59, Christian Costa wrote: --- dlls/amstream/amstream.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) -TRACE("(%p/%p)->(%s,%x)\n", This, iface, debugstr_w(pszFileName), dwFlags); +TRACE("(%p/%p)->(%s,%x)\n", This, iface, debugstr_w(filenam

Re: [PATCH] amstream: Display new ref in AddRef and Release.

2012-10-11 Thread Nikolay Sivov
On 10/12/2012 00:46, Christian Costa wrote: --- dlls/amstream/mediastreamfilter.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/dlls/amstream/mediastreamfilter.c b/dlls/amstream/mediastreamfilter.c index ee9d970..0e56a68 100644 --- a/dlls/amstream/medias

Re: [1/3] cmd/tests: Show name of current test file on standard output

2012-10-11 Thread Alexandre Julliard
Frédéric Delanoy writes: > When there are several test files, indicates which file error line numbers > relate to, making > "debugging" easier. That's what trace() is for. -- Alexandre Julliard julli...@winehq.org

Re: gdi32: use HandleToULong inline function to convert handle to index instead of casting

2012-10-11 Thread Alexandre Julliard
Daniel Lehman writes: > I'll admit that the upper 32 bits being set was because of a quirk in > our C++ code, but similar values passed to Windows worked This would need some test cases. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 4/6] include: Added definitions used by OpenFileById. (try 2)

2012-10-11 Thread Francois Gouget
On Thu, 11 Oct 2012, Vincas Miliūnas wrote: > On 10/11/2012 04:30 AM, Dmitry Timoshkov wrote: > > "Vincas Miliūnas" wrote: > > > >> * Renamed DUMMYUNIONNAME to u. > > ... > >> +typedef struct _FILE_ID_DESCRIPTOR { > >> +DWORDdwSize; > >> +FILE_ID_TYPE Type; > >> +union { > >>

Re: [PATCH 1/4] jscript: Use custom string container instead of BSTR.

2012-10-11 Thread Charles Davis
On Oct 11, 2012, at 4:16 AM, Jacek Caban wrote: > This patch alone makes SunSpider 0.9 17x faster. Seems to me that something is really wrong with our BSTR implementation if replacing it with a home-grown implementation speeds this up by a factor of 17. Chip

Re: [PATCH 4/6] include: Added definitions used by OpenFileById. (try 2)

2012-10-11 Thread Dmitry Timoshkov
"Vincas Miliūnas" wrote: > Unless you mind sharing why it is wrong, I will not be able to read your > mind. Just do your homework and have a look at other places that use DUMMYUNIONNAME. -- Dmitry.

Re: [PATCH 4/6] include: Added definitions used by OpenFileById. (try 2)

2012-10-11 Thread Vincas Miliūnas
On 10/11/2012 04:30 AM, Dmitry Timoshkov wrote: > "Vincas Miliūnas" wrote: > >> * Renamed DUMMYUNIONNAME to u. > ... >> +typedef struct _FILE_ID_DESCRIPTOR { >> +DWORDdwSize; >> +FILE_ID_TYPE Type; >> +union { >> +LARGE_INTEGER FileId; >> +GUID ObjectId

RE: gdi32: use HandleToULong inline function to convert handle to index instead of casting

2012-10-11 Thread Daniel Lehman
> It can't, the code explicitly casts handle to unsigned before the > shift. It's cast to a 64-bit unsigned, so the upper 32 bits are kept for the shift One of the pointers passed in was: 0xff26a8 after the shift, it became: 0xff26a8 => 0x3fc9aa When assigned to the 32

Re: [2/2] shlwapi/tests: Add more PathCreateFromUrl() tests.

2012-10-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22127 Your paranoid android

Re: [PATCH 1/4] jscript: Use custom string container instead of BSTR.

2012-10-11 Thread Jacek Caban
On 10/11/12 12:39, Henri Verbeet wrote: > On 11 October 2012 12:16, Jacek Caban wrote: >> +struct _jsstr_t { >> +unsigned length_flags; >> +unsigned ref; >> +WCHAR str[1]; >> +}; > It's probably much too late for jscript, and perhaps Wine in general, > but strictly speaking the _t suff

Re: [PATCH 5/6] mshtml: Added createStyleSheet and get_styleSheet tests

2012-10-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22123 Your paranoid android

Re: msvcp90: fix parsing in num_get<>::_Getifld

2012-10-11 Thread Piotr Caban
On 10/11/12 00:27, Daniel Lehman wrote: -if(!base && first->strbuf && first->val==digits[0]) { +if(first->strbuf && first->val==digits[0]) { +found_zero = TRUE; istreambuf_iterator_wchar_inc(first); if(first->strbuf && (first->val==mb_to_wc('x', &this->cvt) || fi

[PATCH 17/25] winmm/tests: Add initial set of MCI MIDI tests (incl. DeleteFile)

2012-10-11 Thread Joerg-Cyril.Hoehle
Hi, >Von: Marvin [test...@testbot.winehq.org] >Gesendet: Mittwoch, 10. Oktober 2012 15:34 >While running your changed tests on Windows, I think I found new failures. >Patch failed to apply As Marvin woke up 5 days after patch submission, it did not realize that patches 1-6 had been applied since.

Re: [PATCH 1/4] jscript: Use custom string container instead of BSTR.

2012-10-11 Thread Henri Verbeet
On 11 October 2012 12:16, Jacek Caban wrote: > > +struct _jsstr_t { > +unsigned length_flags; > +unsigned ref; > +WCHAR str[1]; > +}; It's probably much too late for jscript, and perhaps Wine in general, but strictly speaking the _t suffix is reserved by POSIX.

Re: [PATCH 4/4] mshtml: Added IHTMLDocument::get_charset implementation

2012-10-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22114 Your paranoid android

[PATCH 10/25] mciseq: Limit concurrency when starting to play.

2012-10-11 Thread Joerg-Cyril.Hoehle
David Laight wrote: >> InterlockedExchange(&status, wmm->dwStatus); >That use of InterlockedExchange() is OTT. Thank you for the clarification. I've come across http://gcc.gnu.org/wiki/Atomic/GCCMM http://gcc.gnu.org/wiki/Atomic/GCCMM/PracticalUsage and found the official expression for what I've